Re: libreoffice patch

Hi Ricardo, 2012/8/18 Ricardo Montania : > Hello. First commit. :) > > EasyHacking, unused code. Any problem, please tell me. > The pacth looks good, I'll integrate it soon. Would you mind sending a blanket licence statement to this mailing list, such as "All of my past & future contributions to

Re: [Libreoffice][PATCH][PUSHED] modify default behaviour of the format paintbrush

On Wed, 2012-03-28 at 17:48 +0200, Maxime de Roucy wrote: > Hello, > > I am writing this mail trying to prevent this thread from dying… > > So, what do you think about changing the default behavior of the format > paintbrush ? Re-reviewing this, it seems reasonable to me. So I've (finally) pushe

Re: [Libreoffice] [PATCH][PUSHED] add function in SwEditShell and fix some comments

On Wed, 2012-03-14 at 12:58 +0100, Maxime de Roucy wrote: > Hello > > Here is 2 new patch : > 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch > > Create the function GetCurParAttr and GetPaMParAttr in the SwEditShell > class. The function will be used in future patchs (on the format

Re: [Libreoffice][PATCH] Prevent print settings dialog to show help button when it's called from help window

The patch 0003 introduce a bug : -if ( SID_PRINTER_NAME == nId ) -{ -// just set a recorded printer name -if ( pPrinter ) -SetPrinter( pPrinter, SFX_PRINTER_PRINTER ); -break; -} please wait be

Re: [Libreoffice] [PATCH] Corrected typo in names of four swriter classes

Hi Christoph, On Mon, 2011-02-07 at 21:30 +0100, Christoph Herzog wrote: > Checked for the misspelled names via ./g grep, built master before and > after the changes and no error occurred. So hopefully it is ok. ... > patch under LGPLv3+/MPL. I'm just working through the MPL/LGPLv3+ re-li

Re: [Libreoffice] [PATCH] Translate german comments

Am 2012-05-01 12:13, schrieb Michael Meeks: > Hi Martin, > > On Thu, 2011-05-19 at 19:21 +0200, Martin Kepplinger wrote: >> Translate german code comments in writer/sw/source/ui/lingu to english! >> >> This is contributed under the terms of the MPL 1.1 / GPLv3+ / LGPLv3+ triple >> license. > >

Re: [PUSHED] Re: [Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs

Hi, Kendy All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thank you for the information! Victor Lee On Thu, Apr 5, 2012 at 1:42 AM, Jan Holesovsky wrote: > Hi Victor, > > Victor Lee píše v Ne 25. 12. 2011 v 01:41 +0900: > >> I've reforma

[PUSHED] Re: [Libreoffice] [PATCH] Fix fdo#39639 [EasyHack] Fix duplicate longname IDs

Hi Victor, Victor Lee píše v Ne 25. 12. 2011 v 01:41 +0900: > I've reformatted the patch. > The reason for deleting these IDs is stated here: > https://bugs.freedesktop.org/show_bug.cgi?id=39639 > > Sorry for the late reply, and thank you for the advice! > This is my first EasyHack. While clean

Re: [Libreoffice] [PATCH][PUSHED] format clipboard

oops forgot to update title On Wed, 2012-03-28 at 12:09 +0200, Cedric Bosdonnat wrote: > Hi Maxime, > > On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote: > > I hope this clarified a bit my choice to remove the "nSelectionType == > > nsSelectionType::SEL_TBL" part from the lcl_CreateEmptyI

Re: [Libreoffice] [PATCH] format clipboard

Hi Maxime, On Tue, 2012-03-27 at 18:57 +0200, Maxime de Roucy wrote: > I hope this clarified a bit my choice to remove the "nSelectionType == > nsSelectionType::SEL_TBL" part from the lcl_CreateEmptyItemSet > function. Thanks for the details, I pushed the patch and the others that were needed (an

Re: [Libreoffice] [PATCH] format clipboard

Hello, Following my discussion with Cedric on IRC here is some other explanations on why I chose to remove the "nSelectionType == nsSelectionType::SEL_TBL" case from the lcl_CreateEmptyItemSet function in formatclipboard.cxx. Without the patch : lcl_CreateEmptyItemSet is called only in the format

Re: [Libreoffice] [PATCH] format clipboard

Here a copy of the mail I send to Cedric Bosdonnat… forgot to add the list as "Cc:". Hello Thanks you for asking me… When you select a cell in Writer the selection type is a mix of nsSelectionType::SEL_TBL_CELLS, nsSelectionType::SEL_TBL and nsSelectionType::SEL_TXT. So when the lcl_CreateEmptyI

Re: [Libreoffice] [PATCH][PUSHED] export to xls warning ; work in SwEditShell::GetPaMTxtFmtColl

oops, forgot to update the subject On Thu, 2012-03-15 at 17:02 +0100, Cedric Bosdonnat wrote: > Hello Maxime, > > On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote: > > Feel free to comment my code ! > > Many thanks for your 4 patches. I fixed a few typos (or frenglish words) > and pushed

Re: [Libreoffice] [PATCH] format clipboard

Hi Maxime, On Wed, 2012-03-14 at 16:50 +0100, Maxime de Roucy wrote: > Here is some new patchs on the format clipboard. The first just add some > comment in the formatclipboard.hxx file. The second one depend on > modifications I made in the previous patch > 0001-add-GetCurParAttr-and-GetPaMParAtt

Re: [Libreoffice] [PATCH] export to xls warning ; work in SwEditShell::GetPaMTxtFmtColl

Hello Maxime, On Tue, 2012-03-13 at 17:52 +0100, Maxime de Roucy wrote: > Feel free to comment my code ! Many thanks for your 4 patches. I fixed a few typos (or frenglish words) and pushed them to master. Feel free to provide more patches like these. -- Cedric __

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

Hi Stefan, Stefan Knorr (Astron) wrote (06-03-12 14:40) What specifically doesn't work for you? For me it's about okay ~today. (I remember August promised you a better solution for later, though.) It is about navigating through the various sections (left) with the arrow keys. If that does not

Re: [Libreoffice] [PATCH] add function in SwEditShell and fix some comments

Attention : the patch 0001-add-GetCurParAttr-and-GetPaMParAttr-in-SwEditShell.patch need the preview patch 0004-SwEditShell-use-of-the-STL-swap-function.patch which is currently waiting for moderator approval to be published in the mailing list. -- Maxime de Roucy Groupe LINAGORA - OSSA 80 rue Ro

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

Hi Cor, What specifically doesn't work for you? For me it's about okay ~today. (I remember August promised you a better solution for later, though.) Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

Cor Nouws wrote (03-03-12 22:29) However, when I work in a build from last week (1), I see that navigating the option pages (sections, left panel of the window) with arrow keys does not work. 1) LibreOffice master 120116 3.6.0alpha0+ a9ebfbc-9eed775-f061262-libreoffice-3-5 branch-point I ha

Re: [Libreoffice] [PATCH] [PUSHED] Automatically select an option page if a user clicks on a category

Hi all, Regarding this change, I remember I had some discussion (or a bug) about the fact that navigation of the option page was broken by the patch. And I see this commit in git: 064065985a24e2454234e929969cc2b1649b3d01 However, when I work in a build from last week (1), I see that navigatin

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On Mon, Feb 13, 2012 at 12:23, Noel Power wrote: > On 09/02/12 14:53, Albert Thuswaldner wrote: >>> 2) When trying to delete text in the edit box, the last character >>> sticks (can't be deleted). > > well that would seem to be because your code thinks a blank prefix is > illegal, I believe chang

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 09/02/12 14:53, Albert Thuswaldner wrote: If it was up to me I would go for the visual bell. Any thoughts on this? actually thinking about it some more I don't find it unnatural to have the whole ( reverted ) prefix selected after entering an illegal character ( I think this is a technique u

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 09/02/12 14:53, Albert Thuswaldner wrote: Hi, [...] So I have improved the patch according to Kohei's suggestion above. Now I store the prefix at each key-stroke and check for illegal characters. When an illegal character is entered, the text is reverted back to the last good prefix. (So ba

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi Albert, > At least I get two annoying bugs: > 1) The cursor moves In front of the text when the Prefix is reverted. > 2) When trying to delete text in the edit box, the last character > sticks (can't be deleted). > > Does someone have a clue whats going on? Hm, no (not a coder I am). But can y

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi, > > Given that, I still think it's better (and easier) to check for every > key-press, but instead of launching an error dialog for an illegal name, > just put the old legal name back into the text box and sound an beep or > something.  That's less intrusive than a big dialog being thrown righ

[PUSHED] Re: [Libreoffice] [PATCH] Remove unused code

Noel Power píše v Út 31. 01. 2012 v 12:39 +: > ok, pushed, Just marking the thread [PUSHED] :-) Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

Hi Albert, Good to see you being active again. :-) On Fri, 2012-02-03 at 11:47 +0100, Albert Thuswaldner wrote: > I have updated the patch according to Markus comments above, removing > the check to see if the keybinding option has been modified. A side > effect of the above is that return type

Re: [Libreoffice] [PATCH] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

this patch is going to superceded soon by a cleaner one. On 2012-02-02 14:57, Noel Grandin wrote: Hi Attached patch converts various places in the editeng, sc and sw modules from using tools/table.hxx to using std::map This patch should be easier to review, mostly because the logic using th

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

On 02/02/12 18:17, Muhammad Haggag wrote: On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag > wrote: On Thu, Feb 2, 2012 at 2:01 PM, Noel Power mailto:nopo...@suse.com>> wrote: very nice patch, looking at the spec I agree and this looks like a credibl

Re: [Libreoffice] [PATCH] Moving misplaced Compatibility options from ScDocOptions to ScAppOptions

Hi, This is an old topic again... On Tue, Jul 12, 2011 at 00:26, Markus Mohrhard wrote: > Hello Albert, > > nice work but I have some comments. > > Operator== should have return type bool and not int(I saw that ScDocOptions > used int too, but I have changed that already). > But all in all I thin

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

On Thu, Feb 2, 2012 at 5:13 PM, Muhammad Haggag wrote: > On Thu, Feb 2, 2012 at 2:01 PM, Noel Power wrote: > >> very nice patch, looking at the spec I agree and this looks like a >> credible fix for me so pushed to master. Look forward to more like this, >> thanks >> >> Thanks for the review! If

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

On Thu, Feb 2, 2012 at 2:01 PM, Noel Power wrote: > very nice patch, looking at the spec I agree and this looks like a > credible fix for me so pushed to master. Look forward to more like this, > thanks > > Thanks for the review! If you'd pardon my absolute noobiness, do I have access to push to

Re: [Libreoffice] [PATCH]a better about dialog

Hi Barış On 01/02/12 18:28, Barış Akkurt wrote: Hi, everyone. This is my first trial of sending a patch for LibreOffice. I worked on this bug: https://bugs.freedesktop.org/show_bug.cgi?id=31022 My design is not as good as the design by Andrew, but I think it looks better than previous one.

Re: [Libreoffice] [PATCH] fdo#43398: FORMATTING: Documents opened in LibreOffice Writer incorrectly appear as right justified

On 01/02/12 19:21, Muhammad Haggag wrote: Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43398 Cause: dmapper used to treat the presence of a w:BiDi element in a paragraph's properties as an indicator of RTL directionality, which is incorrect. A w:BiDi element may have a value of 0, indicat

Re: [Libreoffice] [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

Hi Caolán, 30.01.2012 21:08, Caolán McNamara пишет: The original code with... git show 7b0b5cdf source/ui/inc/scroll.hxx source/ui/uiview/scroll.cxx it seems that this SwScrollbar had its own SwScrollbar::Show method and inherits from Window which has a Window::Show method as well. The Window::S

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

On 01/02/12 11:59, Noel Grandin wrote: On 2012-02-01 13:58, Noel Power wrote: e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as the vector will go out of scope here anyway and delete the container contents. Really? I wasn't sure about that - the boost documentation is

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

On 2012-02-01 13:58, Noel Power wrote: e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as the vector will go out of scope here anyway and delete the container contents. Really? I wasn't sure about that - the boost documentation isn't that great. So I scanned the LibO co

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

Hi Noel On 31/01/12 14:24, Noel Grandin wrote: sorry, that should be "converted to std::vector" you mean boost::ptr_vector I think :-) Hope I didn't miss anything this time, I made some minor changes ( see attached patch ) e.g. I removed the maLayoutNames.clear() from :~SdPresLayoutDlg() as

Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans

+1 from me too... On 02/01/2012 03:58 PM, Noel Power wrote: > On 31/01/12 22:14, Lionel Elie Mamane wrote: >> Attached patch fixes fdo#45453, which breaks datasheet display of all >> queries/tables (with more than twice the number of rows than fit on >> screen), if the database system does not pro

Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans

Hi Lionel, On 2012-01-31 at 23:14 +0100, Lionel Elie Mamane wrote: > Attached patch fixes fdo#45453, which breaks datasheet display of all > queries/tables (with more than twice the number of rows than fit on > screen), if the database system does not properly support boolean > types. > > The or

Re: [Libreoffice] [PATCH] [REVIEW:3-5] fdo#45453 cannot execute any query if database does not support booleans

On 31/01/12 22:14, Lionel Elie Mamane wrote: Attached patch fixes fdo#45453, which breaks datasheet display of all queries/tables (with more than twice the number of rows than fit on screen), if the database system does not properly support boolean types. The original bug report is about Firebir

Re: [Libreoffice] [PATCH] unusedcode.easy: Removed unused code (basegfx)

Hi Alexander After applying this doesn't compile for me, at least in a couple of instances there appear to be getEmptyTuple methods still referenced in the code ( e.g. b32point.hxx:122 ), I knocked out a couple of those but then some errors started appearing in some of the cxx files. Now before

Re: [Libreoffice] [PATCH] cygwin is $build_os, not $_os & voreppe needs love

Hello Norbert, On Tue, Jan 31, 2012 at 00:52, Norbert Thiebaud wrote: > this would be a run-time issue, so the test is not  'build_os' = > "cygwin"  but $_os = "WINNT" Thanks! :-) Fixed and pushed as http://cgit.freedesktop.org/libreoffice/core/commit/?id=f18cae12960e945240b8fbd76f9a214d464b71b3

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hello Le Tue, 31 Jan 2012 21:48:30 +0100, Noel Power a écrit: On 31/01/12 20:29, Kohei Yoshida wrote: Well, that's rather hard to do with the Options dialog, since you can freely switch between different option pages and we then would have to check the validity of all the option tab pages upo

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 31/01/12 20:29, Kohei Yoshida wrote: Well, that's rather hard to do with the Options dialog, since you can freely switch between different option pages and we then would have to check the validity of all the option tab pages upon dismissal of the whole Options dialog... you're correct, just s

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi Albert, On Tuesday, 2012-01-31 19:35:54 +0100, Albert Thuswaldner wrote: > > However something I noticed is that there are still some problems with > > entering the 'Prefix name" in the options, firstly the input box seems to be > > overwritten by the label ( part of the input/edit field for t

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On Tue, 2012-01-31 at 20:07 +, Noel Power wrote: > On 31/01/12 18:35, Albert Thuswaldner wrote: > >> Additionally you still can get the prefix name to > >> > be blank ( or at least I managed to do that ) by attempting to change > >> > the > >> > name by delete, when all the name is deleted y

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 31/01/12 18:35, Albert Thuswaldner wrote: Additionally you still can get the prefix name to > be blank ( or at least I managed to do that ) by attempting to change the > name by delete, when all the name is deleted you get a message saying the > sheet prefix is illegal ( actually I find tha

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

Hi Ivan, On Tuesday, 2012-01-31 21:31:11 +0400, Ivan Timofeev wrote: > >should remove the first occurrence, care to fix ? > > so the exact equivalent of > > mpSdCustomShow->Remove(pPage->GetSdrPage()) > > will be: > > SdCustomShow::PageVec::iterator it = std::find( > mpSdCustomShow->Pages

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Hi, > However something I noticed is that there are still some problems with > entering the 'Prefix name" in the options, firstly the input box seems to be > overwritten by the label ( part of the input/edit field for the prefix is > missing until you type ) Hmm, strange, I haven't notice that mys

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 17:31, Ivan Timofeev wrote: 31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().beg

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 21:12, Noel Power пишет: should remove the first occurrence, care to fix ? so the exact equivalent of mpSdCustomShow->Remove(pPage->GetSdrPage()) will be: SdCustomShow::PageVec::iterator it = std::find( mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().e

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:20, Ivan Timofeev wrote: 31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomSh

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 16:17, Stephan Bergmann wrote: On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someon

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 31/01/12 15:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan nice cat

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi I fixed the english terminology, according to the justifications by Regina. regards Olivier Em 31-01-2012 11:28, Regina Henschel escreveu: > Olivier Hallot schrieb: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Hi Regina >> >> It has

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 05:19 PM, Noel Grandin wrote: I ran make check at the global level - does that not invoke the individual modules check targets? It does. Strange anyway. This failure is consistently reproducible for me and looks suspiciously like the remove problem discussed in this thread...

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:55, Ivan Timofeev пишет: I'll fix that. Hum; guys, what about - mpSdCustomShow->Remove(pPage->GetSdrPage()); + ::std::remove(mpSdCustomShow->PagesVector().begin(), mpSdCustomShow->PagesVector().end(), + pPage->GetSdrPage()); mpSdCustomShow->Remove(pPage->GetSdrPage()); <- using

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

I ran make check at the global level - does that not invoke the individual modules check targets? On 2012-01-31 18:17, Stephan Bergmann wrote: Looks like you missed to run make check: LOG> 1. removeByIndex("1") ...OK LOG> removing a non existent object to get an exception LOG> 2. removeByInde

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 01/31/2012 03:22 PM, Noel Power wrote: I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed something ( 'cause these really are tricky ) then someone else will spot it. Anyway thanks again for

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hello, On 31/01/12 17:10, Michael Meeks wrote: > Interesting (in a world with infinite time); would the mingw > cross-compile be call-catcher-able such that we could get a more precise > and comprehensive list ? Yes, at the level of callcatcher 1.1.3, I added the support for gnu assembler f

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 16:10 +, Michael Meeks wrote: > On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > > cc'ing Caolán as he might be interested because it doesn't turn up in > > > the unused.easy > > > > Its windows only co

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

thanks, still working out how this STL stuff hangs together. On 2012-01-31 17:55, Ivan Timofeev wrote: 31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 13:21 +, Caolán McNamara wrote: > On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > > cc'ing Caolán as he might be interested because it doesn't turn up in > > the unused.easy > > Its windows only code, and callcatcher can only see what gets compiled > as its just a

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 19:42, Noel Grandin пишет: So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? maPages.erase( std::remove(maPages.begin(), maPages.end(), pOldPage), maPages.end() ); I'll fix that. Ivan ___ Li

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

So I should be calling maPages.erase( std::find(maPages.begin(), maPages.end(), pOldPage) ); ?? On 2012-01-31 17:24, Ivan Timofeev wrote: 31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

On Tue, 2012-01-31 at 00:00 +0100, Regina Henschel wrote: > The term "inverse" is not correct in this context. It should be > "reciprocal" instead. > Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC. I agree Regina, you have unusually good English :-) Any chance

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

31.01.2012 18:22, Noel Power пишет: On 30/01/12 13:54, Noel Grandin wrote: Attached patch converts SdCustomShow to use std::vector. I hate these remove list etc. type patches as they tend to be tricky and time consuming to look at ;-) . The patch looked ok for me, hopefully if I missed somethin

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 31/01/12 12:46, openoff...@schierla.de wrote: Noel Power wrote: I cc some writer experts who may suggest some alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour

Re: [Libreoffice] [PATCH] convert SdPresLayoutDlg from tools/list.hxx to std::map

sorry, that should be "converted to std::vector" On 2012-01-31 16:22, Noel Grandin wrote: Hi Attached patch converts SdPresLayoutDlg to use std::map. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html ___

Re: [Libreoffice] [PATCH V2] convert SdCustomShow from tools/list to vector

On 30/01/12 13:54, Noel Grandin wrote: Hi Attached patch converts SdCustomShow to use std::vector. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html I hate these remove list etc. type patches as they tend to be tricky and tim

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

Olivier Hallot schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Regina It has been decades since I handled groups, rings, fields, and functions in my french lycée. Now I am confused because it looks like the two terms are swapped between french and english... Regards Olivier In fren

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

On Tue, 2012-01-31 at 11:15 +, Noel Power wrote: > cc'ing Caolán as he might be interested because it doesn't turn up in > the unused.easy Its windows only code, and callcatcher can only see what gets compiled as its just a compiler wrapper and I run it under Linux. C. __

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

Noel Power wrote: > I cc some writer experts who may suggest some > alternative solution(s) or change ( or maybe say it is perfect ) The new patch in this e-mail should provide even better performance (as it only clears the contour cache for contour wrapped drawing objects). > Can you confirm you

Re: [Libreoffice] [PATCH] Remove unused code

On 31/01/12 11:05, Elton Chung wrote: Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. ok, pushed, thank, ps. next time don't chop off the header of the formatted patch 'cause '

Re: [Libreoffice] [PATCH] contour handling for anchored draw objects in writer (fix for bugs 34611 and 45376)

On 30/01/12 22:53, Andreas Schierl wrote: Hi, I found out that bugs https://bugs.freedesktop.org/show_bug.cgi?id=34611 https://bugs.freedesktop.org/show_bug.cgi?id=45376 are caused by a missing call to ClrContourCache( pObj ); in /sw/source/core/layout/pagechg.cxx: void lcl_Move

Re: [Libreoffice] [PATCH] Removed unused ImplSalLogFontToFontA()

Hi Christina On 31/01/12 10:43, Chr. Rossmanith wrote: Hi, ImplSalLogFontToFontA() seems to be unused. I don't have a Windows build environment I couldn't test whether it really builds after removing the method. But I don't see why it shouldn't... Christina I'd say commit it, can't see this

Re: [Libreoffice] [PATCH] Remove unused code

Hi Noel, *, I have attached the patch as an attachment. I also confirm that this contribution, as well as future ones are licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Best Regards, Elton -- Elton Chung Administrator, sponsor of mirror.layerjet.com Language Maintainer of ReactOS Open Source operat

Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

Am 31.01.2012 11:43, schrieb Noel Power: On 31/01/12 09:11, Chr. Rossmanith wrote: please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated c

Re: [Libreoffice] [PATCH] SIMIAN: Reduced duplicate code

On 31/01/12 09:11, Chr. Rossmanith wrote: Hi, please have a look at the comments marked with "crossmanith". I can push on my own but a short review (and feedback) would be nice. isn't it that nInc can only be either 2, 4, 10 or 20 so that line indicated can't afaics be reached and nSteps wo

Re: [Libreoffice] [PATCH] Remove unused code

Hi Elton First thanks for submitting your patch, it's appreciated however could I ask if you could please repost your patch as an attachment [1] ? patch content inline in a mail message just does't work as the mail client breaks the lines in such a way as the patch program no longer understand

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Regina It has been decades since I handled groups, rings, fields, and functions in my french lycée. Now I am confused because it looks like the two terms are swapped between french and english... Regards Olivier In french: http://fr.wikipedia.or

Re: [Libreoffice] [PATCH] CSC, SEC, CSCH & SECH Help missing, How to add one? ref: bug fdo#44792

Hi Oliver, Olivier Hallot schrieb: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Please find the patch attached. The term "inverse" is not correct in this context. It should be "reciprocal" instead. Example: The inverse of SIN is ASIN. The reciprocal of SIN is CSC. Kind regards Regin

Re: [Libreoffice] [PATCH] Additional translations of German comments in libs-core/sfx2/source/

Hi Michael, >        Gosh; did this get sorted out in the end ? :-) do you have code that is > not committed to master ? > Sorry for the late reply on this. I have check these patches against the git log. It is all committed to master. Thanks for asking. /Albert

Re: [Libreoffice] [PATCH] cygwin is $build_os, not $_os & voreppe needs love

On Mon, Jan 30, 2012 at 11:05 AM, Korrawit Pruegsanusak wrote: > Hello Norbert, all, > > As compiling --with-mozilla-build on msvc/cygwin, it also needs msvc > 2005 runtime library in 'instsetoo_native'. > But a check in configure.in might be incorrect, so patch attached & > review appreciated. :-

Re: [Libreoffice] [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

On Sun, 2012-01-29 at 15:01 +0400, Ivan Timofeev wrote: > what is the reason to have this flag? Why only set this flag without > actually showing? And why not change this flag accordingly when actually > showing? (This is what the patch fixes.) Digging into the git history it looks like a collec

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

On Mon, Jan 30, 2012 at 04:55:51PM +0100, Stephan Bergmann wrote: > On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote: >> I attach here the "less invasive" variant originally meant for >> libreoffice-3-5. > My SQL knowledge is actually zero. For example, I have no idea > where to look to verify t

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote: I attach here the "less invasive" variant originally meant for libreoffice-3-5. My SQL knowledge is actually zero. For example, I have no idea where to look to verify that for some SQL_ATTR_CURSOR_TYPE, say, SQLGetStmtAttr expects to find a b

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

On Mon, Jan 30, 2012 at 02:08:54PM +, Michael Meeks wrote: > On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote: >> The attached >> 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch >> appears to be completely unrelated? > True :-) Yes, I used an older email as a

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote: > The attached > 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears > to be completely unrelated? True :-) I suspect the patch intended is attached; the patch it refers to is already merged. This has my ack

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 30/01/12 13:14, Noel Power wrote: Albert On 30/01/12 13:07, Noel Power wrote: Hi I pushed it to master, it's a nice patch incase you look for your patch, well I thought I committed it but only noticed now there is a conflict message, will fix after some food hopefully I didn't screw it up (

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

Albert On 30/01/12 13:07, Noel Power wrote: Hi I pushed it to master, it's a nice patch incase you look for your patch, well I thought I committed it but only noticed now there is a conflict message, will fix after some food ___ LibreOffice mailing li

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

On 27/01/12 23:50, Albert Thuswaldner wrote: Hi, Shows a number of likely candidates; connecting to the 'ModifyHdl' and running the validator on the name, removing characters if it not valid might work; but of course. git grep SetModifyHdl for some instances of that; p

Re: [Libreoffice] [PATCH] add include directory for ldap.h, fix msvc build

Hello Tor, Fridrich, On Sun, Jan 29, 2012 at 02:19, Fridrich Strba wrote: > It can use the native Windows API, yes. I ported it to use the mozilla stuff > especially so that the Linux build doesn't need to rely on openldap and I > set it for Windows too not to have many different code paths. Tha

Re: [Libreoffice] [PATCH] use SAL_CALL to fix build in msvc

On 29/01/12 11:35, Korrawit Pruegsanusak wrote: Hello Stephan, all, MSVC complains about error C2695 [1] while building, so I try to fix it with the attached patch, and the noise is now silent. But the build isn't success yet: still has problem in 'test', which I can't figure out. So, this patc

Re: [Libreoffice] [PATCH] [REVIEW:3-5, 3-5-0] fdo#34432 ODBC crash on 64 bits

On 01/29/2012 09:36 PM, Lionel Elie Mamane wrote: Attached patch fixes fdo#34432, a crash with some ODBC drivers. The bug report is about Firebird SQL. The attached 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears to be completely unrelated? Stephan

Re: [Libreoffice] [PATCH] fdo#45285 - Use more revealing error message for not allowed sheet names

Hi, > Hi Albert, > >> ... The sheet name must not be a duplicate of an existing name. > > Yes. > >> ... Further it must be 31 or fewer characters and can not contain the > >> characters [ ] * ? / \ . > > No, AFAIK there is no " <= 31" restriction. And '.' isn't a forbidden > character, see the sou

Re: [Libreoffice] [PATCH] add include directory for ldap.h, fix msvc build

It can use the native Windows API, yes. I ported it to use the mozilla stuff especially so that the Linux build doesn't need to rely on openldap and I set it for Windows too not to have many different code paths. F. Sent from Samsung Mobile Tor Lillqvist wrote: > I've attached a patch to fi

Re: [Libreoffice] [PATCH] add include directory for ldap.h, fix msvc build

> I've attached a patch to fix msvc build. Currently it has problem in > postgresql with ldap.h not found. I very much doubt using some random Mozilla header file that happens to have the same name ldap.h is a good idea. Presumably we would want to use the built-in Windows LDAP API. Is this Postgr

Re: [Libreoffice] [PATCH] fdo#45285 - Use more revealing error message for not allowed sheet names

28.01.2012 08:41, Korrawit Pruegsanusak пишет: Hello guys, Forwarding this to ux-advise. Could you please have a look? Thanks :-) On Sat, Jan 28, 2012 at 07:19, Albert Thuswaldner wrote: Hi, Here is a simple patch which includes a more informative error message when the user enters an invali

  1   2   3   4   5   6   7   8   9   10   >