Re: [Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-20 Thread Matúš Kukan
On 20 July 2011 04:51, Joseph Powers wrote: > > I only compile for Mac OS; thus, I only compile /vcl/aqua & /vcl/source. If > you watch your compile, you should only compile /vcl/unx & /vcl/source. We > also have /vcl/win for those brave people who compile on Windows. > I'm sorry again. Did not

Re: [Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-19 Thread Joseph Powers
On Jul 19, 2011, at 7:34 AM, Matúš Kukan wrote: > On 19 July 2011 14:22, Joseph Powers wrote: >> >> A List<> would be better; however, it's a list of pointers so the size >> isn't that big. >> > So why not use it ? > I did not mean the actual size in memory but the number of elements. > I've

Re: [Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-19 Thread Matúš Kukan
On 19 July 2011 14:22, Joseph Powers wrote: > > A List<> would  be better; however, it's a list of pointers so the size isn't > that big. > So why not use it ? I did not mean the actual size in memory but the number of elements. I've seen there around 150 elements when I tried to print the size.

Re: [Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-19 Thread Joseph Powers
On Jul 19, 2011, at 12:51 AM, Matúš Kukan wrote: > Hi Joe, > > On 19 July 2011 06:40, Joseph Powers wrote: >> I'd like someone doing a Unix build to review this for me. I compile Mac and >> this is Unix only code so I don't just want to push and hope... >> > First I thought it would compile a

Re: [Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-19 Thread Matúš Kukan
Hi Joe, On 19 July 2011 06:40, Joseph Powers wrote: > I'd like someone doing a Unix build to review this for me. I compile Mac and > this is Unix only code so I don't just want to push and hope... > First I thought it would compile and want just to write something but then I tried and it doesn't

[Libreoffice] [PATCH] Replace List with std::vector< ImplBmpObj* >

2011-07-18 Thread Joseph Powers
I'd like someone doing a Unix build to review this for me. I compile Mac and this is Unix only code so I don't just want to push and hope... Thanks, Joe P. 0001-Replace-List-with-std-vector-ImplBmpObj.patch Description: Binary data ___ LibreOffice m

Re: [Libreoffice] [PATCH] Replace List with std::vector

2011-06-30 Thread Francois Tigeot
On Thu, Jun 30, 2011 at 09:14:02PM +0200, Thorsten Behrens wrote: > Radek Doulík wrote: > > > It looks like libs-gui/uui/source/services.cxx registers the component > > > and sets up the factory for generating the dialogs. Because it's a > > > component system, I'm not sure how to unplug it and/or

Re: [Libreoffice] [PATCH] Replace List with std::vector

2011-06-30 Thread Thorsten Behrens
Radek Doulík wrote: > > It looks like libs-gui/uui/source/services.cxx registers the component > > and sets up the factory for generating the dialogs. Because it's a > > component system, I'm not sure how to unplug it and/or verify how it > > would be used. > > the code looks dead to me as well, b

Re: [Libreoffice] [PATCH] Replace List with std::vector

2011-06-30 Thread Radek Doulik
Hi Joseph, On Thu, 2011-06-23 at 20:41 -0700, Joseph Powers wrote: > Ok, this patch compiles fine; however, I can't find where it's used. > Also, I think it's unused; it looks a lot like leftovers of when > OpenOffice had a web browser. If some can verify, that it's trash, a > few pointers in to h

[Libreoffice] [PATCH] Replace List with std::vector

2011-06-23 Thread Joseph Powers
Ok, this patch compiles fine; however, I can't find where it's used. Also, I think it's unused; it looks a lot like leftovers of when OpenOffice had a web browser. If some can verify, that it's trash, a few pointers in to how to remove it would be nice. It looks like libs-gui/uui/source/service

[Libreoffice] [PATCH] Replace List with std::vector<>

2011-06-19 Thread Joseph Powers
I'm sending the patch for review; not because it needs a lot but just to have someone verify that the memory was leaking and needs to be fixed. Current fixes: 1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it. Future Fixes: 1. List* pBmpList; Should be replaced with a st

Re: [Libreoffice] [PATCH] Replace List with std::vector in SD

2011-06-16 Thread Rafael Dominguez
Attatched the respective patch file On Wed, Jun 15, 2011 at 7:39 PM, Rafael Dominguez wrote: > Theres a assertion i didnt include in the patch, but now been thinking > about it and maybe we should include it just in case we forget to include an > action. > From 8cafc607d507502692b3781ae6a6ba53b3b

Re: [Libreoffice] [PATCH] Replace List with std::vector in SD

2011-06-16 Thread Rafael Dominguez
Ooops forgot to attach patch On Wed, Jun 15, 2011 at 7:35 PM, Rafael Dominguez wrote: > > From 1b72022c8169b41786c71ee52776da60418341c5 Mon Sep 17 00:00:00 2001 From: Rafael Dominguez Date: Sun, 12 Jun 2011 18:37:27 -0430 Subject: [PATCH 3/9] Replace List with std::vector. --- sd/source/core/s

[Libreoffice] [PATCH] Replace List with std::vector in SD

2011-06-15 Thread Rafael Dominguez
Theres a assertion i didnt include in the patch, but now been thinking about it and maybe we should include it just in case we forget to include an action. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[Libreoffice] [PATCH] Replace List with std::vector in SD

2011-06-15 Thread Rafael Dominguez
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice