I'm sending the patch for review; not because it needs a lot but just to have 
someone verify that the memory was leaking and needs to be fixed.

Current fixes:
1. XPropertyList::Clear() looks like it has a memory leek; so I fixed it.

Future Fixes:
1.   List* pBmpList; Should be replaced with a std::vector< Bitmap*>
2. I thinking that once pBmpList is a vector<> I should cleanup the 
constructors that pass initial size and resize values.
3. I'm noticing that several methods have extra parameters that aren't used. 
Should I include a patch to clean them up also?

Thanks,
Joe P.

Attachment: 0001-Replace-List-with-std-vector-XPropertyEntry.patch
Description: Binary data

_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to