Re: Libreoffice dev-install fail

2012-03-19 Thread Stefan Knorr (Astron)
Hi Jesso, On 20 March 2012 06:55, Jesso Murugan wrote: > Libreoffice built successfully but failed on > make dev-install as the following files were > missing. I made a git pull this morning. If you do "./g pull", your dictionaries repo should get updated, too. That might help. Can you try? As

Libreoffice dev-install fail

2012-03-19 Thread Jesso Murugan
Libreoffice built successfully but failed on make dev-install as the following files were missing. I made a git pull this morning. dict-an.oxt dict-be.oxt dict-bg.oxt dict-bn.oxt dict-el.oxt dict-gd.oxt dict-gu.oxt dict-hi.oxt dict-lv.oxt dict-si.oxt dict-te.oxt Copying dict-af.oxt and renaming i

Re: Worked in OOo, doesn't load well in LibO

2012-03-19 Thread Cor Nouws
Goedemorgen Joop. Joop KIEFTE wrote (19-03-12 22:02) Can anyone identify what's the problem in this document or in LibreOffice? As the man with the same first name as you have, used to say: two things: - http://wiki.documentfoundation.org/BugReport for an issue - pls don't overload the mailbox

[REVIEW-3-5] fix for fdo#47503, crash opening a xls file with chart

2012-03-19 Thread Markus Mohrhard
Hey, [1] fixes the crash opening the file in fdo#47503. The code in ScDocument::HasData needs to check that the sheet index is valid before it uses the sheet index to access the table. This patch is simple and safe and I think we easily integrate it into 3-5. Regards, Markus [1] http://cgit.fr

Re: [UX advise] Key navigation in ValueSet controls

2012-03-19 Thread Matteo Casalin
Hi Astron, thanks for you feedback. Before beginning to modify the behavior of key navigation, I'd like to recap the things that I should do, as from my understanding of our discussion. Would you mind confirming them (yes/no will suffice)? * left/right keys should not wrap around from top

Re: [PATCH] Deleting some commented out code.

2012-03-19 Thread Luke Petrolekas
and some more, also contributed under the LGPLv3+ / MPL. On Mon, Mar 19, 2012 at 6:46 PM, Luke Petrolekas wrote: > I would have thought we would have deleted all commented out stuff > already! :) Woot for first commit in nearly a year. > > Code is contributed under the LGPLv3+ / MPL. > > Luke > F

[PATCH] Deleting some commented out code.

2012-03-19 Thread Luke Petrolekas
I would have thought we would have deleted all commented out stuff already! :) Woot for first commit in nearly a year. Code is contributed under the LGPLv3+ / MPL. Luke From 78728d9fa94fe278190fe34145a2f0175e879487 Mon Sep 17 00:00:00 2001 From: Luke Petrolekas Date: Mon, 19 Mar 2012 18:12:35 -0

Re: [PATCH] Missing sub-menu arrows with 3.5.x and GTK < 2.15

2012-03-19 Thread David Bolen
On Mon, Mar 19, 2012 at 5:59 AM, Michael Meeks wrote: > >        Sounds very sensible. Just one minor complaint: - I loathe the > implementation of gtk_check_version - its impl. is as clear as mud, it > returns an non-translated string not a boolean etc. etc. ;-) > >        Any chance of a tweak t

Re: [REVIEW for 3.5] Fix redundant assignment of "nAngle" in switch in svx

2012-03-19 Thread julien2412
yep it creates fractal :-) More seriously, I saw that it's at least used here in this file sw/source/core/doc/tblafmt.cxx (line 413) Julien. -- View this message in context: http://nabble.documentfoundation.org/REVIEW-for-3-5-Fix-redundant-assignment-of-nAngle-in-switch-in-svx-tp3836734p3840462.

Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx

2012-03-19 Thread julien2412
Here is a patch : http://nabble.documentfoundation.org/file/n3840411/text_gfx_patch.txt text_gfx_patch.txt remarks : - I replaced this nChar >= 0xff62 && nChar < 0xff64 by this for readability nChar == 0xff62 || nChar == 0xff63 - I added in the outer "if", "nChar == 0xffe3" because if n

Re: Unused code patches

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, David T. Biedrzycki wrote: > Hello, > These patches are very small and pretty simple. The following patches > are contributed > under the LGPLv3+ / MPL. > > IIT's newly founded ACM is starting some work on open source project and > this is our first start. Attached are s

Unused code patches

2012-03-19 Thread David T. Biedrzycki
Hello, These patches are very small and pretty simple. The following patches are contributed under the LGPLv3+ / MPL. IIT's newly founded ACM is starting some work on open source project and this is our first start. Attached are some patches that remove some unnecessary code. We do have a question

Re: LibreOffice writer - GSoC 2012 idea proposal

2012-03-19 Thread Enrico Weigelt
> Searching across the files is definitely not a task for LibreOffice, > but rather to some Entreprise Content Managment (ECM) or > filesystem-related tool. ACK. But I could imagine some grep-alike tool specialized for odt files. ___ LibreOffice mailin

Re: [REVIEW][3-5] fix STL assertion in vcl graphite code

2012-03-19 Thread Martin Hosken
Dear Petr, Thank you for the reminder of this issue. My apologies for not getting to it earlier. > > > > I do not understand the code either. I just wonder if it would make > > sense to check for: > > > > while (++nCharIndex - mnMinCharPos < > > static_cast(mvChar2BaseG

Re: LibreOffice writer - GSoC 2012 idea proposal

2012-03-19 Thread Cedric Bosdonnat
Hello, On Sun, 2012-03-18 at 09:30 -0700, sharan_kumar wrote: > i am a student applicant for the gsoc 2012. i saw the projects proposed by > libreoffice. But finally came up with my own idea. My idea is "content based > search for file".. ie. we can search for files having certain contents.. it >

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 40958, which changed state. Bug 40958 Summary: EDITING: Copy row to clipboard incomplete ... or: pasting copied row to other rows, makes that data in that row is repeated until the last column https://bugs.freedesktop.o

Re: About Strings

2012-03-19 Thread Michael Meeks
On Mon, 2012-03-19 at 15:05 +0100, Michael Stahl wrote: > hmm... what i'd really like from a string class is that it has no > operator[] at all (who needs that anyway), just an iterator interface > that returns characters as uint32_t I'm personally somewhat skeptical that, even at a uint3

Re: About Strings

2012-03-19 Thread Enrico Weigelt
> the historical reason is that std::string is part of the C++ > standard > library, and implementations of that generally only started to > become > actually usable on all platforms in the early 2000s. Okay, that shouldn't be an real argument, when we're talking about refactoring anyways ;-) >

Re: LibreOffice / openIndiana ...

2012-03-19 Thread Jonathan Adams
I'm not sure that that is really what is going on ... I changed the compile flags to include "-g" in case that helped with debugging and the error has moved ... sal@salmon190-241:~/LibreOffice/libo$ LD_LIBRARY_PATH="/home/sal/LibreOffice/libo/solver/unxsoli/lib" gdb --args /home/sal/LibreOffice/li

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Lionel Elie Mamane changed: What|Removed |Added Depends on||47370 --- Comment #241 from Lionel

Re: [PATCH] [REVIEW:3-5] fdo#46843 graphical query editor loses sorting order

2012-03-19 Thread Lionel Elie Mamane
On Mon, Mar 19, 2012 at 04:31:34PM +0100, Petr Mladek wrote: > Lionel Elie Mamane píše v Čt 15. 03. 2012 v 18:53 +0100: >> Attached patch fixes fdo#46843, namely that the graphical query editor >> loses the query's sorting order. (most annoying, severity critical) >> Culprit: >> commit 33b9b857e

Re: About Strings

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 04:15 PM, Noel Grandin wrote: Wouldn't need to be perfect, ...but *would* need to take care to not overflow sal_Int32's positive range (which is the source of potential complication here). Stephan ___ LibreOffice mailing list LibreOff

Re: [PUSHED 3-5]: don't loose data on disk failure (fsync) fdo#40607

2012-03-19 Thread Stephan Bergmann
On 03/12/2012 04:06 PM, Michael Meeks wrote: I attach a unified patch: fdo#40607 - osl_syncFile having written, and avoid doing that on start pushed (with minor OUString ctor fix) as

Re: [PATCH] [REVIEW:3-5] fdo#46843 graphical query editor loses sorting order

2012-03-19 Thread Petr Mladek
Lionel Elie Mamane píše v Čt 15. 03. 2012 v 18:53 +0100: > Attached patch fixes fdo#46843, namely that the graphical query editor > loses the query's sorting order. (most annoying, severity critical) > > Culprit: > > commit 33b9b857ea6cb5a6f731de68f58e532242c43d30 > Author: Ocke Janssen [oj] > D

Re: About Strings

2012-03-19 Thread Noel Grandin
On Mon, Mar 19, 2012 at 16:05, Michael Stahl wrote: > hmm... what i'd really like from a string class is that it has no > operator[] at all (who needs that anyway), just an iterator interface > that returns characters as uint32_t, and another interface to write the > string UTF-8 encoded into some

Re: About Strings

2012-03-19 Thread Noel Grandin
On Mon, Mar 19, 2012 at 14:46, Stephan Bergmann wrote: > On 03/19/2012 07:30 AM, Noel Grandin wrote: >> Might make a good EasyHack to go through the code and change the places >> that allocate OUStringBuffer to give them a reasonable initial size? > > > around, it is often not easy to write an exp

Re: Question about less-than and greater-than in Arabic

2012-03-19 Thread Khaled Hosny
Hi Kendy, On Mon, Mar 19, 2012 at 09:51:24AM +0100, Jan Holesovsky wrote: > Hi Khaled, > > I've got the following report: > > - 8< - > The Arabic keyboard layout in X11 has the less-than sign (<) on the same > position as the left curly bracket ({) in the English keyboard layout. > Same

[PUSHED] Add junit check fix to 3.5 branch

2012-03-19 Thread Bjoern Michaelsen
On Sun, Mar 18, 2012 at 12:39:04PM +0100, Tomáš Chvátal wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=86793aeed94d839251e1b1098d4c8389ab7a72ae looking good, pushed. Please verify as the cherry-pick needed a manual merge: http://cgit.freedesktop.org/libreoffice/core/commit/?id=

[bjoern.michael...@canonical.com: [PUSHED] Add junit check fix to 3.5 branch] (3rd try)

2012-03-19 Thread Bjoern Michaelsen
- Forwarded message from Bjoern Michaelsen - Date: Sun, 18 Mar 2012 13:16:48 +0100 From: Bjoern Michaelsen To: libreoffice@lists.freedesktop.org Subject: [PUSHED] Add junit check fix to 3.5 branch User-Agent: Mutt/1.5.21 (2010-09-15) On Sun, Mar 18, 2012 at 12:39:04PM +0100, Tomáš Chvá

[bjoern.michael...@canonical.com: [PUSHED] Add junit check fix to 3.5 branch]

2012-03-19 Thread Bjoern Michaelsen
List eating mails? - Forwarded message from Bjoern Michaelsen - Date: Sun, 18 Mar 2012 13:16:48 +0100 From: Bjoern Michaelsen To: libreoffice@lists.freedesktop.org Subject: [PUSHED] Add junit check fix to 3.5 branch User-Agent: Mutt/1.5.21 (2010-09-15) On Sun, Mar 18, 2012 at 12:39:04P

Re: About Strings

2012-03-19 Thread Michael Stahl
On 19/03/12 09:50, Enrico Weigelt wrote: > Hi folks, > > > I just went into this list and wonder why lo has its own string > implementation instead of using std::string. Could anyone > please give me some insight ? the historical reason is that std::string is part of the C++ standard library, an

Re: [REVIEW][3-5] fix STL assertion in vcl graphite code

2012-03-19 Thread Petr Mladek
Petr Mladek píše v Út 06. 03. 2012 v 12:23 +0100: > Michael Stahl píše v St 29. 02. 2012 v 23:08 +0100: > > this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; > > since i don't know how the multitude of arrays in there are supposed to > > be used, i thought it's probably a good i

Re: Bug 37531 - Libreoffice will not run in "batch mode" when there is another instance open (patch)

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 01:38 PM, Jason Tang wrote: Regarding Bug 37531 (https://bugs.freedesktop.org/show_bug.cgi?id=37531), here is a patch that will append the current PID to the IPC pipe and allow multiple instances of LO to run. In particular, this facilitates batch file conversions from the CLI whil

Re: [ANN] LibreOffice 3.5.1 RC2 available

2012-03-19 Thread Petr Mladek
ape píše v St 14. 03. 2012 v 05:36 -0700: > My English and Google Translate does not give me a chance to explain the > cause of the error in a single message - LibreOffice can not create all > descriptions (folder) for all OLE objects. I suggest to use simple and short sentences. > But I found a

Re: About Strings

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, Stephan Bergmann wrote: > On 03/19/2012 07:27 AM, Lubos Lunak wrote: > > Or, actually, seeing that _rtl_uString is marked as internal by the > > doxygen doc, it looks like it might be doable even now. Something to add > > to my TODO list for making the string classes a

Re: About Strings

2012-03-19 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Lubos, all... Em 19-03-2012 03:27, Lubos Lunak escreveu: > First of all, what code would need such additions to OUStringBuffer? The two > classes are modeled after Java's strings, where the idea is that the normal > string is ... well, the normal

Re: LibreOffice / openIndiana ...

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, Jonathan Adams wrote: > thanks, direct pull from git behaves "correctly" to the same point. > > gdb of core gives this error: > Core was generated by > `/home/sal/LibreOffice/libo/solver/unxsoli/bin/saxparser af_NA > /home/sal/LibreOf'. > Program terminated with signal 1

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 01:55 PM, Tor Lillqvist wrote: (And why do we have libxml2.dll both in "program" and "URE/bin"?) Stephan _

Re: About Strings

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 07:27 AM, Lubos Lunak wrote: First of all, what code would need such additions to OUStringBuffer? The two classes are modeled after Java's strings, where the idea is that the normal string is ... well, the normal string, and the buffer string is for creating new strings. Therefore

Re: About Strings

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, Tor Lillqvist wrote: > > insight ? > > History? Possibly, if history of std::string is meant. (Bonus points to whoever can write the equivalent of str.replaceAll( "foo", "bar" ) with std::string from the top of the head. Extra extra bonus points if the code fits to

Android UI progress

2012-03-19 Thread Jonathan Aquilina
Hey all I have started working on the UI for the android port, I was wondering are we going to have some sort of launcher that will allow the user to choose what type of document they would like to create? Regards Jonath

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Tor Lillqvist
> Running it under Dependency Walker's profiling, it seems to say that > libxml2.dll is missing a manifest, or has a broken manifest. Sigh... OK, so if I manually copy also the libxml2.dll.manifest that gets built to the "program" folder, it proceeds a bit further, I see the splash window with pro

Re: About Strings

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, Noel Grandin wrote: > On 2012-03-19 08:27, Lubos Lunak wrote: > > That said, I myself dislike the buffer class. I doubt its > > preallocation is a significant requirement for good performance > > (especially given it's only 16 characters). I > > Even in Java, it's a code

Re: About Strings

2012-03-19 Thread Tor Lillqvist
> insight ? History? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fdo#42982, Working on the UNO RuntimeExceptions.

2012-03-19 Thread Albert Thuswaldner
Hi Abeer, I'm thuswa, the guy how couldn't help you yesterday. ;) While looking at the diff you posted on pastbin, I've noticed that the lines are chopped in your first part. Actually, this means that the interesting bits are not shown... Could you please post the diff (possible redo it to includ

Re: About Strings

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 07:30 AM, Noel Grandin wrote: Even in Java, it's a code smell to allocate a StringBuffer object without specifying a pre-allocation size. Is it? Might make a good EasyHack to go through the code and change the places that allocate OUStringBuffer to give them a reasonable initial

Re: [PATCH] [PUSHED] Windows lcms2 library import fix

2012-03-19 Thread Jan Holesovsky
Hi Lubos, On 2012-03-19 at 13:34 +0100, Lubos Lunak wrote: > Is this when building lcms2? That one has CMS_DLL_BUILD defined, so the > patch > shouldn't change anything there. Hmm, except that this CMS_DLL_BUILD defining > is done in MSVC project file, so I assume that's not used for gcc buil

Re: About Strings

2012-03-19 Thread Enrico Weigelt
Hi folks, I just went into this list and wonder why lo has its own string implementation instead of using std::string. Could anyone please give me some insight ? cu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskto

Bug 37531 - Libreoffice will not run in "batch mode" when there is another instance open (patch)

2012-03-19 Thread Jason Tang
Greetings, Regarding Bug 37531 (https://bugs.freedesktop.org/show_bug.cgi?id=37531), here is a patch that will append the current PID to the IPC pipe and allow multiple instances of LO to run. In particular, this facilitates batch file conversions from the CLI while a GUI instance is running. Ba

Re: development summary: year 2012, week 10

2012-03-19 Thread Petr Mladek
Cor Nouws píše v Po 19. 03. 2012 v 10:14 +0100: > Bjoern Michaelsen wrote (15-03-12 19:35) > > > I understand these mails were kind of useful when we still had a multi > > repository setup, but since onegit, I have the creeping suspicion they do > > not > > provide much added value. Since the dev

Re: [PATCH] [PUSHED] Windows lcms2 library import fix

2012-03-19 Thread Lubos Lunak
On Monday 19 of March 2012, Stephan Bergmann wrote: > On 03/19/2012 08:58 AM, Tor Lillqvist wrote: > > Pushed your patch, with a clarification of the comment. > > This at least breaks my local MinGW build in lcms2: > > /bin/sh ../libtool --tag=CC --mode=link i686-w64-mingw32-gcc -std=gnu99 > > -

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Tor Lillqvist
> Unfortunately the installed LO doesn't run, though;) Running it under Dependency Walker's profiling, it seems to say that libxml2.dll is missing a manifest, or has a broken manifest. Sigh... --tml ___ LibreOffice mailing list LibreOffice@lists.freedes

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Tor Lillqvist
> But if I bypass that I almost get a successful build of master, too. Once I fixed my instsetoo_native problem I got an installer! That even installs! Unfortunately the installed LO doesn't run, though;) I just get a weird Windows box referring error number 0xc0150002. (I installed it in a non-E

Re: development summary: year 2012, week 10

2012-03-19 Thread Cor Nouws
Bjoern Michaelsen wrote (15-03-12 19:35) I understand these mails were kind of useful when we still had a multi repository setup, but since onegit, I have the creeping suspicion they do not provide much added value. Since the dev-list is already very high volume, I propose to stop sending them a

Re: build error

2012-03-19 Thread Michael Stahl
On 19/03/12 11:29, Stephan Bergmann wrote: (also needed was > a clean rebuild of module unoil, IIRC). should no longer be necessary as i've added the missing dependencies there. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lis

Re: Seeking advice on vcl sizing

2012-03-19 Thread Michael Meeks
Hi Andrew, On Sun, 2012-03-18 at 16:13 +, Andrew Higginson wrote: > I need some advice with sizing of controls and windows on vcl :-) > So for the about dialog, currently I am setting its size based on the > width of the user's screen (e.g. 1/3 of the screen) ok - could be a

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||40958 --- Comment #240 from Rainer Bi

Re: LibreOffice / openIndiana ...

2012-03-19 Thread Jonathan Adams
thanks, direct pull from git behaves "correctly" to the same point. gdb of core gives this error: Core was generated by `/home/sal/LibreOffice/libo/solver/unxsoli/bin/saxparser af_NA /home/sal/LibreOf'. Program terminated with signal 11, Segmentation fault. [New process 83473] [New process 149

Re: GSoC idea to improve LightProof

2012-03-19 Thread Коростіль Данило
If Lazlo is happy to mentor it sounds fine to me - can you create a well defined task statement / idea - which is bounded and clear ie. so we can assess whether you are 50% through 100% done etc. Then we can get that in the wiki for you. It depends on Lazlo. He as owner ought to know what's bett

Re: GSoC idea to improve LightProof

2012-03-19 Thread Michael Meeks
On Sun, 2012-03-18 at 12:30 +0100, Miklos Vajna wrote: > On Sun, Mar 18, 2012 at 01:15:01AM +0200, Коростіль Данило > wrote: > > I want to be honest. I was planed to be involved in LanguageTool > > project. Unfortunately, Google refused their application form for > > some reasons. I wasn't ready

Re: About buggy behaviour which disappear when previous LO/OOo is removed

2012-03-19 Thread Stephan Bergmann
On 03/18/2012 10:15 PM, julien2412 wrote: 1) why are there regularly problems with previous profile ? (perhaps it's normal and can be easily explained so do not see any critics here, it's just to understand and to inform people during bugs triaging) One general problem with migration was a bug

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] modify default behaviour of the format paintbrush

2012-03-19 Thread Maxime de Roucy
Hello, > Is this change based on the idea, that people who use the paintbrush are > not that much looking at styles, and thus that copying those styles > might do more harm then good for them? I was showing a modification I made to the format paintbrush in a preview patch to a co-worker who work

Re: [PUSHED:3-5] Add junit check fix to 3.5 branch

2012-03-19 Thread Petr Mladek
Tomáš Chvátal píše v Ne 18. 03. 2012 v 12:39 +0100: > Hi guys, > > Please see commit [1] for merging to 3.5 branch, it needs hand update for > s/$GREP/grep/ there. It has already been pushed by Sweetshark, see http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=eb1400e33049

Re: Cppcheck reports "Logical conjunction always evaluates to false" in text_gfx.cxx

2012-03-19 Thread Stephan Bergmann
On 03/18/2012 02:39 PM, julien2412 wrote: Cppcheck reports this : [generic/print/text_gfx.cxx:105]: (warning) Logical conjunction always Would be helpful if you gave the complete path, vcl/generic/print/text_gfx.cxx. evaluates to false: nChar< 65380&& nChar>= 65387 Here are the lines :

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Michael Meeks
On Mon, 2012-03-19 at 11:56 +0200, Tor Lillqvist wrote: > > Windows can get itself into a seriously twisted state without much > > trying AFAICS. > > I haven't noticed that. I have noticed Cygwin getting itself into such > a state regularly, though. Fair enough - I was thinking of locked

Re: Working on the UNO RuntimeExceptions. (easyhack fdo#42982)

2012-03-19 Thread Stephan Bergmann
On 03/18/2012 01:05 PM, julien2412 wrote: I don't know if it's ok or not but just 2 slight remarks : 1) You should quote the easyhack (here fdo#42982, https://bugs.freedesktop.org/show_bug.cgi?id=42982) Answered the OP question there now. Stephan ___

[PUSHED-3-5] fdo#37593 Make sure needsUpdate compares canonicalized paths

2012-03-19 Thread Michael Meeks
On Fri, 2012-03-16 at 15:33 +0100, Stephan Bergmann wrote: > Please consider the below fix for > "'File > New > > Template' no longer remembers my last open folder" for inclusion in > libreoffice-3-5. Pushed to -3-5 :-) thanks.

RE: build error

2012-03-19 Thread Winfried Donkers
> From: Stephan Bergmann [mailto:sberg...@redhat.com] > Yes, clean rebuild of module shell should suffice here (also needed was > a clean rebuild of module unoil, IIRC). Thanks a lot (Lubos and Matus as well!), I will reattempt as soon as I have an opportunity. I did make clean, but that apparent

Re: GSoC idea to improve LightProof

2012-03-19 Thread Коростіль Данило
If the topic is LightProof, best to put Laszlo to CC. :) Yeah. Thank you! :) Nevertheless he hasn't appeared yet. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: build error

2012-03-19 Thread Stephan Bergmann
On 03/17/2012 05:21 PM, Matúš Kukan wrote: On 17 March 2012 17:07, Winfried Donkers wrote: It seems that the patch provided by Stephan Bergmann on 16 March (Introduced SystemShellExecuteFlags::URIS_ONLY, revision d4b67611c421ebe9b75284106fe389b434419961 ) introduced a build error: core/shell

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45081 -- Configure bugmail: https://bugs.

Re: pointer to code

2012-03-19 Thread Michael Meeks
Hi there, On Mon, 2012-03-19 at 02:08 +0530, M.Sharan Kumar wrote: > i came across bug reporting.. and i am new to it.. its said that we > need to have a pointer to code in our description.. what does that > mean?? Oh ! :-) well, if you knew where in the code the bug was - then it'd be ea

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Tor Lillqvist
> My first successfully finished Windows/MSVC build, For me the CppunitTest_extensions_test_update in extensions fails mysteriously. But if I bypass that I almost get a successful build of master, too. (For the first time in quite many weeks.) Just some problem in the installer building it seems..

[PATCH] Missing sub-menu arrows with 3.5.x and GTK < 2.15

2012-03-19 Thread Michael Meeks
Hi David, On Sun, 2012-03-18 at 22:08 -0400, David Bolen wrote: > Using LO 3.5.x on a system with GTK < 2.15.0 loses all the sub-menu > icons, because there is no menu item arrow-scaling property until > then, so the code introduced in commit 948c14ee appears to scale the > arrows to 0%.

REMINDER: Release 3.5.2-rc1 from libreoffice-3-5 branch

2012-03-19 Thread Petr Mladek
Hi, please note that the commit deadline for 3.5.2-rc1 is today, March 19, 2012. The tag and branch libreoffice-3-5-2 is going to be created the day after. Only commits with 3 reviewers will be allowed for that branch. See also http://wiki.documentfoundation.org/ReleasePlan#3.5_release http://wi

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Tor Lillqvist
> Windows can get itself into a seriously twisted state without much > trying AFAICS. I haven't noticed that. I have noticed Cygwin getting itself into such a state regularly, though. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: Build failure on Windows/MSVC because of embedserv

2012-03-19 Thread Michael Meeks
On Mon, 2012-03-19 at 07:33 +0100, Lubos Lunak wrote: > Yes, that works, thanks. My first successfully finished Windows/MSVC build, > now where's the champagne :) ? Oooh ! :-) nice work :-) the more Windows build-ers the better. > Oh, I see. I've already noticed this myself, and that'

Re: [PATCH] [PUSHED] Windows lcms2 library import fix

2012-03-19 Thread Tor Lillqvist
So should the CMS_DLL thing in the patch be done just for MSVC then? Or would it be cleaner to just patch out the use of stdcall completely instead? We don't promise that our build of the lsmc2 dll would be binary compatible with anybody else's build of it, do we? (Which is why we should use a more

[PATCH] convert tools/table.hxx usage in sc/filters

2012-03-19 Thread Noel Grandin
Hi Two patches, one for sc/filters/html and one for sc/filters/rtf License is on file. I think I'm about 3 patches away from finishing off tools/table.hxx. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0002-Convert-tools-table.hxx-to-std-map-in-class-ScHTMLLa.p

Re: [PATCH] [PUSHED] Windows lcms2 library import fix

2012-03-19 Thread Stephan Bergmann
On 03/19/2012 08:58 AM, Tor Lillqvist wrote: Pushed your patch, with a clarification of the comment. This at least breaks my local MinGW build in lcms2: /bin/sh ../libtool --tag=CC --mode=link i686-w64-mingw32-gcc -std=gnu99 -g -O2 -no-undefined -version-info 2:3:0 -o liblcms2.la -rpath

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||40421 --- Comment #239 from Rainer Bi

Re: [PUSHED][3-5] Re: fdo#46926 needs another fix

2012-03-19 Thread Miklos Vajna
On Fri, Mar 16, 2012 at 11:23:58PM +0100, Michael Stahl wrote: > David found another problem, the rich comparison function also crashes. > > i've committed David's fix on master, please apply to libreoffice-3-5: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=742dca7366ba6ac3c58b1df

[REVIEW] 3 RTF import fixes

2012-03-19 Thread Miklos Vajna
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=44f7c5ddf9d730c899f480ca644ddc29c7de9dc6 Testcase for this: sw/qa/extras/rtftok/data/fdo46662.rtf http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb34b73730a3109bdcae0a03137c1faffab610d5 http://cgit.freedesktop.org/libreoffice/c

Re: [PATCH] [PUSHED] Windows lcms2 library import fix

2012-03-19 Thread Tor Lillqvist
> there is a link error in writerperfect's cdrimport, caused by libcdr/lcms2 > libraries. So as far as I understand it, on Windows a library uses dllexport > when it is being built and dllimport when something else is built against it. Actually, when importing, the dllimport attribute is optional

Re: [REVIEW-3-5] [CHERRY-PICKED-3-5] fix for fdo#40426, import all properties into ScDBData

2012-03-19 Thread Tor Lillqvist
> This patch is simple and safe and I think we can included it into 3-5. Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice