Re: [PATCH] [PUSHED] correction of faulty comment

2012-03-16 Thread Kohei Yoshida
On Fri, 2012-03-16 at 18:15 +0100, Winfried Donkers wrote: > Attached very simple patch, the comment preceding class definition mentions > wrong class. > No effect on compiling/running at all, but a bit annoying when opengrokking > for Svx...ToolBoxControls ;) Simple enough. Pushed. Kohei --

Re: Patchtool

2012-03-16 Thread Bjoern Michaelsen
On Fri, Mar 16, 2012 at 06:47:56PM -0500, Norbert Thiebaud wrote: > On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich > wrote: > > Hi everyone, > > > > > > I would like to add a feature where it downloads patches and does a > > "git apply --check", and will flag patches which are "clean" (against

Re: Patchtool

2012-03-16 Thread Norbert Thiebaud
On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich wrote: > Hi everyone, > > > I would like to add a feature where it downloads patches and does a > "git apply --check", and will flag patches which are "clean" (against > master). And I would like to go further and apply and push these patch to ger

Re: Patchtool

2012-03-16 Thread Norbert Thiebaud
On Fri, Mar 16, 2012 at 6:33 PM, Josh Heidenreich wrote: > Hi everyone, > > For the last few days I have been working on a tool I call "patchtool". > > Check it out here: > http://thejosh.info/libreoffice/patchtool/ very cool... Do you have the source somewhere public ? I've had on my to-do lis

Patchtool

2012-03-16 Thread Josh Heidenreich
Hi everyone, For the last few days I have been working on a tool I call "patchtool". Check it out here: http://thejosh.info/libreoffice/patchtool/ It scrapes the mailing-list archives, looking for messages with a subject of [PATCH] or [PUSHED]. Those messages go into a database, and get threaded

Re: LibreOffice / openIndiana ...

2012-03-16 Thread Michael Stahl
On 05/03/12 16:03, Jonathan Adams wrote: > Still a work in progress ... and a couple of "when it stops at this > point run this command" kinda hacks. > > diff patch is attached, you'll just have to see how far you can get with it.. hi Jonathan, i've pushed a lot of this to master now, i.e. this

[REVIEW][3-5] fdo#42750 sw: thin table borders hidden by subsidiary lines

2012-03-16 Thread Michael Stahl
in Writer, the subsidiary lines for tables are drawn on top of the border lines, hiding them completely if they are very thin. this is a regression in LO 3.4: in commit 0f0896c26fb260d1bbf31d7a886df3f61837f0f2 the drawing of the borders was changed completely and they are now drawn immediately, wh

[REVIEW][3-5] Re: fdo#46926 needs another fix

2012-03-16 Thread Michael Stahl
On 13/03/12 10:31, Petr Mladek wrote: > Caolán McNamara píše v Po 12. 03. 2012 v 13:50 +: >> On Fri, 2012-03-09 at 15:48 +0100, Michael Stahl wrote: >>> On 07/03/12 11:37, Michael Stahl wrote: >>> PS: please somebody review the above 2 commits and backport to libreoffice-3-5. >>> >>>

[REVIEW-3-5] revert fdo#33090 to fix fdo#46750 memory corrupter

2012-03-16 Thread Michael Meeks
So, I'd prefer to live with fdo#33090 (a Thai text rendering issue) than have the subtle memory corruption in fdo#46750 - so I suggest that we revert: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e601c32661735e9fd78def7ee11bfe21279cca71 in libreoffice-3-5 for Monday -

Re: [REVIEW 3-5] fdo#46809 incomplete formula in formulabar

2012-03-16 Thread Kohei Yoshida
On Fri, 2012-03-16 at 08:37 -0600, Noel Power wrote: > please see > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b1592165d0513e90e28dfee92bc9db032fa221 Yes. We already discussed this & did a thorough test yesterday on IRC. I confirm that this change resolves the out-of-sync range in

Re: [REVIEWED][PUSHED 3-5] fix for fdo#47393, unable to cancel html paste

2012-03-16 Thread Kohei Yoshida
On Fri, 2012-03-16 at 10:56 +0100, Markus Mohrhard wrote: > Hey, > > [1] fixes the issue that we are unable to cancel the html paste dialog > and paste the content even after pressing the cancel button. > > This patch is extremely safe and I think we can easily add it to 3-5. Confirmed that the

Re: EasyHack proposition - Crop image functionality improvement (fdo#34555)

2012-03-16 Thread Tommy
On Fri, 16 Mar 2012 16:44:04 +0100, khagaroth wrote: Can some developer please look at https://bugs.freedesktop.org/show_bug.cgi?id=34555 and check if it's suitable to be filled as an EasyHack (and fill it if it is)? The current crop functionality in Writer and Calc is really ridiculously bad a

[PUSHED-3-5] remove un-necessary oox linkage ...

2012-03-16 Thread Michael Meeks
Lubos just did a nice fix in master to not link oox into libswlo when we don't need it; it's a one-liner This is me signing it off for -3-5 I guess ;-) HTH, Michael. diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk index 2b0bce3..4d5cdd6 100644 --- a/sw/

Re: [REVIEWED][PUSHED 3-5] fix for fdo#47285, sorting cells with relative refs may invalidate some

2012-03-16 Thread Kohei Yoshida
On Fri, 2012-03-16 at 10:53 +0100, Markus Mohrhard wrote: > Hey, > > [1] fixes a problem when you sort cells with relative refs. The update > for absolute refs needs the information about the original referenced > cell and therefore the relative references should be updated after the > absolute on

[PATCH] Remove unused code

2012-03-16 Thread Santiago Martinez
This patch removes unused code as listed in unusedcode.easy From e2ce9edf1b94bff6443257b875fa13255ac71e81 Mon Sep 17 00:00:00 2001 From: Santiago Martinez Date: Fri, 16 Mar 2012 20:12:53 +0100 Subject: [PATCH] Remove unused code as listed in unusedcode.easy --- .../source/drivers/evoab2/NDatabas

Re: Can't compile from source, i18npool project segfaults with parallel build

2012-03-16 Thread uh.li...@gmail.com
16.03.2012 13:44, Thorsten Behrens пишет: uh.li...@gmail.com wrote: I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always failed with i18npool project. I'm using parallel build. Same build script compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC 4.5.

[ANN] LibreOffice 3.4.6 RC2 available

2012-03-16 Thread Thorsten Behrens
Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.4.6. The upcoming 3.4.6 will be the sixth in a series of frequent bugfix releases for our 3.4 code line. Please be aware that LibreOffice 3.4.6 RC2 is not yet ready for production use, you sh

LibreOffice was accepted for Google Summer of Code 2012

2012-03-16 Thread Fridrich Strba
The title tells it all. And may the applications start to fall like a refreshing rain. For all interested students, accomplished Easy Hacks are a must for being eligible and being involved already with the community is a big plus. That is it for now ;) Have a nice weekend Fridrich

Re: [REVIEWED] [PUSHED 3-5] fix for fdo#47307, crash in Insert names dialog

2012-03-16 Thread Kohei Yoshida
On Fri, 2012-03-16 at 00:30 +0100, Markus Mohrhard wrote: > Hey, > > [1] prevents a crash in the insert names dialog. ScRangeManagerTable > expects a reference to the range names and therefore using the > temporary object in the insert names dialog is wrong. > > This fix is simple and I think we

License statement

2012-03-16 Thread Rob Snelders
Hi, All my contributions, past and future, to LibreOffice are licensed under the terms of the MPL / LGPLv3+. Greetings, Rob Snelders ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoff

Re: [OBSOLETE][PATCH] convert tools/table.hxx usage to std::map in ICGM filter in CGMElements class

2012-03-16 Thread Ivan Timofeev
Hi Noel, This is already done in your commit 64cba6e58263e906aba6a110937f362d1e31ebe5 but in a different way though. Cheers, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW-3-5] Fix fdo#45219 wrong transparency for animated objects.

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c7e061997202df9e602e209cf40c61606582e8e fixes the most obvious glitch in fdo#45219 - multiple paints of the same sprite on top of each other, killing the hue for transparent objects. (std::unique in this case _needs_ to elimin

Re: LibreOffice / go-oo license ...

2012-03-16 Thread Thomas Klausner
As Michael requested: "All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code." If you want to use a different open source license, that's probably fine with me as well, just drop me a line to con

[PATCH] correction of faulty comment

2012-03-16 Thread Winfried Donkers
Attached very simple patch, the comment preceding class definition mentions wrong class. No effect on compiling/running at all, but a bit annoying when opengrokking for Svx...ToolBoxControls ;) WinfriedFrom 0f41a91d2529b58b0135d20a2cc139dad87626b2 Mon Sep 17 00:00:00 2001 From: Winfried Donkers

[REVIEW-3-5] Remove nasty xor hack for non-Mac vclcanvas

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d82d741c37d1b77f5687b1bdc48a37fb9f29f removes one more XOR-hack to avoid clipping a polygon on win32/X11 - I would expect this optimization to rather be a pessimization nowadays, it at least runs nicely here on Xorg now. Che

[REVIEW-3-5] Clear whole layer in slideshow sprites fdo#45219

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=d32cf8d820be839c7303e3c5962c17f64cac2812 fixes the "ugly dark rectangle in part of the shape" subset of fdo#45219 - because the clearing rectangle was errorneously offset by the topleft corner of the sprite - it should rather st

[REVIEW-3-5] Clear sprites to white fdo#45219.

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=b9266113514657be1cf9352e1457a5c62876784c uses transparent-white to clear the update area in an animated layer during slideshow. This is an especially ugly fix, since it's exposing the vclcanvas 1bpp-no-true-compositing shortcomi

[REVIEW-3-5] Clear full sprite area for fdo#45219

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=e86bcf11340f35afe899d02aa5facdbecdd309ab ensures that, regardless of any potential clip setup, always the whole animation sprite gets cleared. Layer::clearContent() is used under that assumption. Cheers, -- Thorsten pgpCyN5K

[REVIEW-3-5] Use transparency for gradients fdo#45219

2012-03-16 Thread Thorsten Behrens
Hi there, previously, vclcanvas simply ignored transparency settings for gradient fills. http://cgit.freedesktop.org/libreoffice/core/commit/?id=3f5efa1e76e187070d412d102e4c057679065bcc fixes this by filling the appropriate area with either black or white (note that vclcanvas has 1bpp alpha).

[REVIEW-3-5] Return proper transparency value even for ignore_color.

2012-03-16 Thread Thorsten Behrens
Hi there, found while reviewing the code - http://cgit.freedesktop.org/libreoffice/core/commit/?id=4b475f31eb9b290b477bb6992ff28e52248cee5d moves setting nTransparency out of the eColorType != IGNORE_COLOR branch, thusly ensuring that calling code gets a sensible return value even in IGNORE_C

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 brinzing changed: What|Removed |Added CC||oliver.brinz...@gmx.de --- Comment #233 from

[REVIEW-3-5] Another partial fix for fdo#45219

2012-03-16 Thread Thorsten Behrens
Hi there, http://cgit.freedesktop.org/libreoffice/core/commit/?id=50309b9574c43de93a05576904813881eb7bc898 ensures that the pseudo-alphachannel of the vclcanvas gets the right content for transparent polygons - since this alphachannel is a 1bpp mask, we either make it fully transparent, or fully

LibreOffice / go-oo license ...

2012-03-16 Thread Hanno Meyer-Thurow
Hi there! JFYI, all of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. Hanno ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists

[REVIEW-3-5] Consistent use of alpha in cairocanvas

2012-03-16 Thread Thorsten Behrens
Hi there, the cairocanvas was slightly inconsistent in it's use of the alpha channel, when copying from a vcl bitmap. Cosmetic change to use GetIndex() instead of GetBlue() (same component), and use 255 aka opaque if no alpha bitmap access available. Cherry-pick into -3-5 appreciated. http://cg

relicensing agreement

2012-03-16 Thread Arkadiusz Miśkiewicz
Hi, In the spirit of relicensing effort I'm stating that: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. My submissions were using one of these emails: ar...@pld-linux.org ar...@maven.pl -- Arkadiusz Miśkiewicz

Re: minutes of ESC call 2012-03-15 1500 UTC

2012-03-16 Thread Eike Rathke
Hi, On Friday, 2012-03-16 12:39:32 +, Michael Meeks wrote: > On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: > > AA: + announce very loudly if the call changes slot in UTC timezone > > (Michael) > > So - it's a good time to think about a new time. > > >

[PUSHED] Re: [REVIEW 3-5] fdo#46832 fix uno bootstrapping

2012-03-16 Thread Michael Stahl
On 08/03/12 17:14, Noel Power wrote: > external .NET ( and possibly c++ ) client(s) are failing on 3.5. This is > due to missing embedded manifest info in dll(s) built with gbuild > resulting in failure to properly load VC90 runtime. Please see > http://cgit.freedesktop.org/libreoffice/core/comm

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45219, which changed state. Bug 45219 Summary: SLIDESHOW: Transparency gradient effect fade in with wrong VIEWING https://bugs.freedesktop.org/show_bug.cgi?id=45219 What|Old Value |New V

EasyHack proposition - Crop image functionality improvement (fdo#34555)

2012-03-16 Thread khagaroth
Can some developer please look at https://bugs.freedesktop.org/show_bug.cgi?id=34555 and check if it's suitable to be filled as an EasyHack (and fill it if it is)? The current crop functionality in Writer and Calc is really ridiculously bad and source of many user complaints. All the needed functio

Re: [REVIEW: 3-5, 3-4][CANCELLED] fdo#43932 setting paper tray from print dialog

2012-03-16 Thread Cor Nouws
Hi David, David Tardon wrote (15-03-12 14:14) I am too, apparently. I am hereby cancelling this request pending further investigation. I know there are some bugs around paper settings and printing. If you didn't yet see them, I might try to see (next week) if there is some pattern in them. M

Re: [Libreoffice-ux-advise] [Libreoffice] [PATCH] modify default behaviour of the format paintbrush

2012-03-16 Thread Cor Nouws
Hi Maxime, Maxime de Roucy wrote (14-03-12 18:38) Two new patchs that modify the default behaviour of the format paintbrush. 0001-Format-paintbrush-default-behaviour.patch To apply to the core repository. 0001-Change-format-paintbrush.patch To apply to the help repository. By default the pai

Re: [GBUILD] Can we get rid of gbuild_simple ?

2012-03-16 Thread Tor Lillqvist
> And that made me wonder what > gbuild_simple.mk is actually necessary for, if anything. Hear, hear. Having a separate gbuild_simple.mk makes things more complicated, not simpler. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org htt

Re: [libreoffice-website] Re: Promoting RCs on Facebook

2012-03-16 Thread drew jensen
On Fri, 2012-03-16 at 15:34 +0100, Volker Merschmann wrote: > Hi Cor, > > 2012/3/16 Cor Nouws : > > Volker Merschmann wrote (07-03-12 13:59) > >> In the meantime I have found the names of the maintainers: Gerard > >> Jensen, Don Crowley, Nikola Yanev > >> I do not know any of them and they are not

Re: [PUSHED-3-5] fdo#31551 - lines in legend not shown with current width ...

2012-03-16 Thread Thorsten Behrens
Michael Meeks wrote: > It seems (on the face of it) reasonably simple; does it make sense to > have it in 3.5.2 (rc1 deadline is Monday IIRC) :-) > Yes, it does - cherry-picked into -3-5. -- Thorsten pgp1Xk5QwBrtl.pgp Description: PGP signature

Re: [GBUILD] Can we get rid of gbuild_simple ?

2012-03-16 Thread Stephan Bergmann
On 03/16/2012 03:47 PM, Matúš Kukan wrote: 3, No need to maintain gbuild_simple. FWIW, in "Enable -Wnon-virtual-dtor for GCC 4.6" I switched some CustomTarget Makefiles from including gbuild_si

[GBUILD] Can we get rid of gbuild_simple ?

2012-03-16 Thread Matúš Kukan
Hi, I'd like to propose removing gbuild_simple.mk over time. Surely there will be more custom targets as gbuild is growing and I can't see why we would need gbuild_simple. Instead we can write rules to Package_foo.mk makefiles or if that would be problem (because they will be ugly) We can start us

Re: LO Calc AddOn ~ Web Services ~ Java Frame

2012-03-16 Thread Cor Nouws
Hi Nick, libreoffice...@gmail.com wrote (12-03-12 10:45) Dear Admin & Developers, (I'm neither of them - just handling some mail with some delay ) Questions: 1. Any chance to do it using LO frame instead of Java ? If yes than will it work faster with LO frames (based on your exper

[REVIEW 3-5] fdo#46809 incomplete formula in formulabar

2012-03-16 Thread Noel Power
please see http://cgit.freedesktop.org/libreoffice/core/commit/?id=e3b1592165d0513e90e28dfee92bc9db032fa221 this is mucho safe imo Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreo

Re: [Libreoffice] [REVIEW] Patch for importing hyperliks from .doc files

2012-03-16 Thread Michael Meeks
Hi there, On Tue, 2011-09-27 at 16:03 +0200, Knut Olav Bøhmer wrote: > Here is the LibreOffice bug report: > https://bugs.freedesktop.org/show_bug.cgi?id=41255 ... > I did not check if the patch was applied in latest LibreOffice git > repository. If it is, I can just close the bug. It isn

Re: Promoting RCs on Facebook

2012-03-16 Thread Volker Merschmann
Hi Cor, 2012/3/16 Cor Nouws : > Volker Merschmann wrote (07-03-12 13:59) >> In the meantime I have found the names of the maintainers: Gerard >> Jensen, Don Crowley, Nikola Yanev >> I do not know any of them and they are not linked from the FB-page. >> >> Can anybody help? > > > Don't know them ei

[REVIEW-3-5] fdo#37593 Make sure needsUpdate compares canonicalized paths

2012-03-16 Thread Stephan Bergmann
Please consider the below fix for "'File > New > Template' no longer remembers my last open folder" for inclusion in libreoffice-3-5. Stephan On 03/16/2012 03:03 PM, Stephan Bergmann wrote: commit 32a5ad89a505be22fb8ca0b990a8991a7de6453a A

Re: Promoting RCs on Facebook

2012-03-16 Thread Cor Nouws
Volker Merschmann wrote (07-03-12 13:59) In the meantime I have found the names of the maintainers: Gerard Jensen, Don Crowley, Nikola Yanev I do not know any of them and they are not linked from the FB-page. Can anybody help? Don't know them either. But am willing to post a polite message, if

heads up excel filter bits moved to sc

2012-03-16 Thread Noel Power
I moved on-masse all the excel related ooxml import filter stuff from oox to sc ( scfilt to be precise ). This will allow us now to access core functionality on import rather than depending solely on UNO. I managed to get a full build on linux, and partial ( but a least up to sc ) for mingw & wind

Re: [Libreoffice-ux-advise] [LibreOffice] find ctrl-g/ctrl-shift-g accelerator patch

2012-03-16 Thread Cor Nouws
Hi Cameron, Kendy, *, Jan Holesovsky wrote (06-03-12 11:20) This is some good research, I hope you don't mind if I CC: the devel mailing list, and the UX advise list too? :-) Really appreciate work on this subject! I think this is actually a good question for the UX advise list :-) My pro

[PATCH] removed unused code

2012-03-16 Thread Petr Vorel
Hi there, another unused code removed (part of oox). Regards, Petr >From 2221c91a53383024121bfa01f01055510e3642ae Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Fri, 16 Mar 2012 12:44:20 +0100 Subject: [PATCH] removed unused code --- oox/inc/oox/drawingml/textbodyproperties.hxx |1 - oo

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 clio changed: What|Removed |Added Depends on||46102 -- Configure bugmail: https://bugs.freedes

[PATCH] convert tools/table.hxx to std::map in Chart2PositionMap class

2012-03-16 Thread Noel Grandin
Hi License in on file. This patch applies on top of my cleanup patches from earlier today. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Convert-tools-table.hxx-to-std-map-in-Chart2Position.patch Description: application/mbox ___

[Fwd: [REVIEW 3-5] fdo#46832 fix uno bootstrapping]

2012-03-16 Thread Noel Power
any chance of this going into 3-5 ? --- Begin Message --- external .NET ( and possibly c++ ) client(s) are failing on 3.5. This is due to missing embedded manifest info in dll(s) built with gbuild resulting in failure to properly load VC90 runtime. Please see http://cgit.freedesktop.org/libreoff

Re: minutes of ESC call 2012-03-15 1500 UTC

2012-03-16 Thread Michael Meeks
On Thu, 2012-03-15 at 19:07 +0100, Bjoern Michaelsen wrote: > AA: + announce very loudly if the call changes slot in UTC timezone > (Michael) So - it's a good time to think about a new time. > + 17:00 local might be preferable to quite a few (Eike) > AA:

Re: Can't compile from source, i18npool project segfaults with parallel build

2012-03-16 Thread Michael Meeks
Hi there, On Fri, 2012-03-16 at 07:03 +0400, uh.li...@gmail.com wrote: > I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always > failed with i18npool project. I'm using parallel build. Same build script > compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. G

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky changed: What|Removed |Added Depends on||44628 -- Configure bugmail: https://bu

[REVIEW-3-5] fdo#31551 - lines in legend not shown with current width ...

2012-03-16 Thread Michael Meeks
Hi there, Katarina created a nice patch for this bug: https://bugs.freedesktop.org/show_bug.cgi?id=31551 which is here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd33b0d28e9f73b4911b43bedf334296b8025485 It seems (on the face of it) reasonably simple; does it

[PUSHED-3-5] fdo#46728: EDITING: soffice.bin crashed with SIGSEGV in Window::GetCursor()

2012-03-16 Thread Michael Meeks
On Tue, 2012-03-13 at 18:04 +0100, Thorsten Behrens wrote: > Caolan McNamara wrote: > > So, how about > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=131e5d35a4edb9f8875a197e8e0382c168834f70 > > Seems to fix the crash. Worthwhile for 3-5 ? > > Eh. Inspected for syntactical equivalence

Re: [REVIEW-3-5] fix for fdo#46230, shrink the copy area only in the text export

2012-03-16 Thread Markus Mohrhard
Hello Michael, > On Tue, 2012-03-13 at 01:41 +0100, Markus Mohrhard wrote: >> calc. The problem is that we should not shrink the area already in >> ScTransferObj. We should wait until we need to export the data and >> limit this to the text export. Please test it especially in the >> context of n#

[REVIEW-3-5] fix for fdo#46230, shrink the copy area only in the text export

2012-03-16 Thread Michael Meeks
Hi Markus, On Tue, 2012-03-13 at 01:41 +0100, Markus Mohrhard wrote: > calc. The problem is that we should not shrink the area already in > ScTransferObj. We should wait until we need to export the data and > limit this to the text export. Please test it especially in the > context of n#677811.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky changed: What|Removed |Added Depends on|44628 | -- Configure bugmail: https://bugs.fr

Re: [Libreoffice-qa] Regressions in Open Source projects ...

2012-03-16 Thread Michael Meeks
On Thu, 2012-03-15 at 21:22 +0100, Petr Mladek wrote: > > Actually I was talking about SUSE LibreOffice for Windows (which is > > apparently a one-off unsupported release created for the Intel AppUp > > store) :) Nah - SUSE will be maintaining that with our stable release. Though of cours

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky changed: What|Removed |Added Depends on||44628 --- Comment #232 from Jan Holesov

Re: Can't compile from source, i18npool project segfaults with parallel build

2012-03-16 Thread Norbert Thiebaud
On Fri, Mar 16, 2012 at 4:44 AM, Thorsten Behrens wrote: > uh.li...@gmail.com wrote: >> I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always >> failed with i18npool project. I'm using parallel build. Same build script >> compiles 3.4.5 and older versions. Tested with x86 and

[REVIEW] fix for fdo#47393, unable to cancel html paste

2012-03-16 Thread Markus Mohrhard
Hey, [1] fixes the issue that we are unable to cancel the html paste dialog and paste the content even after pressing the cancel button. This patch is extremely safe and I think we can easily add it to 3-5. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=bd8be4eae82

[REVIEW] fix for fdo#47285, sorting cells with relative refs may invalidate some

2012-03-16 Thread Markus Mohrhard
Hey, [1] fixes a problem when you sort cells with relative refs. The update for absolute refs needs the information about the original referenced cell and therefore the relative references should be updated after the absolute ones. The relative references don't need any information about their pos

Re: Can't compile from source, i18npool project segfaults with parallel build

2012-03-16 Thread Thorsten Behrens
uh.li...@gmail.com wrote: > I'm trying to build LibreOffce 3.5 and 3.5.1 from source, but build always > failed with i18npool project. I'm using parallel build. Same build script > compiles 3.4.5 and older versions. Tested with x86 and x86_64 machine. GCC > 4.5.2. Making with -j1 in i18npool wokks,

Re: [Libreoffice] [PATCH] format clipboard

2012-03-16 Thread Maxime de Roucy
Here a copy of the mail I send to Cedric Bosdonnat… forgot to add the list as "Cc:". Hello Thanks you for asking me… When you select a cell in Writer the selection type is a mix of nsSelectionType::SEL_TBL_CELLS, nsSelectionType::SEL_TBL and nsSelectionType::SEL_TXT. So when the lcl_CreateEmptyI

RE: [PATCH]bug 44516 improved label and business card document creation

2012-03-16 Thread Winfried Donkers
> From: Norbert Thiebaud [mailto:nthieb...@gmail.com] > Sent: vrijdag 16 maart 2012 09:44 > Is the result an applicable patch ? Yes it is, only changes are layout. (and a separate patch to make it readable again will be huge again :( ). Only thing is, to make comparing with the old (say 2011) Lab

Re: [PATCH]bug 44516 improved label and business card document creation

2012-03-16 Thread Norbert Thiebaud
On Fri, Mar 16, 2012 at 3:39 AM, Winfried Donkers wrote: >> From: Norbert Thiebaud [mailto:nthieb...@gmail.com] >> Sent: maandag 27 februari 2012 08:26 >> ... >> yes, but the mix of various changes leading to such a big patch and >> especially the removal of entry peppered in the middle of a massi

RE: [PATCH]bug 44516 improved label and business card document creation

2012-03-16 Thread Winfried Donkers
> From: Norbert Thiebaud [mailto:nthieb...@gmail.com] > Sent: maandag 27 februari 2012 08:26 > ... > yes, but the mix of various changes leading to such a big patch and > especially the removal of entry peppered in the middle of a massive > re-formating makes that, even with some diff + sed magic,

[PATCH] code cleanup in chart2uno.cxx in SC module

2012-03-16 Thread Noel Grandin
Hi License statement is on file. This series is a precursor to more tools/table.hxx removal, but I thought I'd push the code cleanup series separately to make it easier to review. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0002-restructure-insert-code-as-a