Sarah Edwards -

2012-03-13 Thread SarahEdwards
Greetings,   My name is  Sarah Edwards and I would like to forward our new Carabineer Travel Mugto the person who handles the marketing. PIease let me know what types of products have you order before with your imprint and  email your logo in PDF or EPS formatand I will email you a price quote 

[PATCH] Add Switches to find-german-comments to aid in weeding false positives

2012-03-13 Thread Tom Thorogood
Added two switches to bin/find-german-comments The first is --line-numbers (-l), which outputs a filename only once, followed by (mostly) neat formatting of the line numbers with flagged comments. The second is --threshold (t), which suppresses any output for comments that have less than [t] flagge

[PATCH] Remove unused code in drawingml

2012-03-13 Thread Mariana Marasoiu
Hi! These patches remove unused code as listed in unusedcode.easy Mariana Marasoiu From 2fa32c691f2af987bb32bff8b9b3f940c90b08aa Mon Sep 17 00:00:00 2001 From: Mariana Marasoiu Date: Wed, 14 Mar 2012 01:07:16 +0200 Subject: [PATCH 1/4] Remove unused code in drawingml. --- oox/inc/oox/drawingm

[PUSHED] Re: [PATCH] convert tools/table.hxx usage to std::map in CGMElements class in filter module

2012-03-13 Thread Michael Stahl
On 09/03/12 13:08, Noel Grandin wrote: > Hi > > License statement already on file. > > Regards, Noel Grandin thanks, pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: Prevent possible memory leak by adding virtual destructor

2012-03-13 Thread Michael Stahl
On 13/03/12 21:14, Arnaud Versini wrote: > Hi, > > This patch add a virtual destructor to all classes from > WW8ResourceModel.hxx with virtual methods to prevent memory leaks likes > rtf few days ago almost from docx import filter. thanks, pushed ___ L

[PUSHED] Re: [PATCH] Convert tools/table.hxx to std::set in toolkit module

2012-03-13 Thread Michael Stahl
On 11/03/12 12:34, Noel Grandin wrote: > Hi > > License statement is on file. > > Regards, Noel Grandin thanks, pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [PATCH] convert tools/table.hxx to std::set in SwSrcEditWindow class in sw module

2012-03-13 Thread Michael Stahl
On 11/03/12 19:51, Noel Grandin wrote: > Hi > > License is on file. > > Regards, Noel Grandin thanks, pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [PATCH] convert tools/table.hxx to std::map in DffPropSet class in filter module

2012-03-13 Thread Michael Stahl
On 09/03/12 16:23, Noel Grandin wrote: > Hi > > License statement already on file. > > Regards, Noel Grandin thanks, pushed. your patch added trailing whitespace, which probably means that your git hooks are not set up properly; please check your core/.git/hooks, there should be a live symlink

Prevent possible memory leak by adding virtual destructor

2012-03-13 Thread Arnaud Versini
Hi, This patch add a virtual destructor to all classes from WW8ResourceModel.hxx with virtual methods to prevent memory leaks likes rtf few days ago almost from docx import filter. Thanks Best regards -- Arnaud Versini From c2054880238124c6cdc9b1fe7d14e9b10721decb Mon Sep 17 00:00:00 2001 From

Re: Regular Windows debug builds

2012-03-13 Thread Thorsten Behrens
Jesús Corrius wrote: > Thanks for your attention :) > Thanks for this truly helpful service - now there's only a section for Windows missing at http://wiki.documentfoundation.org/BugReport , linking to your nice video & those debug builds. :) Cheers, -- Thorsten pgp2j9FkaAYy7.pgp Descriptio

Re: [3.5.1] build broken in KDE4FilePicker.cxx

2012-03-13 Thread Andreas Radke
Am Tue, 13 Mar 2012 16:40:19 +0100 schrieb Lubos Lunak : > No, this should be actually already handled. You probably want > 77ee92a6bd8f40022ab03325d158de4b67a41dd0 , which I think only made it > to 3-5 branch but not 3-5-1, in which case you probably want > ee67c55260ec7723c39606955ccdbd3e2934

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Arnaud Versini
I'm also on it after the RTF patch pushed sunday ( http://cgit.freedesktop.org/libreoffice/core/commit/?id=f32fe9f5012e3ee184e1a1fca6814bee9105d8fb), the patch for WW8ResourceModel.hxx will be avaible this evening. Thanks Le 13 mars 2012 15:11, Stephan Bergmann a écrit : > On 03/13/2012 03:00

[PATCH] add 'Japanese Postcard' paper size to both Paper format and Print dialog

2012-03-13 Thread Takeshi Abe
Hi, I would like to add an option for the paper size of 'Japanese Postcard' [1] to combo boxes such as Paper format and Print dialog. The attached patch against master seems sufficient for that because its actual dimension is already defined in the code base. But I think it would be controversial

[Libreoffice] Windows ; small program that inject dll in LibreOffice Quickstarter in order to improve component start time

2012-03-13 Thread Maxime de Roucy
Hello I made a small Windows (XP) program that inject dll in LibreOffice Quickstarter. It inject dll used by Writer and Calc in order to improve the first start of those tools (if they aren't start too late after the dll were injected). On some system it can improve the start time by approximatel

Re: [PATCH] fdo#46728: EDITING: soffice.bin crashed with SIGSEGV in Window::GetCursor()

2012-03-13 Thread Thorsten Behrens
Caolan McNamara wrote: > So, how about > http://cgit.freedesktop.org/libreoffice/core/commit/?id=131e5d35a4edb9f8875a197e8e0382c168834f70 > Seems to fix the crash. Worthwhile for 3-5 ? > Eh. Inspected for syntactical equivalence, but this is quite massive. Hesitant to hand-wave that in w/o further

Re: [PATCH] fdo#46728: EDITING: soffice.bin crashed with SIGSEGV in Window::GetCursor()

2012-03-13 Thread Caolán McNamara
On Mon, 2012-03-12 at 15:51 +0100, Thorsten Behrens wrote: > Caolan McNamara wrote: > > In the absence of alternative ideas, we could try and work some > > reference count stuff in there. > > > Yeah. So, how about http://cgit.freedesktop.org/libreoffice/core/commit/?id=131e5d35a4edb9f8875a197e8e

Re: String literals, ASCII vs UTF-8

2012-03-13 Thread Lubos Lunak
On Tuesday 13 of March 2012, Olivier Hallot wrote: > > Are we going to remove RTL_CONSTASCII_USTRINGPARAM from all the code? > There a 33599(*) lines in whole code... That is the plan, but I still want to give it a little more time in case somebody runs into a problem. I just massively broke th

Regular Windows debug builds

2012-03-13 Thread Jesús Corrius
Hi all, As many of you know, I produce Windows builds with debug symbols regularly. >From now on, I will upload them to: http://dev-builds.libreoffice.org/win32-debug/ Thanks for your attention :) -- Jesús Corrius ___ LibreOffice mailing list Libre

Re: [3.5.1] build broken in KDE4FilePicker.cxx

2012-03-13 Thread Lubos Lunak
On Monday 12 of March 2012, Andreas Radke wrote: > Since latest KDE update (4.8.1) I get this build error in ArchLinux: ... > Is this already known? Latest kfpicker commits seem to be only removing > other compiler warnings. No, this should be actually already handled. You probably want 77ee92a6

[ANNOUNCE] libreoffice-3.4.6.2 tag created (3.4.6-rc2)

2012-03-13 Thread Petr Mladek
Hi, there have been created the libreoffice-3.4.6.2 tag for 3.4.6-rc2 release. The corresponding official builds will be available within next few days. It will be used as final if no blocker is found. See the attached list of changes against 3.4.6-rc1. Now, you might switch your current 3-4 so

Re: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-13 Thread Lionel Elie Mamane
On Tue, Mar 13, 2012 at 12:22:38PM +, Caolán McNamara wrote: > On Tue, 2012-03-13 at 06:56 +0100, Lionel Elie Mamane wrote: >> On Fri, Mar 09, 2012 at 03:15:10PM +, Caolán McNamara wrote: >>> a) oddly base doesn't show the same fields that the bibliography >>>widget does, possibly a bug

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 vitriol changed: What|Removed |Added Depends on||46809 --- Comment #227 from vitriol 2012-03-1

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on|43869 | -- Configure bugmail: https://bugs.freedes

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 03:00 PM, Lubos Lunak wrote: On Tuesday 13 of March 2012, Stephan Bergmann wrote: On 03/13/2012 11:43 AM, Tor Lillqvist wrote: Hmm, now that the reason for using -Wno-non-virtual-dtor has been documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, should we globally th

[PUSHED] translate german comments

2012-03-13 Thread Michael Meeks
Hi Nicolas, On Sun, 2012-03-11 at 14:16 +0100, Nicolas Christener wrote: > Attached is one more German->English comment translation patch. Lovely ! :-) > Review much appreciated. Well, one minor thing is not leaving whitespace at the end of lines, presumably you had to force the

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Lubos Lunak
On Tuesday 13 of March 2012, Stephan Bergmann wrote: > On 03/13/2012 11:43 AM, Tor Lillqvist wrote: > > Hmm, now that the reason for using -Wno-non-virtual-dtor has been > > documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, > > should we globally then also turn off the correspondin

Re: [PATCH] follow-up of fdo#30788: fix showing of unnecessary empty horizontal scrollbar

2012-03-13 Thread Ivan Timofeev
On 09.02.2012 21:38, Ivan Timofeev wrote: Another question is why in the code above there is pVScrollbar->IsVisible(sal_False) for the vertical scrollbar. I don't know. If this condition is true, then the right border should be set: rToFill.Right() = nTmp; But even if you move that line to the ou

Re: -Wno-non-virtual-dtor

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 11:43 AM, Tor Lillqvist wrote: Hmm, now that the reason for using -Wno-non-virtual-dtor has been documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, should we globally then also turn off the corresponding MSVC warning? That would be kinda predictable (from a "the usu

Re: String literals, ASCII vs UTF-8

2012-03-13 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Lubos Em 05-03-2012 09:29, Lubos Lunak escreveu: > On Tuesday 28 of February 2012, Lubos Lunak wrote: >> I'd like to revisit the choice of considering string literals to be either >> ASCII or UTF-8, as discussed in the thread about removing >> RTL

Re: [ANN] LibreOffice 3.5.1 RC2 available

2012-03-13 Thread Petr Mladek
ape píše v Po 12. 03. 2012 v 04:34 -0700: > Hi, Peter > > 1. You have almost solved the problem open the formula as the OLE-object > formula in the form of the OLE Math object > (libreoffice-3-5~2012-03-09_13.41.25_LibO-Dev_3.5.2rc0_Win_x86/Win-x86@6-fast; > the file "16b.docx" - https://bugs.free

Re: performance enhancements for cygwin make

2012-03-13 Thread Michael Meeks
Hi Noel, On Mon, 2012-03-12 at 11:06 +0200, Noel Grandin wrote: > As this point in time, my opinion is that the idea is not worth doing - > things like touch and cp don't actually seem to trigger very often in > our build process. (Unless I'm doing something very wrong). Oh ! :-) so - o

Re: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-13 Thread Caolán McNamara
On Tue, 2012-03-13 at 06:56 +0100, Lionel Elie Mamane wrote: > On Fri, Mar 09, 2012 at 03:15:10PM +, Caolán McNamara wrote: > > a) oddly base doesn't show the same fields that the bibliography > >widget does, possibly a bug worth fixing ? > > Cannot immediately reproduce. Which field is vi

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Timur changed: What|Removed |Added Depends on||47274 --- Comment #226 from Timur 2012-03-13 05

Re: bin/convwatch.py: graphical layout regression test re-incarnated

2012-03-13 Thread Michael Meeks
On Mon, 2012-03-12 at 22:29 +0100, Michael Stahl wrote: > oh, those are so new-fangled i never heard of them :) ;-) > for me it turned out that the problems of remote UNO are completely > dwarfed by the un-reliability of our awful office code; e.g. i did not > succeed once in printing ~1

-Wno-non-virtual-dtor

2012-03-13 Thread Tor Lillqvist
Hmm, now that the reason for using -Wno-non-virtual-dtor has been documented (760e0d2d7329ca6fc00a8439715bae38becb168a ), I wonder, should we globally then also turn off the corresponding MSVC warning? That would be kinda predictable (from a "the usual waste of time" point of view), as I and othe

Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 09:41 AM, Miklos Vajna wrote: On Mon, Mar 12, 2012 at 01:40:07PM +, Caolán McNamara wrote: Doesn't really matter, but in the ctor member init lists, there isn't really a need to call the default ctors explicitly, e.g. , m_aUnicodeBuffer() , m_aHexBuffer() could just be left o

[REVIEW-3-5] TextEngine::SeekCursor needs to call SetFont after all

2012-03-13 Thread Stephan Bergmann
commit 40c0ff75d2a0f987454b068a663908e6d9b87b9b Author: Stephan Bergmann Date: Tue Mar 13 10:33:10 2012 +0100 TextEngine::SeekCursor needs to call SetFont after all 10f28d5c9a072bf108a79f3b05ad8247ca0dcea5 "callcatcher: build fixes" had removed this with the comment "SetFont() do

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37429, which changed state. Bug 37429 Summary: EDITING: Crash when copy / paste table from Writer https://bugs.freedesktop.org/show_bug.cgi?id=37429 What|Old Value |New Value ---

Re: Excessive exception size cost ...

2012-03-13 Thread Michael Meeks
Hi Noel, On Tue, 2012-03-13 at 08:48 +0200, Noel Grandin wrote: > Just some interesting numbers for this debate. :-) > Doing some rough analysis on master: > > [1] total number of throw calls 108381 It's really rather smaller than this; a better proxy is: $ git grep 'throw

Re: LibreOffice / openIndiana ...

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 10:10 AM, Jonathan Adams wrote: no noticeable difference in either output. [...] Please apply the below patch to see where parsing fails: diff --git a/stoc/source/simpleregistry/textualservices.cxx b/stoc/source/simpleregistry/textualservices.cxx index 37540c8..baa88d4 100644 --

Re: [PUSHED:3-5] Re: Two Python 2.x regressions in LibreOffice 3.5.1RC1

2012-03-13 Thread Petr Mladek
Caolán McNamara píše v Po 12. 03. 2012 v 13:50 +: > On Fri, 2012-03-09 at 15:48 +0100, Michael Stahl wrote: > > On 07/03/12 11:37, Michael Stahl wrote: > > > > > PS: please somebody review the above 2 commits and backport to > > > libreoffice-3-5. > > > > additionally this one is necessary >

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 36982, which changed state. Bug 36982 Summary: [FILEOPEN] Writer ignores text after Equation in docx https://bugs.freedesktop.org/show_bug.cgi?id=36982 What|Old Value |New Value -

Re: [PUSHED:3-5, 3-4, 3-4-6] b68f06287d34833a59841b8000641a02d0994eb8: Iterator crash in writerfilter/source/ooxml/OOXMLPropertySetImpl.cxx

2012-03-13 Thread Petr Mladek
Petr Mladek píše v Po 12. 03. 2012 v 16:45 +0100: > Tor Lillqvist píše v Po 12. 03. 2012 v 15:37 +0200: > > http://cgit.freedesktop.org/libreoffice/core/patch/?id=b68f06287d34833a59841b8000641a02d0994eb8 > > . The added comment should give an idea what it's about. > > It most likely fixes the prob

Re: LibreOffice / openIndiana ...

2012-03-13 Thread Jonathan Adams
no noticeable difference in either output. the saxparser.rdb file that exists is attached. It is supposed to be opening it read only, i'm not sure what the file should contain as it's produced by the build process. Thanks. Jon On 13 March 2012 07:42, Stephan Bergmann wrote: > On 03/12/2012 09

Re: [PUSHED] Bug 45563 - incorrect IMPORT of Zotero RTF, regression

2012-03-13 Thread Miklos Vajna
On Mon, Mar 12, 2012 at 09:21:42AM +0100, "Chr. Rossmanith" wrote: > I have a reproducer doc from the person who reported the bug > (attached to the bug together with an ODT version which is displayed > correctly). Thanks! I've tested this scenario a bit more and it seems \\r should be also pars

Re: [REVIEWED][REVIEW 3-5] fdo#45543 fix RTF import of ms932-encoded characters

2012-03-13 Thread Miklos Vajna
On Mon, Mar 12, 2012 at 01:40:07PM +, Caolán McNamara wrote: > Doesn't really matter, but in the ctor member init lists, there isn't > really a need to call the default ctors explicitly, e.g. > , m_aUnicodeBuffer() > , m_aHexBuffer() > could just be left out OK, I'll keep that in mind for ne

How hard would it be to implement --enable-debug=module1, module2, ... ?

2012-03-13 Thread Tor Lillqvist
It is often very useful to build just some modules with debugging information. (Because building large amounts of code you are not going to be debugging anyway might take lots of disk space, slow down linking, etc.) Currently that has to be done "manually". For temporary debugging needs local to o

Re: Excessive exception size cost ...

2012-03-13 Thread Noel Grandin
I guess so, like I said, very rough numbers. Happy to re-run the analysis if you can suggest a better approach. On 2012-03-13 09:19, Stephan Bergmann wrote: On 03/13/2012 07:48 AM, Noel Grandin wrote: [1] total number of throw calls 108381 [1] git grep throw | wc -l Then this number also inc

Re: [PROPOSAL] get rid of clone/*, use git submodules for binfilter, dictionaries and help

2012-03-13 Thread Miklos Vajna
On Mon, Mar 12, 2012 at 06:44:40PM -0500, Norbert Thiebaud wrote: > you are right... > that would means that ./g remain but is adapted to update the > appropriate submodules based on bin/git-repos > > I could each ./g pull to update the submodules after pulling core... > and other user-friendly

Re: LibreOffice / openIndiana ...

2012-03-13 Thread Stephan Bergmann
On 03/12/2012 09:21 PM, Michael Stahl wrote: On 12/03/12 15:09, Jonathan Adams wrote: # truss output of the specific saxparser command: ( LD_LIBRARY_PATH="/home/sal/LibreOffice/libo/solver/unxsoli/lib" truss -f /home/sal/LibreOffice/libo/solver/unxsoli/bin/saxparser af_NA /home/sal/LibreOffice/

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-03-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37429, which changed state. Bug 37429 Summary: EDITING: Crash when copy / paste table from Writer https://bugs.freedesktop.org/show_bug.cgi?id=37429 What|Old Value |New Value ---

RE: Bibliography DB and DBaseIII files [was: Patch for Easy Hack 45033]

2012-03-13 Thread Winfried Donkers
> > b) oddly base doesn't seem to "PACK" the dbase III files after > >editing, so deleted records still take up space in the file, > >possibly a bug worth fixing ? > > Do you have an idea of how to "PACK" a dbase III file? Is is already > implemented in our code and we just need to add the

Re: Excessive exception size cost ...

2012-03-13 Thread Stephan Bergmann
On 03/13/2012 07:48 AM, Noel Grandin wrote: [1] total number of throw calls 108381 [1] git grep throw | wc -l Then this number also includes all the exception specifications in function declarations/definitions? Stephan ___ LibreOffice mailing lis