On 03/13/2012 09:41 AM, Miklos Vajna wrote:
On Mon, Mar 12, 2012 at 01:40:07PM +0000, Caolán McNamara<caol...@redhat.com>  
wrote:
Doesn't really matter, but in the ctor member init lists, there isn't
really a need to call the default ctors explicitly, e.g.
, m_aUnicodeBuffer()
, m_aHexBuffer()
could just be left out

OK, I'll keep that in mind for new code. I just remember at least once I
left out something similar, got no local warnings, but the OSX -Werror
tinbuild failed.

IIRC, this sometimes happens with copy ctors, when for some reason default initialization of a base or member would be fine (so could be left out), but some compilers would warn about the copy ctor not explicitly initializing a base or member.

Stephan
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Reply via email to