RE: [PATCH]fdo45671 writer par. bg color simplified code for split button

2012-03-05 Thread Winfried Donkers
Ivan Timofeev wrote (5 maart 2012 18:08) >1. Open a new Writer doc >2. Type smth >3. Press the "Background Color" button >-> nothing happens (?) That is expected behaviour to me. The startup background colur is transparent (hence the gray bitmap in the button). >4. Select some color from the

Re: [PATCH] [PUSHED] fdo 45688 calc font color with split button

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: GSoC & error during make

2012-03-05 Thread Norbert Thiebaud
On Mon, Mar 5, 2012 at 6:20 PM, Mariana Marasoiu wrote: >> On Sun, Mar 4, 2012 at 7:08 PM, Mariana Marasoiu >>> --- >>>        Oh dear - something failed during the build - sorry ! >>>  For more help with debugging build errors, p

[REVIEW] fix for fdo#46975 , crash when using mouse wheel in input line

2012-03-05 Thread Markus Mohrhard
Hey, [1] fixes a crash when you use the mouse wheel while a formula is in the selected cell. We should not handle the mouse wheel event for the input line. I think this patch is safe. I did not move the handling of the event to the parent window because this would result in scrolling through the

Re: GSoC & error during make

2012-03-05 Thread Mariana Marasoiu
On Mon, Mar 5, 2012 at 3:42 AM, Norbert Thiebaud wrote: > On Sun, Mar 4, 2012 at 7:08 PM, Mariana Marasoiu > wrote: >> Hello everyone! >> >> >> I'm Mariana Mărășoiu from Romania and I am a second-year student at >> "Politehnica" University of Bucharest, Automatic Controls and >> Computers Faculty

Re: Small note on static analyzer, includes and build times...

2012-03-05 Thread Albert Thuswaldner
Hi Michael, On Thu, Mar 1, 2012 at 12:28, Albert Thuswaldner wrote: > Hi Stephan and Michael, > > On Wed, Feb 29, 2012 at 19:12, Michael Meeks wrote: >> >>Well - the pre-compiled headers would make -tons- of includes look >> useless anyway, though (I thought) we had decided to get rid of

offapi again builds faster; user of gb_Deliver_deliver responsible for the directory

2012-03-05 Thread Matúš Kukan
Hi all, I was inspired by Norbert's work in d44a3e291cb8c4b3ec5ce1775edd527b475ebca4 I removed calling mkdir -p from gb_Deliver__deliver[1], so now the user of that function is responsible that the directory where he wants to deliver something exists. On cygwin this is really improvement: Buildin

Re: Automatically section update with java

2012-03-05 Thread Toygun
Hi Michael, thanks, i'll try it as you wrote. Regards Toygun On 03/05/2012 10:51 PM, Michael Meeks wrote: Hi Toygun, On Mon, 2012-03-05 at 21:46 +0100, Toygun wrote: thank you for your answer. But i didn't mean the right click 'update index / table'. Well, that's much more helpful, i

Re: Automatically section update with java

2012-03-05 Thread Michael Meeks
Hi Toygun, On Mon, 2012-03-05 at 21:46 +0100, Toygun wrote: > thank you for your answer. But i didn't mean the right click 'update > index / table'. Well, that's much more helpful, if you'd said that to start with my example would have got you a lot closer with little effort :-) > "This

Re: libo build 3.6 Debian Wheezy

2012-03-05 Thread Rene Engelhard
Hi, On Mon, Mar 05, 2012 at 03:14:08PM +0100, Luc Castermans wrote: > - make 3.82 needs to be installed (from Debian experimental); without > it you get segmentation fault This is not true. make 3.81 works and configure checks for that. A segmentation fault in configure is normal, that is exactly

Re: Base hangs when trying to close it

2012-03-05 Thread Michael Meeks
On Mon, 2012-03-05 at 12:56 -0800, julien2412 wrote: > I'm just a C++ beginner (and think i'll still be for years), it's far beyond > my few skills sorry Hah ! you're doing really well for a beginner :-) > Now if someone propose a patch I can try to test again the closing of base.

License statement

2012-03-05 Thread willubuntu
It's with pleasure that I announce you that: "All of my past and future contributions to the LibreOffice project may be licensed under the MPL/LGPLv3+ license" Regards, William Gathoye -- View this message in context: http://nabble.documentfoundation.org/License-statement-tp3801956p3801956.

[REVIEW -3-5] Fix dialog controls size and position in the file preperties dialog

2012-03-05 Thread Michael Meeks
This fixes the layout of the dialog so we don't truncate translations: http://cgit.freedesktop.org/libreoffice/core/commit/?id=21d85dabe5d780571ad8ca39c8e6d30be90a0bf4 I'd love to have it reviewed & cherry-picked to -3-5 :-) before: http://libreoffice.gathoye.be/Patch_file_properties_si

[PUSHED] Fix dialog controls size and position in the file preperties dialog

2012-03-05 Thread Michael Meeks
Hi there, Sorry for the delay here, I took the long thread (which turned out to be about whitespace ;-) as some sort of closure and ignored it. Anyhow - I pushed the nice patch, thanks for that ! Regards, Michael. -- michael.me...@suse.com <><, Pseudo

Re: Base hangs when trying to close it

2012-03-05 Thread julien2412
Hi Michael, I'm just a C++ beginner (and think i'll still be for years), it's far beyond my few skills sorry :-( Now if someone propose a patch I can try to test again the closing of base. Julien. -- View this message in context: http://nabble.documentfoundation.org/Base-hangs-when-trying-to-cl

Re: Automatically section update with java

2012-03-05 Thread Toygun
Hi Michael, thank you for your answer. But i didn't mean the right click 'update index / table'. i try to explain again :-) Sorry for english. document A has 2 inserted Sections, Section1 and Section2. Section1 is from document B and Section2 is from document C. I change the contents in Sec

Re: LibreOffice fails to recognize MATE as GNOME/GTK-based desktop

2012-03-05 Thread Michael Meeks
Hi there, On Mon, 2012-03-05 at 21:19 +0100, Arnaud Champollion wrote: > Le 05/03/2012 12:23, Michael Meeks a écrit : > > Then we can trivially add this to the desktopdetector.cxx and fix all > > lightdm users in our next release. But of course you'd need to come up > > with that information and/o

Re: LibreOffice fails to recognize MATE as GNOME/GTK-based desktop

2012-03-05 Thread Arnaud Champollion
Le 05/03/2012 12:23, Michael Meeks a écrit : Then we can trivially add this to the desktopdetector.cxx and fix all lightdm users in our next release. But of course you'd need to come up with that information and/or a patch Well, actually I can't propose any patch. I have no skill in developpem

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-05 Thread Norbert Thiebaud
On Fri, Mar 2, 2012 at 4:52 AM, Matúš Kukan wrote: > On 2 March 2012 11:31, Tor Lillqvist wrote: >> Is there a way to do "make clean" only for the host platform, not the >> build platform? Is there a way to make clean only for object files, >> and especially not the stuff generated from IDL files

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-05 Thread Tor Lillqvist
> Been looking in our make 3.82 sources for some > moments but can't find the place where it canonicalizes filenames. Ha, make was innocent, concat-deps had the problem. Should be fixed by 921902ead77b7111a84678898e92fbdaf9e6f496 . --tml ___ LibreOffice

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-05 Thread Michael Meeks
On Mon, 2012-03-05 at 16:34 +, Caolán McNamara wrote: > In the general case presumably you then need to run around sticking > throw()/nothrow onto loads of things in order to tell the compiler that > stuff isn't going to throw exceptions, and/or disabling exceptions to > get the compiler to do

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-05 Thread Tor Lillqvist
It seems that there are two combining reasons why this particular facreg.cxx file is causing problems: 1) the trailing slash in the -I$S/sax/source/fastparser/ passed to the compiler, 2) that facreg.cxx includes fastserializer.h with #include "../tools/fastserializer.hxx" (Nothing strictly wr

Re: [PATCH]fdo45671 writer par. bg color simplified code for split button

2012-03-05 Thread Ivan Timofeev
1. Open a new Writer doc 2. Type smth 3. Press the "Background Color" button -> nothing happens (?) 4. Select some color from the picker -> ok, it works 5. Select "No Fill" -> nothing happens How to restore the transparent background? Ivan ___

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-05 Thread Tor Lillqvist
> finally had time for a look Thanks! > the problem is this: Great hints, will investigate. > what gcc version do you use... oh, that's an unusual one :) Hopefully clang will be more used also on our traditional platforms in the future; after using it for a week or so to compile LO code, I am

Re: [PATCH] [PUSHED] Remove unused code (23)

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] Translate German comments in core/comphelper

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

REMINDER: Release 3.4.6-rc1 from libreoffice-3-4 branch

2012-03-05 Thread Petr Mladek
Hi, we postpone the commit deadline for 3.4.6-rc1 by one day. Please, commit/nominate all fixes until tomorrow, February 6, 2012. The branch libreoffice-3-4-6 and the tag will be created the day after. Only commits with 3 reviewers will be allowed for that branch. The delay is caused by the prob

Re: [PATCH] [PUSHED] fix for fdp#44832, correctly display axis labels for complex categories

2012-03-05 Thread Tor Lillqvist
> If it's for master then I'd say ignore my silly post and push. OK, done. Thanks. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH]fdo 45688 calc font color with split button

2012-03-05 Thread Winfried Donkers
Attached patch is the next one from meta bug 45671. WinfriedFrom 4c326a629ddc9e04fb7aa5cedf99a61eaa70074f Mon Sep 17 00:00:00 2001 From: Winfried Donkers Date: Mon, 5 Mar 2012 17:24:40 +0100 Subject: [PATCH] fdo#45688 split button for calc cell font color --- sc/source/ui/app/scdll.cxx

[ANNOUNCE] libreoffice-3.5.1.2 tag created (3.5.1-rc2)

2012-03-05 Thread Petr Mladek
Hi, there have been created the libreoffice-3.5.1.2 tag for 3.5.1-rc2 release. The corresponding official builds will be available within next few days. It will be used as final if no blocker is found. See the attached list of changes against 3.5.1-rc1. Now, you might switch your current 3-5 so

RE: [PATCH]fdo45671 writer par. bg color simplified code for split button

2012-03-05 Thread Winfried Donkers
Ivan Timofeev wrote (5 maart 2012 17:23) >So, a call without arguments meant "set transparent background", that >corresponds to the "No Fill" button in the picker. I'd suggest recover >this code, otherwise "No Fill" does not work for me. What do you think? (I hope I understand what you mean.) The

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-05 Thread Caolán McNamara
On Mon, 2012-03-05 at 15:29 +, Michael Meeks wrote: > On Fri, 2012-03-02 at 17:16 +, Caolán McNamara wrote: > At the most banal level, I suspect that: > > struct Empty { int unused; }; > Empty *p = new Empty(); > delete p; > > can't legitimately be optimised away i

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

2012-03-05 Thread Michael Stahl
On 01/03/12 11:09, Tor Lillqvist wrote: > No errors or warnings are printed. make -sr clean doesn't help. This > started happening suddenly today. This is in a cross-compilation. > ccache isn't used. (I normally do use ccache but dropped it now to see > if it would help: No...) > > mymlan:sax tml$

Re: [PATCH]fdo45671 writer par. bg color simplified code for split button

2012-03-05 Thread Ivan Timofeev
Hi Winfried, On 03.03.2012 12:57, Winfried Donkers wrote: Attached the next button with simplified code. More to follow. Hmmm -else -{ -// call without arguments, use last used background color -aBrushItem.SetColor(

[PATCH] Translate German comments in core/comphelper

2012-03-05 Thread Tom Thorogood
Resubmitting due to a git fail on my part. >From 74208e133dff3eef1ec8a769f857de614689f9e9 Mon Sep 17 00:00:00 2001 From: Tom Thorogood Date: Tue, 28 Feb 2012 00:38:23 -0500 Subject: [PATCH] Translate german comments in core/comphelper --- comphelper/inc/comphelper/oslfile2streamwrap.hxx |

Re: [PATCH] fix for fdp#44832, correctly display axis labels for complex categories

2012-03-05 Thread Kohei Yoshida
Ok. I just showed my stupidity by thinking this was for 3.5. If it's for master then I'd say ignore my silly post and push. Thanks, Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libr

Re: [PATCH] fix for fdp#44832, correctly display axis labels for complex categories

2012-03-05 Thread Kohei Yoshida
Hi, On Mon, Mar 5, 2012 at 3:34 AM, Tor Lillqvist wrote: > Does anybody who knows the code feel like reviewing the patch for > real, I could review, but then I'm not knowledgeable enough on the chart2 code to add any confidence. or should we just trust Markus that it fixes the problem, and > p

[PATCH] Remove unused code (23)

2012-03-05 Thread Elton Chung
Hi, This patch removes 2 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email: el...@layerjet.com --

Re: [REJECTED][PATCH] instance of SV_DECL_VARARR_SORT -> std::set

2012-03-05 Thread Matúš Kukan
On 5 March 2012 15:02, Ivan Timofeev wrote: > Sorry, that area was cleaned already > http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf2fbadf90c1cb255e39529b856df3eaef1e0226 > Original patch was submitted 25.02.2012. No problem, it was more about learning C++ than doing something useful.

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 17:16 +, Caolán McNamara wrote: > Yeah, back the O[UString contents with direct new/delete calls in a real > implementation body instead of current thin header-only wrapper around > the C-API which backs onto rtl_allocateMemory/rtl_freeMemory. I'm really rather c

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Caolán McNamara
On Mon, 2012-03-05 at 11:41 +, Michael Meeks wrote: > Caolan - I notice the option seems to be mentioned in: > > qadevOOo/testdocs/ttt.sda > > Which you touched last :-) is this a feature we need to keep ? Originally the smoketest just wrote out some .sdX files and reloaded

[PUSHED] Re: [REVIEW -3-5] RTF import of non-box paragraph borders

2012-03-05 Thread Michael Stahl
On 05/03/12 10:34, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=343b52e > > Test document attached, regression from 3.4. pushed to libreoffice-3-5 ___ LibreOffice mailing list LibreOffice@lists.freedeskto

Re: Base hangs when trying to close it

2012-03-05 Thread Michael Meeks
Hi Julien, On Sun, 2012-03-04 at 12:02 -0800, julien2412 wrote: > On master only (I don't have the problem on 3.5 branch), Base hangs when I > try to close it. I must select "Tables"/"Queries" or others to have the > problem. If I just open a file and close, i don't have this problem. Rii

libo build 3.6 Debian Wheezy

2012-03-05 Thread Luc Castermans
Hi, After IT did wipe out my laptop 2 weeks ago I restored also my Linux dual boot, using Debian Wheezy. Yesterday I managed to re-compile Libo. Two notes: - it compiled very fast, at least 2x faster then before (same machine, same OS) - make 3.82 needs to be installed (from Debian experimental);

Re: LibreOffice / openIndiana ...

2012-03-05 Thread Michael Meeks
On Mon, 2012-03-05 at 12:06 +, Jonathan Adams wrote: > I'd prefer to stick with the system supplied gcc, but will move to a > packaged version that is stored somewhere else if that'd help. Sure - IMHO we should be using the gnu tools as much as possible, if only to reduce the differen

Re: [PUSHED][PATCH] Improvement to fdo#46565

2012-03-05 Thread Ivan Timofeev
I see Tor pushed the patch http://cgit.freedesktop.org/libreoffice/core/commit/?id=0847fd63d773732ff3e441ef868957c55760d69a Regards, Ivan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreo

Re: [PUSHED][3-4][3-5] fdo#39694, fdo#42073 Writer field expansion regression bugs

2012-03-05 Thread Miklos Vajna
On Mon, Mar 05, 2012 at 12:40:04PM +0100, Michael Stahl wrote: > some time ago i noticed that some text fields in writer can only be > expanded properly in the text formatting, and so tried to prevent > expansion of fields in lots of other places (in CWS sw34bf01); > it seems that that went a bit

Re: [REJECTED][PATCH] instance of SV_DECL_VARARR_SORT -> std::set

2012-03-05 Thread Ivan Timofeev
Hi Matúš, On 02.03.2012 02:47, Matúš Kukan wrote: Hi there, This is my first STL C++ patch. ( I also wanted to do some conversion. ) Please review / comment / enjoy. Sorry, that area was cleaned already http://cgit.freedesktop.org/libreoffice/core/commit/?id=cf2fbadf90c1cb255e39529b856df3eaef

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Chr. Rossmanith
Hi, as suggested on IRC I've removed the whole StrictSO52Compatibility stuff. It builds successfully - make test is on its way. "git grep" reported some test documents matching as well, so I expect some tests to fail. Christina Am 05.03.2012 12:41, schrieb Michael Meeks: On Fri, 2012-03-0

Re: [PATCH] Convert SV_DECL_VARARR_SORT and SV_IMPL_VARARR_SORT with std::set

2012-03-05 Thread Ivan Timofeev
Hi Bartosz, On 29.02.2012 13:45, Bartosz wrote: I converted the SV_DECL_VARARR_SORT and SV_IMPL_VARARR_SORT with ::std::set. I also made some optimization (cppcheck). Could you please check this patch and push it into libreoffice. Oh, sorry, your patch does not apply due to cgit.freedesktop.o

Re: [PUSHED][PATCH] EasyHacks fdo#38831 VARARR and VARARR_SORT

2012-03-05 Thread Ivan Timofeev
Hi Maciej, On 25.02.2012 19:13, Maciej Rumianowski wrote: small patches partially cleaning svltools from svarrays. Nice patches, thank you! I wonder why you used (*it).nStartPos instead of it->nStartPos , but code is correct, so pushed as is. Regards, Ivan _

Re: [PUSHED][PATCH] Convert tools/table.hxx usage in toolkit/source/controls/unocontrolmodel.cxx to std::map

2012-03-05 Thread Ivan Timofeev
Hi Noel, On 29.02.2012 13:19, Noel Grandin wrote: Convert tools/table.hxx usage in toolkit/source/controls/unocontrolmodel.cxx to std::map Pushed with some corrections, thanks, nice cleanup! I only replaced @@ -1252,26 +1205,29 @@ void UnoControlModel::setFastPropertyValue_NoBroadcast( sal_

[PUSHED 3.5.1] redundantAssignInSwitch in connectivity/source/drivers/postgresql/pq_tools.cxx

2012-03-05 Thread Michael Meeks
On Mon, 2012-03-05 at 10:59 +0100, Petr Mladek wrote: > Great catch. It makes perfect sense. Amazingly it's been there since this was checked in, so - lets hope that we aren't relying on the bad behaviour. > We need one more approval for 3-5-1 branch. Pushed to -3-5-1.

Re: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-05 Thread Michael Meeks
On Mon, 2012-03-05 at 12:30 +0200, Tor Lillqvist wrote: > > Ah - this might be to help with systems that don't have a window > > manager in the same way that desktop systems do. > > Hmm, but at least on some such systems applications are never supposed > to "exit" by themselves, and definitely no

Re: [PUSHED][REVIEW-3-5-1] fix for fdo#46885, crash with empty data range when creating charts

2012-03-05 Thread Eike Rathke
Hi, On Monday, 2012-03-05 12:24:42 +0100, Petr Mladek wrote: > One more approval needed for 3-5-1. Pushed http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-1&id=09c97519a1ccb8935787946b63cfb0b142f540e3 Eike -- LibreOffice Calc developer. Number formatter stricken i18n t

Re: [PUSHED][REVIEW 3-5-1] fix for fdo#46816, don't show error message for empty range name in Define Names

2012-03-05 Thread Eike Rathke
Hi, On Monday, 2012-03-05 11:27:11 +, Michael Meeks wrote: > You have a #2 from me - looks trivial & safe for -3-5-1. Pushed http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-1&id=3730a7173298814a709a0bcbb2150288ea1c464d Eike -- LibreOffice Calc developer. Num

Re: [PUSHED][REVIEW 3-5-1] fix for fdo#46825, crash copying a chart

2012-03-05 Thread Eike Rathke
> Pushed > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-1&id=7f1f734113cc443caa2be4fbe376ab85d09eefac Marking subject ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A

Re: String literals, ASCII vs UTF-8

2012-03-05 Thread Lubos Lunak
On Tuesday 28 of February 2012, Lubos Lunak wrote: > I'd like to revisit the choice of considering string literals to be either > ASCII or UTF-8, as discussed in the thread about removing > RTL_CONSTASCII_USTRINGPARAM. While I was ambivalent about it, I now think > we should go with ASCII only, un

Re: [REVIEW 3-5-1] fix for fdo#46825, crash copying a chart

2012-03-05 Thread Eike Rathke
Hi, On Monday, 2012-03-05 11:29:40 +, Michael Meeks wrote: > -3-5-1, one more review needed. Pushed http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-1&id=7f1f734113cc443caa2be4fbe376ab85d09eefac Eike -- LibreOffice Calc developer. Number formatter stricken i18n tra

Re: LibreOffice / openIndiana ...

2012-03-05 Thread Jonathan Adams
I'm sure I'd tried that before ... ahh yes: Compiling: registry/tools/rdbedit.cxx Making:regmerge Undefined first referenced symbol in file _ZTI* ../unxsoli/lib/libreg.so _ZTS* ../unx

[PUSHED-3-4] Fix for fdo#34209

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 17:20 +0100, Thorsten Behrens wrote: > somewhat ugly but effective fix for not showing credits etc. on Mac. > Got independently fixed by Stephan's 3layer-cleanup on -3-5, so no > need for action there. Pushed to -3-4, thanks ! :-) Michael. -- micha

Re: LibreOffice / openIndiana ...

2012-03-05 Thread Michael Stahl
On 05/03/12 12:08, Jonathan Adams wrote: > anyone got a quick fix for all the "version-script" code in gcc (using SUN > ld)? > > "-Wl,--version-script ../unxsoli/misc/store_store.map" > > Making:libstore.so.3 > ld: fatal: unrecognized option '--' > ld: fatal: use the -z help option for usage

Re: Reduce duplicate code: PrinterJob::writeProlog

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 21:03 +0100, Chr. Rossmanith wrote: > static const sal_Char pProlog[] and static const sal_Char > pSO52CompatProlog[] share about 90% of their content (2 out of 84 lines > differ). Wow - that is really horrible :-) > I could split the prolog in three parts: part

[REVIEW][3-*] fdo#39694, fdo#42073 Writer field expansion regression bugs

2012-03-05 Thread Michael Stahl
hi all, some time ago i noticed that some text fields in writer can only be expanded properly in the text formatting, and so tried to prevent expansion of fields in lots of other places (in CWS sw34bf01); it seems that that went a bit past the mark, and some API methods now fail if they are invok

[REVIEW 3-5-1] fix for fdo#46825, crash copying a chart

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 22:13 -0500, Kohei Yoshida wrote: > > [1] fixes a crash when you copy a chart in the document. The problem > > is that you should not create a uno::Sequence with new because the > > uno::Sequence copy c'tor is creating a flat copy. This will later > > result in a double delet

[REVIEW 3-5-1] fix for fdo#46816, don't show error message for empty range name in Define Names

2012-03-05 Thread Michael Meeks
On Fri, 2012-03-02 at 22:18 -0500, Kohei Yoshida wrote: > > [1] improves the dialog a bit. The error message is a bit misleading > > and we can just use the disabled Add button as sign that you can't add > > an empty range name. > > > [1] > > http://cgit.freedesktop.org/libreoffice/core/commit/?

Re: LibreOffice fails to recognize MATE as GNOME/GTK-based desktop

2012-03-05 Thread Michael Meeks
Hi Arnaud, On Sat, 2012-03-03 at 09:36 +0100, Arnaud Champollion wrote: > The problem have been solved by adding > export OOO_FORCE_DESKTOP=gnome Ok - so this is used in this code: http://cgit.freedesktop.org/libreoffice/core/tree/vcl/unx/generic/plugadapt/salplug.cxx#n158 and t

Re: [REVIEW-3-5-1] fix for fdo#46885, crash with empty data range when creating charts

2012-03-05 Thread Petr Mladek
Michael Meeks píše v Po 05. 03. 2012 v 10:58 +: > On Sun, 2012-03-04 at 17:23 +0100, Markus Mohrhard wrote: > > [1] fixes a crash when you try to create a chart and have an empty > > data range selected. This is a regression between 3.5.0 and 3.5.1 > > I merged this to -3-5, two more ack

Re: [PATCH] fdo#45678: EasyHack: kill hwpfilter/source/list.hxx with fire

2012-03-05 Thread Noel Grandin
Looking at how the data is used, I'm pretty sure these data-structures could be modified to use std::vector, and the node structure stored directly like this: std::vector plist; ...and... extern std::vector nodelist; which would be more memory-efficient, but I suppose it doesn't really

Re: using Windows in VM

2012-03-05 Thread Jonathan Aquilina
On 3/5/12 11:47 AM, Michael Meeks wrote: On Sun, 2012-03-04 at 14:21 +0100, Jesús Corrius wrote: I have already found a place for it. As far as I know, Michael and Thorsten are already using it ;) I'm doing some rummaging around to see if we can get some license pool we can use for hack

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-03-05 Thread Jonathan Adams
anyone got a quick fix for all the "version-script" code in gcc (using SUN ld)? "-Wl,--version-script ../unxsoli/misc/store_store.map" Making:libstore.so.3 ld: fatal: unrecognized option '--' ld: fatal: use the -z help option for usage information collect2: ld returned 1 exit status dmake: E

[REVIEW-3-5-1] fix for fdo#46885, crash with empty data range when creating charts

2012-03-05 Thread Michael Meeks
On Sun, 2012-03-04 at 17:23 +0100, Markus Mohrhard wrote: > [1] fixes a crash when you try to create a chart and have an empty > data range selected. This is a regression between 3.5.0 and 3.5.1 I merged this to -3-5, two more acks for -3-5-1 appreciated. > The fix is extremely safe it j

Re: [PATCH] [PUSHED] convert SbxFactory in BASIC module from SV_DECL_PTRARR_DEL to boost::ptr_vector

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: using Windows in VM

2012-03-05 Thread Michael Meeks
On Sun, 2012-03-04 at 14:21 +0100, Jesús Corrius wrote: > I have already found a place for it. As far as I know, Michael and > Thorsten are already using it ;) I'm doing some rummaging around to see if we can get some license pool we can use for hackers around this. All the best,

Re: [PATCH] convert SbxFactory in BASIC module from SV_DECL_PTRARR_DEL to boost::ptr_vector

2012-03-05 Thread Noel Grandin
Ping? On 2012-02-27 16:31, Noel Grandin wrote: Hi License is on file. Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html >From dcb00e7ca3c52d3c371eeb614629e3bcb4861e8b Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 27 Feb 2012 16:26:41 +0200 Subject: [PATCH]

Re: Yet another string class: MzString in hwpfilter/source/mzstring.{h, cxx}

2012-03-05 Thread Michael Meeks
Hi Tor, On Mon, 2012-03-05 at 10:57 +0200, Tor Lillqvist wrote: > Any idea whether this really is needed, or can it easily be replaced > by some of our other string classes? Or is hwpfilter so utterly > unimportant code that it's not worth pondering? It can be replaced, it's an internal i

Re: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-05 Thread Tor Lillqvist
> Ah - this might be to help with systems that don't have a window > manager in the same way that desktop systems do. Hmm, but at least on some such systems applications are never supposed to "exit" by themselves, and definitely not offer the user any way inside the application to "exit". Instead

Re: Mac OSX build failure in pyuno on master

2012-03-05 Thread Alexander Thurgood
Le 05/03/12 11:14, Alexander Thurgood a écrit : Oops, forgot the log file. Attached. Alex Making:all_pyuno.dpslo Compiling: pyuno/unxmacxi.pro/misc/pyuno_version.c Compiling: pyuno/source/module/pyuno_module.cxx Compiling: pyuno/unxmacxi.pro/misc/pyuno_version.c cp uno.py ../../unxmacxi.pr

Re: [PATCH] fdo#33043: Would be nice if the 'Start Center' had an exit button

2012-03-05 Thread Michael Meeks
On Sun, 2012-03-04 at 19:31 +0100, Tommy wrote: > what's the purpose of such a button? > once you are in the start center you already can close everything > simply hitting the "X" button in the right upper corner. Ah - this might be to help with systems that don't have a window manager in

Mac OSX build failure in pyuno on master

2012-03-05 Thread Alexander Thurgood
Hi, Has something changed with pyuno again recently ? I'm now getting a build failure in pyuno on Mac OSX server 10.6.8, cf. attached build log. Making:libpyuno.dylib Checking DLL ../../unxmacxi.pro/lib/libpyuno.dylib ...: ERROR: dlopen(../../unxmacxi.pro/lib/libpyuno.dylib, 2): Library not

Re: Automatically section update with java

2012-03-05 Thread Michael Meeks
Hi Toygun, On Mon, 2012-03-05 at 08:46 +0100, Toygun wrote: > I have a odt document where I inserted 2 sections from other documents. > Changing these sections requires an update in the enclosing document > when using Libre Office or OpenOffice (popup is asking me). OK; if you mean the ri

Re: [REVIEW 3.5.1] redundantAssignInSwitch in connectivity/source/drivers/postgresql/pq_tools.cxx

2012-03-05 Thread Petr Mladek
julien2412 píše v Ne 04. 03. 2012 v 07:17 -0800: > Seen with Niko Rönkkö on IRC, I pushed it on 3.5 branch. Just for record, it is the commit http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=bd52977757ea8cf71897340bc938baf183b9787f > Ok for 3.5.1 too ? Great catch. It m

Re: [PATCH] fdo#45678: EasyHack: kill hwpfilter/source/list.hxx with fire

2012-03-05 Thread Michael Meeks
Hi there, On Fri, 2012-03-02 at 16:39 +0100, Dézsi Szabolcs wrote: > diff --git a/hwpfilter/source/grammar.cxx > b/hwpfilter/source/grammar.cxx > index 2285aab..99c2f3c 100644 > --- a/hwpfilter/source/grammar.cxx > +++ b/hwpfilter/source/grammar.cxx > @@ -909,291 +910,291 @@ yyreduce: > > case

[REVIEW -3-5] RTF import of non-box paragraph borders

2012-03-05 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=343b52e Test document attached, regression from 3.4. Thanks, Miklos test.rtf Description: RTF file ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskto

Re: [PATCH] [PUSHED] Replace String by OUString

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. I'll follow up with dropping the apparently unused variable myself. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] fdo#45678: EasyHack: kill hwpfilter/source/list.hxx with fire

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Yet another string class: MzString in hwpfilter/source/mzstring.{h, cxx}

2012-03-05 Thread Tor Lillqvist
Any idea whether this really is needed, or can it easily be replaced by some of our other string classes? Or is hwpfilter so utterly unimportant code that it's not worth pondering? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http

Re: [REVIEW 3-5][REVIEW 3-5-1][PUSHED 3-5] Fix for fdo#562027, lp#562027, deb#632920: Quickstarter breaks log out (fixed)

2012-03-05 Thread David Tardon
On Mon, Mar 05, 2012 at 09:36:01AM +0100, David Tardon wrote: > On Mon, Mar 05, 2012 at 09:03:07AM +0100, Bjoern Michaelsen wrote: > > Hi, > > > > the patch was fixed with: > > > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3d78616dfc0805ff31038e00148e115d409ef9a > > > > plea

Re: EasyHack: [PUSHED] perl / autogen.sh should backup autogen.lastrun

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] [PUSHED] fdo#42396: Wizard dropdown does not sort alphabetically

2012-03-05 Thread Tor Lillqvist
> This is my first hack in Java, so let me know if something is wrong. > I tested it, it worked for me. That's good enough for me;) Pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: What's the logic behind that new "footer" in WRITER

2012-03-05 Thread Cedric Bosdonnat
Hello, On Sat, 2012-03-03 at 22:07 +0100, john malc wrote: > I write a seminar paper, where I need to have a footer with link > (URL). > NOW : Let's imagine there is a page 1 with 2 URLs. After finishing > this page, I begin to write the second one, where I don't want to have > the same links as o

Re: [PATCH] [PUSHED] Remove unused code (22)

2012-03-05 Thread Tor Lillqvist
Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-5][REVIEW 3-5-1] Fix for fdo#562027, lp#562027, deb#632920: Quickstarter breaks log out (fixed)

2012-03-05 Thread David Tardon
On Mon, Mar 05, 2012 at 09:03:07AM +0100, Bjoern Michaelsen wrote: > Hi, > > the patch was fixed with: > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3d78616dfc0805ff31038e00148e115d409ef9a > > please review the attached combined patch for 3-5 and 3-5-1. Thanks. +1 provided th

Re: [PATCH] fix for fdp#44832, correctly display axis labels for complex categories

2012-03-05 Thread Tor Lillqvist
Does anybody who knows the code feel like reviewing the patch for real, or should we just trust Markus that it fixes the problem, and push it? (I think we should.) Isn't there some odd indentation changes in the patch? --tml ___ LibreOffice mailing list

Re: [PATCH] [PUSHED] remove unused code

2012-03-05 Thread Tor Lillqvist
Pushed to master, thanks! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-5][REVIEW 3-5-1] Fix for fdo#562027, lp#562027, deb#632920: Quickstarter breaks log out (fixed)

2012-03-05 Thread Bjoern Michaelsen
Hi, the patch was fixed with: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f3d78616dfc0805ff31038e00148e115d409ef9a please review the attached combined patch for 3-5 and 3-5-1. Thanks. Best, Bjoern >From 3186b948d5c162b2277d577052eb3262fde293f0 Mon Sep 17 00:00:00 2001 From: Bjoer