Re: [Libreoffice] LibreOffice Code Cleanup Patch

On 01/27/2012 07:54 AM, Ivan Timofeev wrote: ... but we have no strong rule about this kind of formatting. The "Code Conventions" page[1] we refer to in our Development wiki page[2] contains nothing about foo( bar ); vs foo(bar); vs foo (bar); Personally I prefer the second variant, but usually

Re: [Libreoffice] LibreOffice Code Cleanup Patch

On 01/27/2012 05:49 AM, Muthu Subramanian K wrote: Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? @lubos: Alexander is good with scripts, so as a starter he wante

Re: [Libreoffice] LibreOffice / openIndiana ...

On 01/26/2012 11:17 PM, Norbert Thiebaud wrote: as for the dmake side of thing (solenv/inc/sol*4.mk) something like .IF "$(COM)$(OS)$(CPU)" == "GCCSOLARISX" (for intel x86_64 ) or GCCSOLARISI for x86, etc... .INCLUDE : uxnsolg[x|i|..].mk and create such a file based on similar unxix build... loo

Re: [Libreoffice] Libreoffice On OPENINDIANA

Yes Thank you, I will follow the other thread. Paolo Il 1/26/12 10:13 PM, Michael Stahl ha scritto: On 26/01/12 16:46, Paolo Marcheschi wrote: If you want to run the smoketest, issue: make check but I had no luck, when i do a make, I receive the following error: make: Fatal error in read

Re: [Libreoffice] [PUSHED 3-5][REVIEW-3-5-0] Danish dictionary 2.0

On 01/26/2012 10:52 PM, Eike Rathke wrote: One thing spotted though: in dictionaries/da_DK/description.xml we have Is that really supposed to be '.' separator and not ISO 8601 '-'? Yes, see .

Re: [Libreoffice] LibreOffice Code Cleanup Patch

27.01.2012 08:55, Muthu Subramanian K пишет: @Alex: Forgot to mention one more thing: We follow (normally) space after '(' and before ')' if there are parameters. Sometimes, we would be tempted to remove the space in cases like foo( param1, param2 ); as well ;) ( I am always tempted in such cases

Re: [Libreoffice] Adabas still being built in master ?

On Fri, Jan 27, 2012 at 06:55:38AM +0100, Lionel Elie Mamane wrote: > On Thu, Jan 26, 2012 at 02:41:06PM +0100, Alex Thurgood wrote: >> I keep seeing this in my build: >> [ build CXX ] dbaccess/source/ext/adabas/Acomponentmodule.cxx >> [ build CXX ] dbaccess/source/ext/adabas/AdabasNewDb.cxx >> [

Re: [Libreoffice] Adabas still being built in master ?

On Thu, Jan 26, 2012 at 02:41:06PM +0100, Alex Thurgood wrote: > Perhaps I misunderstood what François' commits were supposed to do, > but I thought that the Adabas db stuff had been pulled out of the > compilation sequence. >From what I read in the ML archives, François intended to disable only

Re: [Libreoffice] [REVIEW] Revert of UNO interface publishing

On Thu, Jan 26, 2012 at 10:24:52PM +0100, Thorsten Behrens wrote: > Michael Meeks wrote: >> AA: + do the easiest roll-back possible to cleanup the >>canvas publishing issue in 3.5.0 (Thorsten) > Anyway - commit on master is here: > > http://cgit.freedesktop.org/libreoffice/core/commit/

Re: [Libreoffice] LibreOffice Code Cleanup Patch

@Alex: Forgot to mention one more thing: We follow (normally) space after '(' and before ')' if there are parameters. Sometimes, we would be tempted to remove the space in cases like foo( param1, param2 ); as well ;) ( I am always tempted in such cases :P ) On 01/27/2012 10:19 AM, Muthu Subramania

Re: [Libreoffice] LibreOffice Code Cleanup Patch

Hello Alexander, Its nice to see those patches. But, it will be nice to see/use the tools/scripts directly? Especially if they can be hooked to git (like the current white space/tabs removal ones)? @lubos: Alexander is good with scripts, so as a starter he wanted to do something like "http://cgit

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

Hi Eike, On Fri, 2012-01-27 at 00:03 +0100, Eike Rathke wrote: > Maybe worth a thought. So, I took a second look at this, and came up with the attached version which I think is better and more correct than the first one. This one will correctly honor the delete note flag, and also maintains the

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

On Fri, 2012-01-27 at 00:03 +0100, Eike Rathke wrote: > Further down the pOldCell->ReleaseBroadcaster() and pOldCell->Delete() > would only have to be executed if (pOldCell != pNoteCell) > > Maybe worth a thought. Yeah. This method is one of those convoluted "catch all in one place" type of meth

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

On Fri, 2012-01-27 at 00:23 +0100, Eike Rathke wrote: > Hi Kohei, > > On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote: > > > > Then the second part is in ScDPOutput::Output(), where the old content > > > gets removed before writing out a new one. The thing is, this method > > > only gets

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

Hi Kohei, On Friday, 2012-01-27 00:03:29 +0100, Eike Rathke wrote: > > Then the second part is in ScDPOutput::Output(), where the old content > > gets removed before writing out a new one. The thing is, this method > > only gets called from ScDPObject::Output(), and that method already > > delet

[Libreoffice] problems with encryption if thunderbird is installed

Hey, I have been debugging the problem Laurent mentioned lately that opening a password encrypted library causes Libreoffice to need a lot of cpu time even after loading finished. During my investigation I now found two some interesting points: - the bug does not happen if you don't have thunderb

Re: [Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

Hi Kohei, On Thursday, 2012-01-26 16:03:56 -0500, Kohei Yoshida wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=af70bc00c6714eb8695babdf5af07416552f7034 > > cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a > safe change. > > The change consists of two parts.

[Libreoffice] [ANN] LibreOffice 3.5.0 RC2 available

Dear Community, The Document Foundation is happy to announce the second release candidate of LibreOffice 3.5.0. The upcoming 3.5 will be our third major release line, packed with many exciting new features. Please be aware that LibreOffice 3.5.0 RC2 is not ready for production use, you should cont

Re: [Libreoffice] LibreOffice / openIndiana ...

On Thu, Jan 26, 2012 at 3:55 PM, Gary wrote: > On Thu, Jan 26, 2012 at 12:11 PM, Norbert Thiebaud wrote: >> I mentionned earlier GNUMAKE is always set by configure.in > > Yeah, I had it set there but it was being overridden by one entry in > unitools.mk as you suggested. > > So now it's failing in

Re: [Libreoffice] minutes of ESC call ...

Hi , Michael Meeks wrote (26-01-12 18:30) + 3.5.0 status + [...] + no real blockers. + still plenty of annoying bugs + need to release-note lots of them. + but fixing rate is going well - thanks a lot ! * QA update (Rainer)

Re: [Libreoffice] LibreOffice / openIndiana ...

On Thu, Jan 26, 2012 at 12:11 PM, Norbert Thiebaud wrote: > I mentionned earlier GNUMAKE is always set by configure.in Yeah, I had it set there but it was being overridden by one entry in unitools.mk as you suggested. So now it's failing in these four modules: --- ERROR: error 65280 occurred whi

Re: [Libreoffice] [PUSHED 3-5][REVIEW-3-5-0] Danish dictionary 2.0

Hi, On Thursday, 2012-01-26 15:45:15 +, Caolán McNamara wrote: > On Thu, 2012-01-26 at 13:52 +0100, Andras Timar wrote: > > Please review and cherry-pick to libreoffice-3-5-0 > > Pushed to 3-5 now, need another ack for 3.5.0 I presume. Ack'ed by me. Another one needed. And no, I didn't che

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

Hi, On Thursday, 2012-01-26 20:20:14 +0100, Eike Rathke wrote: > It looks like it would be an improvement also for Calc if after both > attributes were read set LineWidth to the sum of outer,inner,space to > cope with omitted/different fo:border width. > > However, there seem(s) to be some place

[Libreoffice] [REVIEW] Revert of UNO interface publishing

Michael Meeks wrote: > AA: + do the easiest roll-back possible to cleanup the > canvas publishing issue in 3.5.0 (Thorsten) > Went for reverting the whole thing, since there were some interdependencies (stuff being published elsewhere, using css::rendering interfaces, which then transiti

Re: [Libreoffice] Libreoffice On OPENINDIANA

On 26/01/12 16:46, Paolo Marcheschi wrote: > If you want to run the smoketest, issue: > make check > > but I had no luck, when i do a make, I receive the following error: > > make: Fatal error in reader: Makefile, line 35: Unexpected end of line seen > Current working directory /mnt/1TBDisk/Do

Re: [Libreoffice] [PUSHED-3-4][PUSHED[3-5][REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Thu, 2012-01-26 at 18:58 +0100, Christophe Strobbe wrote: > If there are differences between the zh-hk, zh-mo > and zh-tw localisations, is this due to different > translators or to differences between computing > terminology in these three geographic areas? Generally we basically lack a co

[Libreoffice] [REVIEW][3-5][3-5-0] Fix for formula reference chain breakage during pivot table update

Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=af70bc00c6714eb8695babdf5af07416552f7034 cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a safe change. The change consists of two parts. The real bug is in the first part (ScColumn::DeleteRan

Re: [Libreoffice] Libreoffice On OPENINDIANA

Hi Paolo, On Thursday, 2012-01-26 16:46:07 +0100, Paolo Marcheschi wrote: > I'm new to this list and I would like to contribute to the compilation for > Openindiana OS. > [...] > I obtain: Please see the thread with subject "LibreOffice / openIndiana ..." that started yesterday. Message-ID: <13

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

Hi Michael, On Wednesday, 2012-01-25 20:09:44 +, Michael Meeks wrote: > "can we find these sequence of bytes: 0x13 0x67 0xfe 0x78" > > if so it must be the foo virus ! ;-) Nah, it's the DC3-g-thorn-x virus ;-) Eike -- LibreOffice Calc developer. Number formatter stricken i1

[Libreoffice] Libreoffice On OPENINDIANA

Hi I'm new to this list and I would like to contribute to the compilation for Openindiana OS. I downloaded the source from git repos: git clone git://anongit.freedesktop.org/libreoffice/core OIOO I started the autogen.sh in this way : ./configure --without-junit --enable-python=internal --wi

Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

Hi Christina, Nice find. Just to mention that this > +SAL_DLLPRIVATE Color ImplDrawModeToColor( Color ); > +Color OutputDevice::ImplDrawModeToColor( const Color rColor ) not only should be a const method as Stephan mentioned, but also should get passed a const Color& rColor reference ins

Re: [Libreoffice] [REVIEW 3-5-0] Updated License document

On Thu, Jan 26, 2012 at 6:27 AM, Andras Timar wrote: > Hi, > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2961f3fff10ea1254a082ad6d0a72bff740d66e > I updated LICENSE.odt and generated THIRDPARTYLICENSEREADME.html and > license.txt from it. Unfortunately the diff is not clean, I could

Re: [Libreoffice] LibreOffice / openIndiana ...

/usr/bin/bash: /usr/sfw/bin/make: No such file or directory you want to remove GNUMAKE=/usr/sfw/bin/make from solenv/inc/unitools.mk or at the very least replace = by *= as I mentionned earlier GNUMAKE is always set by configure.in Norbert ___ LibreOff

Re: [Libreoffice] Changing list setup to not add to subject

Hi, On Wednesday, 2012-01-25 15:33:13 -0500, Kohei Yoshida wrote: > On Wed, 2012-01-25 at 14:05 -0600, Norbert Thiebaud wrote: > > I don't mind the removal of [LibreOffice], but I mind messing with the > > reply-to > > Same here. Same for me. But, I know that unfortunately there are uncapable

Re: [Libreoffice] [PUSHED 3-5-0][REVIEW] solenv: handle error code from ./g

Hi, On Thursday, 2012-01-26 17:57:29 +0100, Petr Mladek wrote: > Caolán McNamara píše v Čt 26. 01. 2012 v 16:49 +: > > On Thu, 2012-01-26 at 17:40 +0100, Miklos Vajna wrote: > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=439e5279c5d334f849a6ab7b51bad1bb12f13aae > > pushed to 3-

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

Hi Michael, On Thursday, 2012-01-26 18:21:16 +0100, Michael Stahl wrote: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e > > Resolves https://bugs.freedesktop.org/show_bug.cgi?id=38595 > > ooh, Calc also has this kind of problem :) Yup.. > y

Re: [Libreoffice] LibreOffice / openIndiana ...

On Thu, Jan 26, 2012 at 12:03 PM, Stephan Bergmann wrote: > On 01/26/2012 06:55 PM, Michael Meeks wrote: >> >> On Thu, 2012-01-26 at 16:52 +, Jonathan Adams wrote: >>> >>> I'm coming to the conclusion that the system doesn't believe I'm using >>> GCC ... nss keeps trying to build with "-KPIC",

Re: [Libreoffice] LibreOffice / openIndiana ...

On 01/26/2012 06:55 PM, Michael Meeks wrote: On Thu, 2012-01-26 at 16:52 +, Jonathan Adams wrote: I'm coming to the conclusion that the system doesn't believe I'm using GCC ... nss keeps trying to build with "-KPIC", rather than "-fPIC" ... any suggestions and I'll eagerly try them :)

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

On 26/01/12 19:30, Michael Stahl wrote: > On 26/01/12 16:21, Cedric Bosdonnat wrote: >> Hi all, >> >> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and >> -3-4? >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 > > your fix looks

Re: [Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

On 26/01/12 16:21, Cedric Bosdonnat wrote: > Hi all, > > Could someone review and cherry-pick this commit to -3-5, -3-5-0 and > -3-4? > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 your fix looks good to me, except for the line: sal_uInt16 nM

[Libreoffice] CREDITS.odt, http://www.libreoffice.org/about-us/credits/

Hi, readlicense_oo/odt/CREDITS.odt is rather outdated. I would like to update it before 3.5.0. But http://www.libreoffice.org/about-us/credits/ is not so fresh, too. Would it be possible to update it in the next days? Thanks, Andras ___ LibreOffice mail

Re: [Libreoffice] [PUSHED][REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken

Hi Cedric, On Thursday, 2012-01-26 17:27:08 +0100, Cedric Bosdonnat wrote: > The patch looks good to me. If you tested it with several files, it's ok > for me for 3.5.0. I just cherry-picked it in -3-5-0. Just adding [PUSHED] to subject as I was about to do the same.. Eike -- LibreOffice Ca

Re: [Libreoffice] [PUSHED-3-4][PUSHED[3-5][REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

At 17:59 26-1-2012, Andras Timar wrote: Hi Caolan, 2012/1/26 Caolán McNamara <caolanm at redhat.com>: > > We should in master generally shrink the rest of the tags down to the > minimum correct lang-tag , e.g. hu-HU to hu, but zh-CN

Re: [Libreoffice] LibreOffice / openIndiana ...

Hi Jonathan, On Thu, 2012-01-26 at 16:14 +, Jonathan Adams wrote: > beginning to get somewhere with GCC ... gonna update the list of changes so > far: Great :-) if you do a: 'git diff' and just send the patch with some nice license is: MPL/LGPLv3+ statement, we can

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

On Thu, 2012-01-26 at 14:20 +0100, Eike Rathke wrote: > Hi, > > please review and cherry-pick to 3-5, 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e > > Resolves https://bugs.freedesktop.org/show_bug.cgi?id=38595 This, I would be

[Libreoffice] [PUSHED] Code cleanup: ( () ) replaced by (())

Hi Alex, On Thu, 2012-01-26 at 16:00 +0100, Alexander Bergmann wrote: > --- > bridges/inc/bridges/cpp_uno/bridge.hxx | 48 +- > OSL_TRACE( "ModuleImport::~ModuleImport()." ); Thanks for that :-) it looks rather less contorted. As Lubos says it's probably rather

Re: [Libreoffice] [REVIEWED][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

On Thu, 2012-01-26 at 12:44 -0500, Kohei Yoshida wrote: > me three! I'll push it to the -3-5-0 branch in a minute. Pushed to the -3-5-0 branch. Kohei P.S. Sorry I forgot to add the sign-off lines in the commit message. -- Kohei Yoshida, LibreOffice hacker, Calc __

Re: [Libreoffice] [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

On Thu, 2012-01-26 at 16:15 +0100, Michael Stahl wrote: > On 26/01/12 15:56, Michael Meeks wrote: > > > > On Thu, 2012-01-26 at 14:45 +0100, Eike Rathke wrote: > >> Please review and cherry-pick to 3-5, 3.5.0 and 3-4 > >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f27

[Libreoffice] minutes of ESC call ...

* Present: + Kendy, Norbert, Stephan, Thorsten, Mitch, Fridrich, Andras, Markus, Petr, Caolan, David, Kohei, Eike, Lionel, Rainer * Completed Actions + hack up the Help->File bug menu item (Ivan) + reviewed & will be in 3.5.1 + poke websi

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

On 26/01/12 14:20, Eike Rathke wrote: > Hi, > > please review and cherry-pick to 3-5, 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e > > Resolves https://bugs.freedesktop.org/show_bug.cgi?id=38595 ooh, Calc also has this kind of p

Re: [Libreoffice] [LibreOffice] [39428] Remove SvStream operator>>/<

Given that these are almost exclusively called with , I would simply un-template'ize the functions, substituting sal_uInt16 for prefix. > > For instantiations with prefix != sal_uInt16, I count four uses of > read_lenPrefixed_uInt8s_ToOString, two of > read_lenPrefixed_uInt8s_ToOUString, and one us

Re: [Libreoffice] [ANNOUNCE] Branch libreoffice-3-5-0 created

On 01/24/2012 09:11 PM, Petr Mladek wrote: there have been created the libreoffice-3-5-0 branch. It will be used for fine tuning of the 3.5.0 release. It is based on the tag libreoffice-3.5.0.2 for 3.5.0-rc2 release. The following rules apply: + only cherry-picking from libreoffice-3-5

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

[ just 'reply' for the cc's ] Stefan Knorr (Astron) wrote (26-01-12 14:16) Hi, I just checked, and must say that I can only second Cor and Drew in that it is too quick now. Could we go back to 1.1 or maybe 2^(1/8)=1.0905 (that should deliver a similar effect as 2^(1/4), no? – I am bad at maths,

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

[ just 'reply' for the cc's ] drew wrote (26-01-12 08:36) On Thu, 2012-01-26 at 08:21 +0100, Jan Holesovsky wrote: Hi Cor, On 2012-01-26 at 00:16 +0100, Cor Nouws wrote: Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better here, the 1.1 means way too much wheel rotation to inc

Re: [Libreoffice] [PUSHED-3-4][PUSHED[3-5][REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Thu, 2012-01-26 at 17:59 +0100, Andras Timar wrote: > In fact hu-HU – and other European languages with country code – seem > to be unnecessary there. They have not been working under Windows for > ages (or ever), yet nobody complained. :) Some of them look identical > to English node. I think

Re: [Libreoffice] LibreOffice / openIndiana ...

On 01/26/2012 05:56 PM, Caolán McNamara wrote: I see that there *is* one for solaris sparc and gcc (I had to blink a few times when I saw that there was one), i.e. bridges/source/cpp_uno/gcc3_solaris_sparc so you might be incredibly lucky and that's actually buildable and works fine. There's al

Re: [Libreoffice] [PUSHED-3-4][PUSHED[3-5][REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

Hi Caolan, 2012/1/26 Caolán McNamara : > > We should in master generally shrink the rest of the tags down to the > minimum correct lang-tag , e.g. hu-HU to hu, but zh-CN remains as zh-CN. > And I'm confident that the zh-CN/zh-TW/pa-IN font entries currently > should work for the windows UI fallbac

Re: [Libreoffice] [PUSHED 3-5][REVIEW] solenv: handle error code from ./g

Caolán McNamara píše v Čt 26. 01. 2012 v 16:49 +: > On Thu, 2012-01-26 at 17:40 +0100, Miklos Vajna wrote: > > Hi packagers, > > > > See > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=439e5279c5d334f849a6ab7b51bad1bb12f13aae > > > > Could you sign-off and push to -3-5 (and possib

Re: [Libreoffice] LibreOffice / openIndiana ...

On Thu, 2012-01-26 at 16:14 +, Jonathan Adams wrote: > It's further than it has been up until this point, 1/4 of the way > around the nice animated status indicator ... At some stage you'll need (the dreaded) uno-bridge[1], first symptom of not having one or a broken one would be a build error

Re: [Libreoffice] LibreOffice / openIndiana ...

On 26/01/12 17:42, Norbert Thiebaud wrote: > On Thu, Jan 26, 2012 at 10:14 AM, Jonathan Adams > wrote: good to hear you're making some progress there :) >> files soltools/adjustvisibility/makefile.mk >> soltools/mkdepend/makefile.mk soltools/util/makefile.pmk: (probably >> not safe if SunStudio

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source "fix rendering of metafiles embedded in emf+"

On Thursday 26 of January 2012, Radek Doulik wrote: > Hi Stephan, > > I am unable to reproduce it here. Do you have some other way to > reproduce it other then make check? > > I am attaching updated patch with fixed loop. Please could you try it? I can't say about Stephan's problem, but your chan

Re: [Libreoffice] LibreOffice / openIndiana ...

I'm coming to the conclusion that the system doesn't believe I'm using GCC ... nss keeps trying to build with "-KPIC", rather than "-fPIC" ... any suggestions and I'll eagerly try them :) On 26 January 2012 16:42, Norbert Thiebaud wrote: > On Thu, Jan 26, 2012 at 10:14 AM, Jonathan Adams > wrot

[Libreoffice] [PUSHED 3-5][REVIEW] solenv: handle error code from ./g

On Thu, 2012-01-26 at 17:40 +0100, Miklos Vajna wrote: > Hi packagers, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=439e5279c5d334f849a6ab7b51bad1bb12f13aae > > Could you sign-off and push to -3-5 (and possibly -3-5-0), please? pushed to 3-5 with conflict fix-up as http://cg

Re: [Libreoffice] LibreOffice / openIndiana ...

On Thu, Jan 26, 2012 at 10:14 AM, Jonathan Adams wrote: > file ./solenv/inc/unitools.mk: (this one should be safe for all > platforms, since it only affects Solaris, and Solaris 10 has the file > in this location) > GNUMAKE=/usr/sfw/bin/gmake That should really be handled in configure.in, and no

[Libreoffice] [REVIEW] solenv: handle error code from ./g

Hi packagers, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=439e5279c5d334f849a6ab7b51bad1bb12f13aae Could you sign-off and push to -3-5 (and possibly -3-5-0), please? Thanks, Miklos pgpCs4JeG7qch.pgp Description: PGP signature ___ Lib

[Libreoffice] [PUSHED][PATCH] Removing unused code

On Thu, 2012-01-26 at 16:38 +, Caolán McNamara wrote: > On Thu, 2012-01-19 at 13:13 +0100, Alexander Bergmann wrote: > > --- > > .../inc/basegfx/polygon/b2dpolygoncutandtouch.hxx | 10 -- > > basegfx/source/polygon/b2dpolygoncutandtouch.cxx | 112 > > > > unusedcode

Re: [Libreoffice] [PATCH] Removing unused code

On Thu, 2012-01-19 at 13:13 +0100, Alexander Bergmann wrote: > --- > .../inc/basegfx/polygon/b2dpolygoncutandtouch.hxx | 10 -- > basegfx/source/polygon/b2dpolygoncutandtouch.cxx | 112 > > unusedcode.easy|4 - > 3 files changed,

Re: [Libreoffice] [REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken

On Thu, Jan 26, 2012 at 02:40:18PM +0100, Fridrich Strba wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 > fixes a bug where the catch-all type detector was called first in > the list of type detectors when an extension-less document was >

Re: [Libreoffice] [REVIEWED 3-5, 3-5-0] The type-detection of extension-less documents is broken

Hello Fridrich, On Thu, 2012-01-26 at 14:40 +0100, Fridrich Strba wrote: > This patch: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 > > fixes a bug where the catch-all type detector was called first in the > list of type detectors when an

[Libreoffice] [PUSHED][PATCH] Removing unused code

On Thu, 2012-01-19 at 13:19 +0100, Alexander Bergmann wrote: > --- > basegfx/inc/basegfx/polygon/b2dpolygonclipper.hxx |7 -- > basegfx/inc/basegfx/polygon/b3dpolygonclipper.hxx | 14 --- > basegfx/source/polygon/b2dpolygonclipper.cxx | 66 - > basegfx/source/polygon/b3dpo

Re: [Libreoffice] LibreOffice / openIndiana ...

beginning to get somewhere with GCC ... gonna update the list of changes so far: file ./configure.in: (this one should be safe for all platforms) grep -q => \$GREP -q file ./solenv/inc/unitools.mk: (this one should be safe for all platforms, since it only affects Solaris, and Solaris 10 has the f

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45042 --- Comment #150 from Petr Mladek 2

Re: [Libreoffice] [PATCH] Code cleanup: ( () ) replaced by (())

On Thursday 26 of January 2012, Alexander Bergmann wrote: > -RTTI() SAL_THROW( () ); > -~RTTI() SAL_THROW( () ); > +RTTI() SAL_THROW(()); > +~RTTI() SAL_THROW(()); What is the reason for changes like this? This looks like just a stylistic change that's entirely a matter of taste

[Libreoffice] [PUSHED 3-5][REVIEW-3-5-0] Danish dictionary 2.0

On Thu, 2012-01-26 at 13:52 +0100, Andras Timar wrote: > Please review and cherry-pick to libreoffice-3-5-0 Pushed to 3-5 now, need another ack for 3.5.0 I presume. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

[Libreoffice] [PUSHED-3-4][PUSHED[3-5][REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Thu, 2012-01-26 at 14:33 +0100, Andras Timar wrote: > I still don't understand what's happening, i.e. in good case it reads > UI_SANS list for "hi" once, then several time for "en", and it looks > good, and in bad case it reads UI_SANS list for hi_IN several times > and still, we get corrupted c

Re: [Libreoffice] Adabas still being built in master ?

Just for information adabas is present at these locations : - connectivity/prj/d.lst - core/Repository.mk - dbaccess/Module_dbaccess.mk Hope it may help. Julien. -- View this message in context: http://nabble.documentfoundation.org/Adabas-still-being-built-in-master-tp3690462p3690708.html Sent

[Libreoffice] [REVIEW]Fix for annoying bug fdo#35669

Hi all, Could someone review and cherry-pick this commit to -3-5, -3-5-0 and -3-4? http://cgit.freedesktop.org/libreoffice/core/commit/?id=5e51960dede5015b862df05b7b16f02884647889 Thanks, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freede

Re: [Libreoffice] [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

On 26/01/12 15:56, Michael Meeks wrote: > > On Thu, 2012-01-26 at 14:45 +0100, Eike Rathke wrote: >> Please review and cherry-pick to 3-5, 3.5.0 and 3-4 >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f271217663718b3d6681bd9 > > looks good to me for -3-5 and -3-5

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35669, which changed state. Bug 35669 Summary: Incorrect cross-references to illustrations and equations in master documents https://bugs.freedesktop.org/show_bug.cgi?id=35669 What|Old Value

Re: [Libreoffice] Adabas still being built in master ?

Le 26/01/2012 15:57, Michael Meeks a écrit : Hi Michael, Hah :-) I believe we should have expunged that code thoroughly from master too, perhaps Lionel knows more about: The code was kept in at my request as a teaching example for future developers who might want to develop a driver

Re: [Libreoffice] [REVIEWED][REVIEW 3-5, 3-5-0] The type-detection of extension-less documents is broken

On Thu, 2012-01-26 at 14:46 +, Caolán McNamara wrote: > Pushed to 3-5 anyway. FWIW I put the original sort code in, my intent > was to try the "known to claim to open everything" typedetector last and > everything else first. Ah ! makes perfect sense. So one more review for -3-5-0 I

Re: [Libreoffice] Adabas still being built in master ?

On Thu, 2012-01-26 at 14:41 +0100, Alex Thurgood wrote: > Perhaps I misunderstood what François' commits were supposed to do, but > I thought that the Adabas db stuff had been pulled out of the > compilation sequence. However, I keep seeing this in my build (and I've > not activated any sort of

Re: [Libreoffice] [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

On Thu, 2012-01-26 at 14:45 +0100, Eike Rathke wrote: > Please review and cherry-pick to 3-5, 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f271217663718b3d6681bd9 looks good to me for -3-5 and -3-5-0. Thanks ! Michael.

Re: [Libreoffice] [REVIEW][3.5.0][3-5][3-4] fdo#38595 Calc cell borders lost in ODF import

On Thu, 2012-01-26 at 14:20 +0100, Eike Rathke wrote: > please review and cherry-pick to 3-5, 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e Picked to -3-5 :-) couple? more reviews for -3-5-0 needed. Thanks,

[Libreoffice] [REVIEWED][REVIEW 3-5, 3-5-0] The type-detection of extension-less documents is broken

On Thu, 2012-01-26 at 14:27 +, Michael Meeks wrote: > On Thu, 2012-01-26 at 14:40 +0100, Fridrich Strba wrote: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 > > > > fixes a bug where the catch-all type detector was called first in the > >

Re: [Libreoffice] PDF converter cross compilation general questions

Hi Andrzej, Il 26/01/2012 15:01, andrzej.pacanow...@tieto.com ha scritto: Hi guys, I've been investigating a possibility of LibreOffice cross-compilation for Linux X-less device(ARM) and use it as document(writer/calc/impress) to pdf converter. i'd like to do more or less the same :) 1)

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

On 26/01/12 15:27, Michael Meeks wrote: Gosh; I'd rather like to know why the explicit code to sort it to the front was there in the first instance. The code was there because that detector is catch-all it will in a certain branch simply not allow anything to be detected any more, so w

Re: [Libreoffice] [REVIEW][PUSHED:3-5-0] fdo#43869 use the old rtf importer for paste

Lubos Lunak píše v Čt 26. 01. 2012 v 14:30 +0100: > On Thursday 26 of January 2012, Cedric Bosdonnat wrote: > > Hi Miklos, > > > > On Wed, 2012-01-25 at 16:49 +0100, Miklos Vajna wrote: > > > See > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb147bbb801b53dba > > >8928340df7e2aa2d45

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

On Thu, 2012-01-26 at 14:40 +0100, Fridrich Strba wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 > > fixes a bug where the catch-all type detector was called first in the > list of type detectors when an extension-less document was passe

[Libreoffice] PDF converter cross compilation general questions

Hi guys, I've been investigating a possibility of LibreOffice cross-compilation for Linux X-less device(ARM) and use it as document(writer/calc/impress) to pdf converter. 1) Is it possible to compile LO without any graphic library (pure -headless)? Or how much work would that require?

Re: [Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

On 26/01/12 14:40, Fridrich Strba wrote: Please, gather enough support for both 3-4 and 3-5-0 branches My bad, the affected code is not in the 3-4 branch and adding it there would be much more intrusive. Cheers F. ___ LibreOffice mailing list Libr

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45254 --- Comment #149 from Petr Mladek 2

[Libreoffice] [REVIEW][3-5][3.5.0][3-4] invalid cast from BoderLine to BorderLine2

Hi, Please review and cherry-pick to 3-5, 3.5.0 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=97c66b3b13528cc50f271217663718b3d6681bd9 Fixes an invalid cast that caused an arbitrary memory access. Thanks Eike -- LibreOffice Calc developer. Number formatter stricken i18n tra

Re: [Libreoffice] [LibreOffice] [39428] Remove SvStream operator>>/<

On 01/26/2012 12:40 PM, Keith McRae wrote: I've removed all the operator>>/<< from SvStream and replaced with Read/Write[sal_type] functions. Great. While fixing up the references I noticed the template'd functions below: template rtl::OString read_lenPrefixed_uInt8s_ToOString(SvStream& rStr

Re: [Libreoffice] Wrong cast to css.table.BorderLine2

Hi, On Wednesday, 2012-01-25 16:33:28 +0100, Eike Rathke wrote: > On Wednesday, 2012-01-25 11:17:54 +0100, Stephan Bergmann wrote: > > On 01/25/2012 09:48 AM, Cedric Bosdonnat wrote: > > >Hum, I'll have a look at that... but my problem with BorderLine and > > >BorderLine2 is that the second one sh

[Libreoffice] Adabas still being built in master ?

Hi, Perhaps I misunderstood what François' commits were supposed to do, but I thought that the Adabas db stuff had been pulled out of the compilation sequence. However, I keep seeing this in my build (and I've not activated any sort of Adabas db switch that I know of) : [ build CXX ] dbacc

[Libreoffice] [REVIEW 3-5, 3-5-0, 3-4] The type-detection of extension-less documents is broken

Hello, This patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=0d9aa8cce792d69d5147a2230b61b1cbdc089206 fixes a bug where the catch-all type detector was called first in the list of type detectors when an extension-less document was passed. This caused quite a number of macintosh

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012/1/25 Caolán McNamara : > On Wed, 2012-01-25 at 16:44 +0100, Andras Timar wrote: >> Result on Windows is confusing. My test language was Hindi (hi). >> >> Case 1 - without the patch in officecfg >> ... >> default-font entry for "hi" "IN" "" added > ... >> searching for a node for "hi" "" "" for

Re: [Libreoffice] [REVIEW] fdo#43869 use the old rtf importer for paste

On Thursday 26 of January 2012, Cedric Bosdonnat wrote: > Hi Miklos, > > On Wed, 2012-01-25 at 16:49 +0100, Miklos Vajna wrote: > > See > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb147bbb801b53dba > >8928340df7e2aa2d4545349 > > > > Could somebody sign-off and push to -3-5, please?

Re: [Libreoffice] [REVIEW] fdo#43869 use the old rtf importer for paste

Hi Miklos, On Wed, 2012-01-25 at 16:49 +0100, Miklos Vajna wrote: > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb147bbb801b53dba8928340df7e2aa2d4545349 > > Could somebody sign-off and push to -3-5, please? I cherry-picked it to -3-5, but it would be good to have 2 more reviews

  1   2   >