Hi there, I'd like to have
http://cgit.freedesktop.org/libreoffice/core/commit/?id=af70bc00c6714eb8695babdf5af07416552f7034 cherry-picked to 3-5 and preferably to 3-5-0 as well. IMO this is a safe change. The change consists of two parts. The real bug is in the first part (ScColumn::DeleteRange), where a note cell with live broadcaster would silently get deleted, hence losing link to its listeners. Then the second part is in ScDPOutput::Output(), where the old content gets removed before writing out a new one. The thing is, this method only gets called from ScDPObject::Output(), and that method already deletes the old content which makes the removal code in ScDPOutput unnecessary. So, when updating or refreshing the pivot table output, calc was essentially deleting the range twice. This, plus the first bug combined caused the reference chain to break, whose effected is described in https://bugs.freedesktop.org/show_bug.cgi?id=44143 The second part is optional as long as we put the first part. But it's just redundant and it's good to have it removed for cleanliness' sake. Having said that, if someone is not so sure, we can just put the first part in for 3.5. Reviews and sign-off's appreciated. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
