Re: [Libreoffice] [PATCH] patch for fdo 34425 and translated german comments in, tbcontrl.hxx

>Some nitpicking: isEmpty() seems to be accidentally replaced with >getLength(). I noticed this too, it probably crossed a patch from someone else. >@Winfried: Thanks a lot for the patch. Its really cool (at least for me >:) ). In the meanwhile, it would be really great if you could pick more >suc

Re: [Libreoffice] [PATCH] Reduced duplicate code detected by simian

On 01/24/2012 10:32 PM, Christina Roßmanith wrote: Could someone please review it? It builds successfully but I'm unsure about where to use "const"... In short, marking a member function const can (and should) be done whenever the function does not modify its object, and does not itself call

Re: [Libreoffice] [Libreoffice-commits] .: vcl/android "WaE: unused parameter 'nType'"

On 01/25/2012 12:15 AM, Tor Lillqvist wrote: WaE: unused parameter 'nType' diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx index 91971e6..08c01ae 100644 --- a/vcl/android/androidinst.cxx +++ b/vcl/android/androidinst.cxx @@ -68,6 +68,7 @@ void AndroidSalInstance::DoRe

Re: [Libreoffice] [Pushed] [PATCH] Reduced duplicate code detected by simian

Pushed. Thank you for the patch! Looking for more... :) On 01/25/2012 03:02 AM, Christina Roßmanith wrote: > Reduced duplicate code detected by simian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/li

Re: [Libreoffice] [PATCH] patch for fdo 34425 and translated german comments in, tbcontrl.hxx

Hello, I did some initial review of the patch. It works really nicely. It would be great if somebody more knowledgeable in this area confirm and push - thanks a lot! Some nitpicking: isEmpty() seems to be accidentally replaced with getLength(). @Winfried: Thanks a lot for the patch. Its really c

Re: [Libreoffice] [Pushed] [PATCH] Removing unused code

Marking the two unused code removal patches in basegfx as pushed. Thank you for the contributions :) And Of course, looking forward for more! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libr

Re: [Libreoffice] Delphi and UNO Remote Protocol

Hi, I've made a Delphi pure IP URP client, but still have a problem when connecting to a local host you can see a demo application there http://www.execute-info.com/RemoteOfficeDemo.zip it work fine on a remote host, but the first instance of the application freeze for a local host (but a se

[Libreoffice] Delphi and UNO Remote Protocol

Hi, I am trying to write a app in Lazarus or Delphi that can convert documents to PDF, I have had some success with COM in Delphi, but the COM implemenation in Lazarus/FPC is incomplete and fails. I then saw that Libre Office can be started in a server mode and clients can communicate via IP to ba

Re: [Libreoffice] [REVIEW-3-5] send-feedback patch (was: Re: minutes of ESC call ...)

> Let's push this to -3-5 after the 3.5.0 branch-off. > That would be now - Stefan, Caolan, this is a late, but IMO very useful feature (for 3.5.1, I suggest), and needs two more approvals from differently affiliated people. TIA, -- Thorsten pgpCIqFQy7AgO.pgp Description: PGP signature ___

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

Hi all, Pedro wrote (10-01-12 18:57) Michael Meeks-2 wrote OTH more releases means more features but also more bugs. And because new bugs occur, old bugs are left behind. Oh ! so - this is an argument for doing a build every decade ;-) Not really. It's just an argument that if rel

[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping, take 2

Hi there, I've found a better way to fix it. Attached is tailored specifically for the 3-5 branch. I'll port this fix to master separately since master has my earlier commit that would make this patch not apply without adjusting. Again, this fixes https://bugs.freedesktop.org/show_bug.cgi?id=4

[Libreoffice] [PATCH] Reduced duplicate code detected by simian

Hi, after replacing string data types I looked for duplicated code in vcl with simian. Could someone please review it? It builds successfully but I'm unsure about where to use "const"... Thank you, Christina >From 94b9a014e07133fef3f7432d4d6945cd76e66d4d Mon Sep 17 00:00:00 2001 From: Christi

Re: [Libreoffice] Changing list setup to not add to subject

Lubos Lunak wrote: > could this mailing list's configuration be changed to not add the pointless > [Libreoffice] to the beginning? > Yes. > - one would hope that by 2012 everybody interested in filtering mail can > actually do it based on the List-Id header, which has the additional benefit

Re: [Libreoffice] [POLL] Find a date for the next LibreOffice hackfest

> [...] first of all, we need to find a date that suits as many > people as possible: > > http://moreganize.com/btJzN0BYZw7 > Reminder - I'll close the poll in the next few hours, if you haven't voted yet, please do so now. Cheers, -- Thorsten pgpeSloOZZtOj.pgp Description: PGP signature ___

Re: [Libreoffice] File not found: cairocanvas.uno.so in smoketestoo_native

Hi Michael, Il 24/01/2012 12:49, Michael Meeks ha scritto: Hi Riccardo, On Tue, 2012-01-24 at 12:26 +0100, Riccardo Magliocchetti wrote: with this configuration (note --disable-cairo-canvas is set) /autogen.sh --without-junit --without-java --disable-epm --disable-gtk ... --disable-cairo-ca

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source "fix rendering of metafiles embedded in emf+"

Radek, bisecting showed me that it is this commit that causes my machine to become unresponsive (as the involved soffice.bin process keeps growing in size, apparently without limit) when executing the forms_unoapi test (during "make check") -- and it is also most likely this commit that cause

Re: [Libreoffice] Changing list setup to not add to subject

On Tue, 2012-01-24 at 16:26 +0100, Lubos Lunak wrote: > could this mailing list's configuration be changed to not add the pointless > [Libreoffice] to the beginning? I'd be up for that, in the absence of any violent objections / industrial-scale bike-shed construction, lets make a decis

Re: [Libreoffice] Storage of user's configuration

On 01/24/2012 04:22 PM, Martin Richard wrote: I'm hacking the cross-platform filepicker (in fpicker/source/office). I added a "Places" (bookmarks) list on the left and I would like to save the entries that the user bookmarked . Cedric Bosdonnat told me to look at xcu and xcs files, but I'm a bit

[Libreoffice] [ANNOUNCE] Branch libreoffice-3-5-0 created

Hi all, there have been created the libreoffice-3-5-0 branch. It will be used for fine tuning of the 3.5.0 release. It is based on the tag libreoffice-3.5.0.2 for 3.5.0-rc2 release. The following rules apply: + preferably just translation or blocker fixes + only cherry-picking fr

Re: [Libreoffice] Changing list setup to not add to subject

While at it, it would be nice to also set Reply-To: libreoffice@lists.freedesktop.org. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANNOUNCE] libreoffice-3.5.0.2 tag created (3.5.0-rc2)

Hi, there have been created the libreoffice-3.5.0.2 tag for 3.5.0-rc2 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.5.0-rc1. I am going to create the libreoffice-3-5-0 branch for the final stabilization. See also

Re: [Libreoffice] LO and address book wizard

On 23/01/2012 22:30, Caolán McNamara wrote: On Mon, 2011-11-21 at 11:39 -0500, Arno Teigseth wrote: Hi Anyone else having trouble with adding address books to Libreoffice (File->Wizard->Address book). I'm getting "SDBC error" on my system, _git master LO_ on linux mint 11. Have both thunderbir

Re: [Libreoffice] sal / unit tests ...

On 24 January 2012 13:34, Michael Meeks wrote: >        Cool ! thanks for that :-) Of course, unfortunately still most of the > tests are not run because of the missing: > >    CPPUNIT_REGISTRY_ADD_TO_DEFAULT( "osl_File" ); > >        But I guess this needs doing on a branch and then testing per p

Re: [Libreoffice] Storage of user's configuration

Martin, I supose it is already cross platform and environment independent, neve tested it but interesting to know. Hi Fernand, Thank you for your response, it may help indeed. It seems that you create your own xcs file from scratch and store it in a custom location. I think that in my cas

Re: [Libreoffice] Storage of user's configuration

Hi Martin, On Tue, 2012-01-24 at 16:22 +0100, Martin Richard wrote: > I'm hacking the cross-platform filepicker (in fpicker/source/office). > I added a "Places" (bookmarks) list on the left and I would like to > save the entries that the user bookmarked . Great. > Cedric Bosdonnat told m

Re: [Libreoffice] [REVIEWED] fdo#43932: try to fix paper tray settings

24.01.2012 15:56, David Tardon пишет: Oops, sorry... It seems it does not work: the tray setting is always reset to 'Auto' again. Oh, well then my patch is wrong. I'm sorry for my fallacy... No another idea on this bug, and no idea of testing patches without a multitray printer, I'll reset as

[Libreoffice] bootstrap repos (was: Re: Problem with clipboard paste in 3.5)

On 24/01/12 17:19, Korrawit Pruegsanusak wrote: > Hello Petr, > > On Mon, Jan 23, 2012 at 17:29, Petr Cisar wrote: >> I did some tests, I tried to put some debug printouts to file >> clone/libs-gui/dtrans/source/generic/clipboardmanager.cxx, but never seen >> one while running LO. is there som

Re: [Libreoffice] Storage of user's configuration

Hi Fernand, Thank you for your response, it may help indeed. It seems that you create your own xcs file from scratch and store it in a custom location. I think that in my case, I will need to find a way to make it cross platform and environment independent. Cheers 2012/1/24 Fernand Vanrie >

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

On Tue, Jan 24, 2012 at 06:15:09PM +0100, Lionel Elie Mamane wrote: > On Mon, Jan 23, 2012 at 04:16:55PM +0100, Lionel Elie Mamane wrote: >> On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: >>> * >>> "postgresql-sdbc doesn't wor

Re: [Libreoffice] Storage of user's configuration

Martin , i use folowed BASIC code to make a "path" consitent , maybe it helps ? public sElementnaam , sfotopath as string public oParameter as object sub addFotoPath() sRegisterPath = "/org.openoffice.OpmaakMacro.FotoPath/Parameters/" CreateRegistrySchemaPathIfNotPresent(sRegisterPath) aSettin

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

On Mon, Jan 23, 2012 at 04:16:55PM +0100, Lionel Elie Mamane wrote: > On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: >> * >> "postgresql-sdbc doesn't work on LO 3.5RC1 win32" >> *

Re: [Libreoffice] Database of areas for SAL_INFO etc.

On 01/24/2012 06:01 PM, Stephan Bergmann wrote: like log-documentation.txt ... or log-areas.txt ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Database of areas for SAL_INFO etc.

On 01/24/2012 04:40 PM, Lubos Lunak wrote: I intend to put just a short note to the documentation in sal/log.hxx pointing to this file (so that additions wouldn't trigger rebuilds), but I'm not sure where to put the file itself. I've been thinking sal/DEBUG , but that doesn't look very good to

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

Hi Korrawit, thanks for the information, I have attached a new patch and also 25% is enforced like Stefan requested. Regards Tim On Tuesday 24 January 2012 12:13:20 Korrawit Pruegsanusak wrote: > Hello Tim, > > Thanks for your patch. :-) > I didn't test it yet, but just my nitpick: could you p

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 fabien.mic...@hespul.org changed: What|Removed |Added Depends on||40907 -- Configure bugmail: h

Re: [Libreoffice] [Libreoffice-commits] .: officecfg/registry

On 01/24/2012 04:22 PM, Fridrich Strba wrote: officecfg/registry/data/org/openoffice/VCL.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 86bf32c487852f4e466b27320e3724266cb53dba Author: Fridrich Štrba Date: Tue Jan 24 16:22:15 2012 +0100 Fix build: dup

Re: [Libreoffice] Problem with clipboard paste in 3.5

Hello Petr, On Mon, Jan 23, 2012 at 17:29, Petr Cisar wrote: > I did some tests, I tried to put some debug printouts to file > clone/libs-gui/dtrans/source/generic/clipboardmanager.cxx, but never seen one > while running LO. You said clone/libs-gui/... ? IMHO you're using the old version of ou

Re: [Libreoffice] [REVIEWED][PUSHED][3-5] Fix for pivot table refresh problem

Kohei Yoshida píše v Út 24. 01. 2012 v 10:21 -0500: > On Tue, 2012-01-24 at 09:49 -0500, Kohei Yoshida wrote: > > > > It seems that your patch does not fix the problem in 3-5. I tested > > > with sc/qa/extras/testdocuments/ScDataPilotTableObj.ods similar and > > > changed B6 but refresh does not w

[Libreoffice] [PUSHED] Re: [REVIEW-3.5] Handling ordering problem when properties are set one by one

On 24/01/12 16:12, Lubos Lunak wrote: > On Tuesday 24 of January 2012, Michael Stahl wrote: >> On 23/01/12 21:31, Lubos Lunak wrote: >>> It seems to be quite a common way for LO code to use this >>> let's-push-all-the-data-as-properties-one-by-one approach, so I wonder >>> what the common way of

[Libreoffice] Database of areas for SAL_INFO etc.

Hello, as already discussed on IRC, I think it would be a good idea to have a list of debug areas written down somewhere. It is meant to be just a plain text file (so not used by code) and the reasoning is: - the area is just a text string and without a list we could end up with "sw.doc"

[Libreoffice] Changing list setup to not add to subject

Hello, could this mailing list's configuration be changed to not add the pointless [Libreoffice] to the beginning? - it leaves less room for the actually important part of the subject when browsing mail - which gets expecially insane when forwarding mails futher or between such mailing list

[Libreoffice] Storage of user's configuration

Hi everybody, I'm hacking the cross-platform filepicker (in fpicker/source/office). I added a "Places" (bookmarks) list on the left and I would like to save the entries that the user bookmarked . Cedric Bosdonnat told me to look at xcu and xcs files, but I'm a bit lost. I'm looking for a code sam

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

On Tue, 2012-01-24 at 09:49 -0500, Kohei Yoshida wrote: > > It seems that your patch does not fix the problem in 3-5. I tested > > with sc/qa/extras/testdocuments/ScDataPilotTableObj.ods similar and > > changed B6 but refresh does not work except if you force to create the > > cache. > > Does it

Re: [Libreoffice] sc_unoapi failure

On Mon, 2012-01-23 at 13:01 +0100, Eike Rathke wrote: > Hi Stephan, > > On Monday, 2012-01-23 11:44:43 +0100, Stephan Bergmann wrote: > > > On 01/23/2012 11:38 AM, Stephan Bergmann wrote: > > >The Linux-RHEL6-x86_64@14-with-check tinderbox is consistently failing > > >with a crash in sc_unoapi in

Re: [Libreoffice] [REVIEW-3.5] Handling ordering problem when properties are set one by one

On Tuesday 24 of January 2012, Michael Stahl wrote: > On 23/01/12 21:31, Lubos Lunak wrote: > > Technically, I get in SwXDocumentSettings::_setSingleValue() first a > > call with HANDLE_CURRENT_DATABASE_DATA_SOURCE and then with > > HANDLE_CURRENT_DATABASE_COMMAND. They both call first SwDoc::GetD

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

On Tue, 2012-01-24 at 12:35 +0100, Markus Mohrhard wrote: > Hello Kohei, > > > > > I'd like to have > > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=561b044d62f4701e51abb4a7c47ce3b07f788f8e > > > > cherry-picked to 3-5. This is a follow-up to my earlier changes in the > > pivot tab

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

On Tue, 2012-01-24 at 12:24 +0100, Eike Rathke wrote: > Hi, > > On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: > > > Did you check with libreoffice 3-5? I think that eike's work for date > > patterns is missing in 3-5 > > Yes, that's only on master. > > > so that this patch does

Re: [Libreoffice] Problem with clipboard paste in 3.5

Hi Petr, On 2012-01-23 at 11:29 +0100, Petr Cisar wrote: > So my next question is whether it is possible that LO can run without > libdtrans for some reason and what may be the possible cause ? I'm sorry, I cannot answer your specific question; but if you haven't tried yet, I'd build vcl with e

Re: [Libreoffice] Handling ordering problem when properties are set one by one

On 23/01/12 21:31, Lubos Lunak wrote: > > Hello, > > I have a bug that's related to databases in Writer (menu->Edit->Exchange > Database and RES_HIDDENTXTFLD). The code that triggers it does a copy of the > document in order to do the necessary substitutions there (well, this all is > at lea

Re: [Libreoffice] [PUSHED:3-5] Re: About "Same expression on both sides of '||'" in LockEntrySequence.cxx

julien2412 píše v Po 16. 01. 2012 v 11:49 -0800: > Thank you Caolan and Christophe ! > I commited the patch as it was and pushed on Master. > > Julien. > (PS : if you want/think useful I cherry pick it on 3.5, I can do it) The patch made sense and looked safe => pushed into 3-5 branch. Best Reg

Re: [Libreoffice] [REVIEWED:3-5][PUSHED:3-5] rhbz#746174 ODF export: numbering restart lost

Michael Stahl píše v Po 23. 01. 2012 v 20:22 +0100: > the following fix for libreoffice-3.5: > > seems that under very special circumstances we don't export a list restart > if the paragraph has only the restart flag set but no start value set. > > not a regression as far as i can tell; broken si

Re: [Libreoffice] [PUSHED][REVIEW 3-5] remove duplicated icons from soffice.bin/soffice.exe (fdo#37740)

Looks sane. I pushed it into 3-5. F. On 19/01/12 13:20, Michael Meeks wrote: Hi Andras, On Thu, 2012-01-19 at 13:01 +0100, Andras Timar wrote: Duplicated beyond that. Windows .ico files contain icon sets, each file contains 16x16, 32x32, 48x48, 128x128, and 256x256 icons. But many identical

Re: [Libreoffice] [REVIEW][PUSHED] Fixing page break button flickering

Cedric Bosdonnat píše v Pá 20. 01. 2012 v 15:44 +0100: > Hi all, > > Moving the mouse over the page break line simply makes the button > flicker... it's then not possible to see or click on it. The bug has > only been reported on this list and ux-advise. > > This is caused by the following commit

Re: [Libreoffice] [REVIEW 3-5] [PUSHED] potential fix for fdo#44391

Hello Noel, 2012/1/24 Noel Power : > would like to get this committed for 3.5, although I don't see the same > artifacts  as mentioned in the bug, I do see sometimes the  some character > is displayed still after switching to a blank cell from one with content. I > no longer see this with the patc

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Cor Nouws changed: What|Removed |Added Depends on||33393 --- Comment #139 from Cor Nouws 2012-

Re: [Libreoffice] sal / unit tests ...

Hi Matus, On Sat, 2012-01-21 at 19:39 +0100, Matúš Kukan wrote: > On 21 January 2012 14:19, Matúš Kukan wrote: > > On 21 January 2012 13:07, Michael Meeks wrote: > >>* Cppunit_ gnumakefiles can only handle a single test per file > >>+ I split up the osl_File one to make i

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #138 from sasha.libreoff...@gmail.com 2012-01-24 04:33:29 PST --- In one bug hard to distinguish regression from new functionality: Bug 35735 - "Save As" defaults to current document format -- Configure bugmail: https://bugs.freedesk

[Libreoffice] [PUSHED] Re: [REVIEW 3-5] fdo#43705: fix incomplete updating of the page preview pane in Draw

Hi Ivan, the patch looks good to me. Pushed. Cheers Radek On Sun, 2012-01-22 at 15:35 +0400, Ivan Timofeev wrote: > Hi, > > https://bugs.freedesktop.org/show_bug.cgi?id=43705 (regression since 3.4) > > The fix for review: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=799f2de5d1085d

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

On 21/01/12 01:42, Andrew Douglas Pitonyak wrote: I believe that you intend to cause the following behavior: date + numDate date - num Date date * num Double date / num Double date + dateDate [2] date - date Double [3] date * date Double

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

On Tue, Jan 24, 2012 at 03:36:23PM +0400, Ivan Timofeev wrote: > 17.01.2012 16:05, Caolán McNamara пишет: > >On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: > >>Hi there, > >> > >>https://bugs.freedesktop.org/show_bug.cgi?id=43932 > >> > >>this patch partially reverts > >>http://cgit.freede

Re: [Libreoffice] File not found: cairocanvas.uno.so in smoketestoo_native

Hi Riccardo, On Tue, 2012-01-24 at 12:26 +0100, Riccardo Magliocchetti wrote: > with this configuration (note --disable-cairo-canvas is set) > > /autogen.sh --without-junit --without-java --disable-epm --disable-gtk ... > --disable-cairo-canvas --disable-neon --disable-dbus --disable-systray

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

17.01.2012 16:05, Caolán McNamara пишет: On Fri, 2012-01-13 at 22:22 +0400, Ivan Timofeev wrote: Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because th

Re: [Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

Hello Kohei, > > I'd like to have > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=561b044d62f4701e51abb4a7c47ce3b07f788f8e > > cherry-picked to 3-5.  This is a follow-up to my earlier changes in the > pivot table code which somewhat changes the way pivot tables are > refreshed. > > In

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

Hi, On Tuesday, 2012-01-24 11:42:57 +0100, Markus Mohrhard wrote: > Did you check with libreoffice 3-5? I think that eike's work for date > patterns is missing in 3-5 Yes, that's only on master. > so that this patch does reopen the bug we > discussed on IRC. At least your unit test fails and I

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

On Mon, 2012-01-23 at 15:27 +0100, Michael Stahl wrote: > unfortunately this would have less benefits than you imagine, because of > the way xmloff writes automatic styles: they are generated anew on every > export, in a non-deterministic order Wow - how non-deterministic ? randomly shuff

[Libreoffice] [REVIEW 3-5] potential fix for fdo#44391

would like to get this committed for 3.5, although I don't see the same artifacts as mentioned in the bug, I do see sometimes the some character is displayed still after switching to a blank cell from one with content. I no longer see this with the patch and believe that it can't do any harm

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

Hello Tim, Thanks for your patch. :-) I didn't test it yet, but just my nitpick: could you please remove the #include which I added to make the build success ? It seems to be unused now. And FYI, Jan Holesovsky changed the zoom factor to 2^(1/4). http://cgit.freedesktop.org/libreoffice/core/

[Libreoffice] unused function parameters

When we made the original OOo code base warning-clean a number of years ago, many warnings about unused parameters were silenced by removing the parameter name, instead of actually fixing the code by dropping the unused parameter. Of course, dropping an unused parameter is not always the right

[Libreoffice] [REVIEWED/PUSHED] Fix for bug fdo#44110, New Math symbols issues in Windows

On Mon, 2012-01-23 at 22:32 -0200, Olivier Hallot wrote: > I have fixed and pushed in master this issue, but it should be > cherry-picked into 3.5 Reviewed & pushed to -3-5 :-) Thanks ! Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot _

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44110, which changed state. Bug 44110 Summary: New Math symbols poorly rendered in Windows https://bugs.freedesktop.org/show_bug.cgi?id=44110 What|Old Value |New Value ---

Re: [Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

Hello Kohei, 2012/1/24 Kohei Yoshida : > Hi there, > > I would like > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde > > to be backported to the 3-5 branch.  It fixes > > https://bugs.freedesktop.org/show_bug.cgi?id=45067 > > Review and sign-off

Re: [Libreoffice] Build fails for Tail_build

Hi Anurag, On Tue, 2012-01-24 at 09:07 +0530, Anurag Jain wrote: > I've been building LO and it seems build is failing for me in > tail_build for one of the unit test. I asked about if there is any > work around other than cleaning and rebuilding this big chunk in the > main channel. Ah :

Re: [Libreoffice] Important details for easy woking on LibreOffice

Danylo Sa píše v Ne 22. 01. 2012 v 15:12 +0100: > Hello. > > People who used MS Office before has some complaints about LibreOffice: > > 1 - Insert number of pages is a pain in LibreOffice Writer. > Why all this complication for a simple task? > >SOLUTION >--> Why don't you include

Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code.

Hello Stephan, On 24.01.2012 09:30, Stephan Bergmann wrote: > However, I have another question: I notice that, while most > occurrences are replaced with SAL_WARN, some were left as OSL_ENSURE > (which I changed to SAL_WARN; one missed a comma, anyway) and some > are changed to SAL_INFO. Was th

Re: [Libreoffice] [PATCH][PUSHED] Replace ENSURE_OR_* macros with regular code.

[This should have gone out last night already, somehow didn't make it off my computer.] On 01/23/2012 11:08 AM, Marcel Metz wrote: I oppose to the "macros improve readability" argument, these macros don't improve readability, they hide some regular execution from the programmer. You would need