Re: [Libreoffice] LO Custom properties

2011-09-20 Thread swagat sharma
That is correct. But that helps only when we install using 'make install' In the deb package, it still installs in /opt /solenv/bin/modules/installer/setupscript.pm This script generates the setup script and uses all default variables. How can i generate a customized deb package? I wish to change

Re: [Libreoffice] [PATCH] [PUSHED] change font name in Thai fall-back font lists in VCL.xcu

2011-09-20 Thread David Tardon
On Wed, Sep 21, 2011 at 11:26:31AM +0700, Tantai Tanakanok wrote: > I change font name from "TH SarabunNew" to "TH Sarabun New" because this new > font was renamed by the owner (SIPA) when it is actually released. > Thanks, pushed! Can you confirm that this and all your future patches are licens

[Libreoffice] [PATCH] change font name in Thai fall-back font lists in VCL.xcu

2011-09-20 Thread Tantai Tanakanok
I change font name from "TH SarabunNew" to "TH Sarabun New" because this new font was renamed by the owner (SIPA) when it is actually released. Thanks, Tantai Thanakanok -- _/|\_ Tantai Thanakanok. Open Source Development Co., Ltd. Tel: +66 38 311816, Fax: +66 38 773128, http://www.osdev.co.th/

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Norbert Thiebaud
On Tue, Sep 20, 2011 at 8:51 PM, Kohei Yoshida wrote: >> I haven't >> checked for other modules, and I certainly agree that for >> java-extensions and external java module like tomcat we probably don't >> want to go that route... > > Yup.  But wow, isn't tomcat a http server?  What do we even use

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Tomáš Chvátal
2011/9/21 Kohei Yoshida : > Yup.  But wow, isn't tomcat a http server?  What do we even use tomcat > for? ;-) > Wiki extension ;) Tom ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreof

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Kohei Yoshida
On Tue, 2011-09-20 at 20:06 -0500, Norbert Thiebaud wrote: > On Tue, Sep 20, 2011 at 7:42 PM, Kohei Yoshida > wrote: > > > > What I like about ant is that you don't need to list every single java > > source file you need to compile, whereas in make you do (unless I'm > > missing something). That

Re: [Libreoffice] [libreoffice.boldandbusted.com] cppcheck's "unusedFunction" check activated

2011-09-20 Thread Jesse Adelman
On 09/20/11 14:23, julien2412 wrote: > Hello Jesse, > > I tested on a small piece of code, "unused function" check works. > About "unused function", there is the file unusedcode.easy regularly > regenerated by Caolán. So I don't know. > > I wonder too if "git updating" cppcheck would remove the f

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Norbert Thiebaud
On Tue, Sep 20, 2011 at 7:42 PM, Kohei Yoshida wrote: > > What I like about ant is that you don't need to list every single java > source file you need to compile, whereas in make you do (unless I'm > missing something).  That makes a huge difference and makes the ant > build script very small reg

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Kohei Yoshida
On Tue, 2011-09-20 at 19:29 -0500, Norbert Thiebaud wrote: > On Tue, Sep 20, 2011 at 6:02 PM, Kohei Yoshida > wrote: > > > > Well, if ant is used to build Java jar packages, then, I would prefer > > ant be used because ant's build script is much simpler than make's for > > Java packages. For Jav

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Norbert Thiebaud
On Tue, Sep 20, 2011 at 6:02 PM, Kohei Yoshida wrote: > > Well, if ant is used to build Java jar packages, then, I would prefer > ant be used because ant's build script is much simpler than make's for > Java packages.  For Java, ant is pretty much the standard build > system. The problem is 'ant'

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Kohei Yoshida
Hi guys, On Tue, Sep 20, 2011 at 6:15 PM, Norbert Thiebaud wrote: > On Tue, Sep 20, 2011 at 4:18 PM, Peter Foley wrote: >> Use of apache ant in libreoffice seemes to be restricted to these 5 >> modules. >> >> beanshell qadevOOo scripting swext xmerge >> >> I was wondering if there is any particu

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Peter Foley
On Tue, 20 Sep 2011, Norbert Thiebaud wrote: > On Tue, Sep 20, 2011 at 4:18 PM, Peter Foley wrote: > > Use of apache ant in libreoffice seemes to be restricted to these 5 > > modules. > > > > beanshell qadevOOo scripting swext xmerge > > > > I was wondering if there is any particular reason for u

Re: [Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Norbert Thiebaud
On Tue, Sep 20, 2011 at 4:18 PM, Peter Foley wrote: > Use of apache ant in libreoffice seemes to be restricted to these 5 > modules. > > beanshell qadevOOo scripting swext xmerge > > I was wondering if there is any particular reason for using apache ant or > if it would be a good idea to convert t

Re: [Libreoffice] [PATCH] SvUShorts -> std::vector

2011-09-20 Thread Daniel Di Marco
Thanks for the advice, I will keep this in mind. Best, Daniel On 09/20/2011 03:44 PM, Rafael Dominguez wrote: Just a little input about patch, nothing serious but its worth saying, when checking if a container has elements, dont use the size() call since its O(n) and not a constant call on so

Re: [Libreoffice] Suspicious warning fixes

2011-09-20 Thread Regina Henschel
Hi Stephan, Stephan Bergmann schrieb: Regina, The below two commits fix warnings from code changed through a recent commit by you, and in both cases I am a little unsure whether my fix is good (see inline below). I'm coding only in my spare time and have no deep insight into the code, so it

Re: [Libreoffice] [libreoffice.boldandbusted.com] cppcheck's "unusedFunction" check activated

2011-09-20 Thread julien2412
Hello Jesse, I tested on a small piece of code, "unused function" check works. About "unused function", there is the file unusedcode.easy regularly regenerated by Caolán. So I don't know. I wonder too if "git updating" cppcheck would remove the false positive "Boolean result is used in bitwise op

[Libreoffice] [RFC] use of apache ant in libreoffice

2011-09-20 Thread Peter Foley
Use of apache ant in libreoffice seemes to be restricted to these 5 modules. beanshell qadevOOo scripting swext xmerge I was wondering if there is any particular reason for using apache ant or if it would be a good idea to convert these modules to use plain gbuild Jars? Peter ___

Re: [Libreoffice] Mi first very little patch

2011-09-20 Thread CaStarCo
2011/9/20 Lionel Elie Mamane > On Mon, Sep 12, 2011 at 10:45:31PM +0200, CaStarCo wrote: > > > @Lionel , What is the QuadPart member of the structure? The high > > part? the low part? or another thing? > > The union is fully described at > http://msdn.microsoft.com/en-us/library/aa383713(v=vs.85)

Re: [Libreoffice] Questions about Easyhack 37007 Add Math symbol "There does not exist"

2011-09-20 Thread Julien Nabet
Le 20/09/2011 17:31, Caolán McNamara a écrit : On Sat, 2011-09-17 at 20:50 +0200, Julien Nabet wrote: - to discuss about the fact it doesn't work if you've other version of OpenSymbol (for example, I had the Debian package OpenSymbol and it didn't worked until I uninstalled it) Yeah, this is th

Re: [Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-4' - solenv/gbuild

2011-09-20 Thread Bjoern Michaelsen
On Tue, 20 Sep 2011 20:32:57 +0200 Bjoern Michaelsen wrote: > As there is quite a bit of meddling involved, I would indeed prefer > just a revert by now. As discussed on IRC: http://cgit.freedesktop.org/libreoffice/bootstrap/commit/?h=libreoffice-3-4&id=b6b7eb97b48937132638aeeef18270624201a930

[Libreoffice] Suspicious warning fixes (was: [Libreoffice-commits] .: 4 commits - chart2/source cui/source desktop/test solenv/bin solenv/gdb solenv/inc)

2011-09-20 Thread Stephan Bergmann
Regina, The below two commits fix warnings from code changed through a recent commit by you, and in both cases I am a little unsure whether my fix is good (see inline below). On 09/20/2011 08:51 PM, Stephan Bergmann wrote: chart2/source/view/main/ShapeFactory.cxx |1 cui/sourc

Re: [Libreoffice] [Libreoffice-commits] .: Branch 'libreoffice-3-4' - solenv/gbuild

2011-09-20 Thread Bjoern Michaelsen
On Tue, 20 Sep 2011 00:10:29 -0500 Norbert Thiebaud wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ff1c626fa1380c7af5a135f80b45de7e62025eed That one got reverted on master and is replaced by: http://cgit.freedesktop.org/libreoffice/core/commit/?id=17a2dcabe15f24567b5b68f92ede6

Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

2011-09-20 Thread Ivan Timofeev
2011/9/20 Caolán McNamara : > Hmm, if in normal mode I type in 3-4 I get that range previewed, change > it to "foobar" and it stays previewing 3-4, which isn't great either > really. In normal layout in Writer and in any modes in other apps, i.e. brochure layout in Writer is the only dissimilar pl

Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

2011-09-20 Thread Caolán McNamara
On Tue, 2011-09-20 at 14:25 +0400, Ivan Timofeev wrote: > I'm glad to see my patches in master! :-) Thanks! > > 2011/9/20 Caolán McNamara : > > I don't *think* we need to move the code around, the check for empty is > > sufficient so I shrank it down to that bit. > > Hmm, when in "brochure" layou

Re: [Libreoffice] [PATCH] [PUSHED] Build *SOME* extensions by default

2011-09-20 Thread Tomáš Chvátal
Dne 20. září 2011 17:52 Tomáš Chvátal napsal(a): > Attaching updated patch that enables just few of them, but mostly > simplifies the logic in their detection cases. > > I left the scripting for beanshell and javascript disabled too :) > > Tom > Ow crap, I pused it now when i messed around with t

Re: [Libreoffice] [PATCH] Add missing chart data point ODF1.2 standard symbols

2011-09-20 Thread Kohei Yoshida
On Fri, 2011-09-09 at 15:26 +0200, Regina Henschel wrote: > Hi all, > > Final patch, now in one file :) I just reviewed it and pushed to master. Sorry about the delay. The past few weeks have been crazy due to our mail outage. > Following problems are already in current LibO version and not ca

Re: [Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Noel Power
On 20/09/11 16:27, Caolán McNamara wrote: On Tue, 2011-09-20 at 09:59 +0100, Noel Power wrote: I'm looking for someone to bless/approve ( and or ) commit the patch to the 3.4 branch The only things outside of testtool which are touched look like an early return from SbFormFactory::CreateObject

Re: [Libreoffice] [PATCH] Build *SOME* extensions by default

2011-09-20 Thread Tomáš Chvátal
Attaching updated patch that enables just few of them, but mostly simplifies the logic in their detection cases. I left the scripting for beanshell and javascript disabled too :) Tom From a3299781af0b92a310a8d2f6e6a315cd08e5593a Mon Sep 17 00:00:00 2001 From: Tomas Chvatal Date: Tue, 20 Sep 2011

Re: [Libreoffice] [PATCH] SvUShorts -> std::vector

2011-09-20 Thread Rafael Dominguez
Just a little input about patch, nothing serious but its worth saying, when checking if a container has elements, dont use the size() call since its O(n) and not a constant call on some stl implementations, its preferred to use empty(). On Mon, Sep 19, 2011 at 7:51 PM, Daniel Di Marco wrote: > H

Re: [Libreoffice] Undoing basis/brand split in 3.5

2011-09-20 Thread Michael Meeks
On Tue, 2011-09-20 at 15:11 +0200, Stephan Bergmann wrote: > With LibO today, there is no real need for that split any longer, so it > only complicates our code base. I would undo it in incremental steps Sounds beautiful to me :-) [ though somewhat sad of course in general ]. Hopefully

Re: [Libreoffice] [PATCH] Build extensions by default

2011-09-20 Thread Caolán McNamara
On Tue, 2011-09-20 at 16:29 +0100, Michael Meeks wrote: > ext-scripting-* The python one is a goody of course, are the beanshell and rhino ones compelling ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org

Re: [Libreoffice] Questions about Easyhack 37007 Add Math symbol "There does not exist"

2011-09-20 Thread Caolán McNamara
On Sat, 2011-09-17 at 20:50 +0200, Julien Nabet wrote: > - to discuss about the fact it doesn't work if you've other version of > OpenSymbol (for example, I had the Debian package OpenSymbol and it > didn't worked until I uninstalled it) Yeah, this is the same problem that a lot of people ran in

Re: [Libreoffice] [PATCH] Build extensions by default

2011-09-20 Thread Michael Meeks
On Tue, 2011-09-20 at 14:31 +0100, Caolán McNamara wrote: > I'm with rene on this one. All for enabling by default the ones like > presenter screen, i.e. extensions which were really done as extensions > in order to jump-start the original extensions repository with some > "must haves" R

Re: [Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Caolán McNamara
On Tue, 2011-09-20 at 09:59 +0100, Noel Power wrote: > I'm looking for someone to bless/approve ( and or ) commit the patch to > the 3.4 branch The only things outside of testtool which are touched look like an early return from SbFormFactory::CreateObject if vba is enabled and a removed HelpID f

Re: [Libreoffice] Creating new release for libtextcat

2011-09-20 Thread Caolán McNamara
On Fri, 2011-09-02 at 14:09 +0100, Caolán McNamara wrote: > On Fri, 2011-09-02 at 14:44 +0200, Tomáš Chvátal wrote: > > Hi, > > > > I was wondering if it would be possible to create git repostiory for > > libtextcat with all the fixes that are now applied. After such repo is > > created it would b

Re: [Libreoffice] [PATCH] Build extensions by default

2011-09-20 Thread Caolán McNamara
On Tue, 2011-09-20 at 14:56 +0200, Rene Engelhard wrote: > Third-party extensions should be buolt and distributed separetely if they > can be built separately. > I am OK with enabling those which are already in core, but please > don't enable any of those which need extra stuff ./download'ed... I'

[Libreoffice] Undoing basis/brand split in 3.5

2011-09-20 Thread Stephan Bergmann
As recently announced on #libreoffice-dev, I consider undoing the basis/brand layer split. Historically, this was introduced at Sun to make it possible for various products (plain OpenOffice.org, Brasilian BrOffice re-branding, Sun's proprietary StarOffice, ...) to share code that is only buil

Re: [Libreoffice] [PATCH] Build extensions by default

2011-09-20 Thread Rene Engelhard
Hi, On Tue, Sep 20, 2011 at 02:25:47PM +0200, Tomáš Chvátal wrote: > this patch enables building all the extensions by default instead of > requiring user to run --enable-blabla. > I enabled all extensions that do not pose any huge external deps, > please let me know if you find it ok or if you fi

[Libreoffice] [PATCH] Build extensions by default

2011-09-20 Thread Tomáš Chvátal
Hi guys, this patch enables building all the extensions by default instead of requiring user to run --enable-blabla. I enabled all extensions that do not pose any huge external deps, please let me know if you find it ok or if you find any issues, so I could commit it to the master. Cheers Tom Fr

Re: [Libreoffice] Proposal: slowcheck -- a new gbuild toplevel target

2011-09-20 Thread Marc-André Laverdière
I like the idea, personally. I was toying with the idea of also have a target for fuzz testing stuff. So that could be done at the same time too! -- Marc-André Laverdière Software Security Scientist Innovation Labs, Tata Consultancy Services Hyderabad, India On Tue 20 Sep 2011 02:57:26 PM IST,

Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

2011-09-20 Thread Ivan Timofeev
> I think this lines should (?) be moved below the newly introduced check. *This* lines: rPagePairs.clear(); rValidPagesSet.clear(); rValidStartFrms.clear(); ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

Re: [Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

2011-09-20 Thread Ivan Timofeev
I'm glad to see my patches in master! :-) Thanks! 2011/9/20 Caolán McNamara : > I don't *think* we need to move the code around, the check for empty is > sufficient so I shrank it down to that bit. Hmm, when in "brochure" layout, try to input incorrect range and you will see "No pages" on the pri

Re: [Libreoffice] Mi first very little patch

2011-09-20 Thread Lionel Elie Mamane
On Mon, Sep 12, 2011 at 10:45:31PM +0200, CaStarCo wrote: > @Lionel , What is the QuadPart member of the structure? The high > part? the low part? or another thing? The union is fully described at http://msdn.microsoft.com/en-us/library/aa383713(v=vs.85).aspx Are you familiar with the concept of

[Libreoffice] [PUSHED][PATCH][REVIEW 3-4] Fix for fdo#38391

2011-09-20 Thread Caolán McNamara
On Sat, 2011-09-17 at 03:33 -0700, Ivan Timofeev wrote: > This patch fixes crash when you input incorrect range of pages in "Print" > dialog, "General" tab, "Pages" textfield and layout is set to "Brochure". > http://nabble.documentfoundation.org/file/n3344034/Fix-for-fdo-35513.patch > Fix-for-fdo

Re: [Libreoffice] LO Custom properties

2011-09-20 Thread Stephan Bergmann
On 09/20/2011 10:11 AM, swagat sharma wrote: I have generated a deb package of libreoffice using epm. --enable-epm and with-package-format = deb Now the package generated is installed by default in /opt directory. How can I modify it to install in /usr/lib/ ? Which variable to change/set? Any

Re: [Libreoffice] Proposal: slowcheck -- a new gbuild toplevel target

2011-09-20 Thread Markus Mohrhard
Hello all, 2011/9/20 Caolán McNamara > On Mon, 2011-09-19 at 21:18 +0200, Bjoern Michaelsen wrote: > > I am proposing introducing a new target in the build system called > > "slowunitcheck". Those are tests that are technically unittests (need > > no full install), but considered to slow/longrun

Re: [Libreoffice] Proposal: slowcheck -- a new gbuild toplevel target

2011-09-20 Thread Bjoern Michaelsen
Hi Caolán, On Tue, 20 Sep 2011 10:07:53 +0100 Caolán McNamara wrote: > If the goal is to support e.g. calc guys rebuilding fast when hacking > sc, the more natural approach to me would be an extra non-unit-test > module-level target, e.g. cd sc; make skipchecks or some such, an > explicit opt-ou

[Libreoffice] [PATCH] bug fdo#37164

2011-09-20 Thread Noel Power
Hi, The automation testtool thingy is broken on 3.4 ( and master too... but that's a different story ) The root cause of the problem was caused by cws changehid which replaced numerical hid's by strings and additionally removed the class SmartId. The testtool code was adjusted ( but not complet

Re: [Libreoffice] Proposal: slowcheck -- a new gbuild toplevel target

2011-09-20 Thread Caolán McNamara
On Mon, 2011-09-19 at 21:18 +0200, Bjoern Michaelsen wrote: > I am proposing introducing a new target in the build system called > "slowunitcheck". Those are tests that are technically unittests (need > no full install), but considered to slow/longrunning to be run on every > build. Instead those a

Re: [Libreoffice] LO Custom properties

2011-09-20 Thread swagat sharma
Hi I have generated a deb package of libreoffice using epm. --enable-epm and with-package-format = deb Now the package generated is installed by default in /opt directory. How can I modify it to install in /usr/lib/ ? Which variable to change/set? Any ideas? Also I want to checkout 3.4 branch

Re: [Libreoffice] [PUSHED] SvUShorts -> std::vector

2011-09-20 Thread Fridrich Strba
Hello, Daniel, Thanks for this, I pushed it and removed a warning that showed its head. Cheers and keep the good work Fridrich On Tue, 2011-09-20 at 00:21 +, Daniel Di Marco wrote: > Hi, > > I replaced some usages of SvUShorts with std::vectors. > License is LGPLv3+/MPL > > > Cheers, >

Re: [Libreoffice] [PATCH] SvUShorts -> std::vector

2011-09-20 Thread Fridrich Strba
Hello, Daniel, Thanks for this, I pushed it and removed a warning that showed its head. Cheers and keep the good work Fridrich On Tue, 2011-09-20 at 00:21 +, Daniel Di Marco wrote: > Hi, > > I replaced some usages of SvUShorts with std::vectors. > License is LGPLv3+/MPL > > > Cheers, >

Re: [Libreoffice] [PUSHED] Update Zenity with progress icon notification

2011-09-20 Thread Fridrich Strba
Hullo, Kevin Thanks of the patch, pushed List On Mon, 2011-09-19 at 14:41 -0400, Kevin Hunter wrote: > Hullo List, > > This patch adds a "clock" style progress, so one doesn't have to mouse > over the Zenity icon to see where it currently stands. > > Very simple, very rudimentary, but alread