On Sat, 2011-09-17 at 03:33 -0700, Ivan Timofeev wrote: > This patch fixes crash when you input incorrect range of pages in "Print" > dialog, "General" tab, "Pages" textfield and layout is set to "Brochure". > http://nabble.documentfoundation.org/file/n3344034/Fix-for-fdo-35513.patch > Fix-for-fdo-35513.patch
Ah, indeed. That's a great catch. The earlier page count is more tolerant of incorrect ranges, while the specific get the exact pages to print is more strict, so it blows up and dies. I don't *think* we need to move the code around, the check for empty is sufficient so I shrank it down to that bit. I think this is really worth cherry-picking to 3-4, i.e. b7d874f49b102eabe2974c4dee1272d2cf6053a3 C. _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
