Re: [Libreoffice] (un)localized MSI installer [REVIEW REQUEST]

2011-01-13 Thread Fridrich Strba
Good for me, go for it! On Thu, 2011-01-13 at 14:18 -0700, Tor Lillqvist wrote: > > So the problem must be in setup.exe, in some cases it fails to understand > > that it should use a transform. That is good, because it means we can debug > > it. > > Which I did. Which was fun. Or at least ente

[Libreoffice] [PATCH] partial easy hack - removal of non-compiled / dead code

2011-01-13 Thread Topround
Greetings all, This is my first attempt to contribute code to LibreOffice, so hope I did it right!  :)  If I did something wrong please help me out! This is a first pass attempt at cleaning up non-compiled/commented out code in sc.  I basically covered sc/inc/* and sc/source/core/data/* There is

[Libreoffice] Build install for DEBS

2011-01-13 Thread Andy Brown
Hi all, I have been able to download and build the main branch for LibO. Could some kind soul tell me how, or point me to a wiki page, to build the deb packages so that I can install on another Ubuntu machine? TIA Andy ___ LibreOffice mailing list

Re: [Libreoffice] Build error in sc from libreoffice-3.3.0.3 tag

2011-01-13 Thread Miklos Vajna
On Thu, Jan 13, 2011 at 10:55:53AM -0500, Kohei Yoshida wrote: > I guess you are using mdds 0.5.x on the 3.3 branch? The 3.3 branch > requires 0.4.0, it won't build with 0.5.x. Oh, indeed. :) Thanks for the suggestion! pgpgUGOywVnxb.pgp Description: PGP signature

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Lionel Elie Mamane changed: What|Removed |Added CC||lio...@mamane.lu Depends on

Re: [Libreoffice] (un)localized MSI installer [REVIEW REQUEST]

2011-01-13 Thread Thorsten Behrens
Tor Lillqvist wrote: > Please review the patch. Three approvals are needed to get this > into the 3.3 installer. > Approved from my side. -- Thorsten pgpaOhFsALG2r.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedeskt

Re: [Libreoffice] (un)localized MSI installer [REVIEW REQUEST]

2011-01-13 Thread Tor Lillqvist
> So the problem must be in setup.exe, in some cases it fails to understand > that it should use a transform. That is good, because it means we can debug > it. Which I did. Which was fun. Or at least entertaining. The code in libs-core/desktop/win32/source/setup/setup.cpp is, what shall I say,

Re: [Libreoffice] flat xml odf

2011-01-13 Thread Gioele Barabucci
Michael Meeks 13/01/2011 10:33: On Thu, 2011-01-13 at 10:08 +0100, Jos van den Oever wrote: I trust you validated the flat XML with the RNG from the specification. Do you have a set of test documents in flat or zip format that you use for testing the import and export of flat xml files?

[Libreoffice] [PATCH] unopkg crasher on SLED11-SP1 (bnc#655912)

2011-01-13 Thread Petr Mladek
Hi, could you please review the attached patch for libreoffice-3-3 branch? It looks like a compiler bug. I see it only on SLED11 with one particular gcc version. So, the solution is a kind of workaround but it should be fine in general. See the patch for more details. Best Regards, Petr >From

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-13 Thread Joost Eekhoorn
Hi Kohei, You did not miss anything! My mistake: I did only : ./g reset --hard origin/master Now I did (additional) : ./g pull -r And I see the change. Thanks Joost 2011/1/13 Kohei Yoshida > On Thu, 2011-01-13 at 19:58 +0100, Joost Eekhoorn wrote: > > Hi Kohei, > > > > I see that the path

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-13 Thread Kohei Yoshida
On Thu, 2011-01-13 at 19:58 +0100, Joost Eekhoorn wrote: > Hi Kohei, > > I see that the path is not pushed (it is not in the current master). Sorry, which patch are you speaking of? I did apply your patch attached to the first of this thread. http://cgit.freedesktop.org/libreoffice/calc/commit/

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 32635, which changed state. Bug 32635 Summary: BrOffice and Windows desktop integration https://bugs.freedesktop.org/show_bug.cgi?id=32635 What|Old Value |New Value --

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-13 Thread Joost Eekhoorn
Hi Kohei, I see that the path is not pushed (it is not in the current master). It is ofcourse up to you, when you do not want to push it, or to make first further improvements. I am just currious where the problems are, so that I can learn from them. Best regards Joost 2011/1/7 Laurent Godard

Re: [Libreoffice] (un)localized MSI installer

2011-01-13 Thread Tor Lillqvist
> The next part (setup.exe/MSI) is always in English. That is not the intent; if you check the installation files that get unpacked by the outer NSIS layer into a temporary folder, you see that there are a bunch of transforms (.mst files), one for each language the installer is localized to. Th

Re: [Libreoffice] [PUSHED] Patch review

2011-01-13 Thread Petr Mladek
Petr Mladek píše v Čt 13. 01. 2011 v 19:01 +0100: > Looks fine. I checked: > > + the patches are complete and exact revert of the > problematic committs > + build succeeded > + runtime test confirmed that it fixed i#116439 (was able > to reproduce it with the

Re: [Libreoffice] Patch review

2011-01-13 Thread Petr Mladek
Kohei Yoshida píše v Čt 13. 01. 2011 v 11:38 -0500: > Hi there, > > The attached patches revert the recent two commits which consist of the > merging of OOo330-m19 changes. > > It fixed i#115906 and i#116164, but the fix for i#116164 unfortunately > was pretty large and invasive, plus it introduc

[Libreoffice] MimeType icons - format and naming for inclusion in package?

2011-01-13 Thread Bernhard Dippold
Hi all, the LibreOffice Design Team is working hard to finalize an iconset containing MimeType icons for application/documents and templates in order to replace the present icons from OOo 3.0 to 3.2. If you want to have a look at the present state, please visit the wiki: http://wiki.documentf

Re: [Libreoffice] Review request

2011-01-13 Thread Caolán McNamara
On Wed, 2011-01-12 at 10:57 +, Michael Meeks wrote: > Caolan - can you give it a 3rd review and merge it if you're happy :-) > If we're not completely ecstatic about it perhaps libreoffice-3-3 would > be adequate. Well, it looks reasonable, I can't be completely sure though. Still, go fo

[Libreoffice] Patch review

2011-01-13 Thread Kohei Yoshida
Hi there, The attached patches revert the recent two commits which consist of the merging of OOo330-m19 changes. It fixed i#115906 and i#116164, but the fix for i#116164 unfortunately was pretty large and invasive, plus it introduced a regression as reported in i#116439 of OOo bug tracker. It is

Re: [Libreoffice] Build error in sc from libreoffice-3.3.0.3 tag

2011-01-13 Thread Kohei Yoshida
On Thu, 2011-01-13 at 16:46 +0100, Miklos Vajna wrote: > Hi, > > The build ends with: > > Entering > /var/tmp/fst/src/libreoffice-build-3.3.0.3/build/libreoffice-3.3.0.3/sc/source/filter/excel > > Compiling: sc/source/filter/excel/colrowst.cxx I guess you are using mdds 0.5.x on the 3.3 branch

[Libreoffice] Build error in sc from libreoffice-3.3.0.3 tag

2011-01-13 Thread Miklos Vajna
Hi, The build ends with: Entering /var/tmp/fst/src/libreoffice-build-3.3.0.3/build/libreoffice-3.3.0.3/sc/source/filter/excel Compiling: sc/source/filter/excel/colrowst.cxx /var/tmp/fst/src/libreoffice-build-3.3.0.3/build/libreoffice-3.3.0.3/sc/source/filter/excel/colrowst.cxx: In member funct

[Libreoffice] Why the heck was help ripped out of the linux langpacks? (and that *between RCs*)

2011-01-13 Thread Christian Lohmaier
Hi *, see topic. A drastic change once again just between release candidates, without prior announcement, without notifiying website, etc. (if there was an annoucnement, then I apologize, but would be thankful if you could point me to it, I'm definitely surprised (in a bad way) of this change, as

[Libreoffice] (un)localized MSI installer

2011-01-13 Thread Andras Timar
Hi, NSIS part of LibreOffice Windows installer uses the language of the operating system. The next part (setup.exe/MSI) is always in English. In his comment - https://bugs.freedesktop.org/show_bug.cgi?id=32389#c5 - Michael Meeks wrote: "Wrt. an English install - this is a feature-not-bug". Can you

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

2011-01-13 Thread Michael Meeks
Hi Pierre, On Sat, 2011-01-08 at 00:15 +0100, Pierre-André Jacquod wrote: > >> The filter, despite write is not usable (no export). ... > >> So ideally could it be: not export, READONLY and pop-up ?? :- / > > I'd still prefer not to set the read-only flag if possible, it is a > > After playing a b

Re: [Libreoffice] Debug build of sw vs system-libxml

2011-01-13 Thread Miklos Vajna
On Thu, Jan 13, 2011 at 08:35:14AM +0100, David Tardon wrote: > Well, the sw.mk makefile is included in all makefiles in sw, but > sw/source/core/inc/frame.hxx is only used in core. So if you wanted to > be really picky, you should create a new makefile containing the change > and only include it

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Michael Meeks changed: What|Removed |Added Depends on|32930 | --- Comment #64 from Michael Meeks 201

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 --- Comment #63 from Petr Mladek 2011-01-13 02:44:51 PST --- (In reply to comment #60) > Nominate Bug #32991 - FORMATTING TABLES Alignment lost when exporting to DOC > It is regression. Many people use tables, many people export to doc. > Would b

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 glepp...@gmx.de changed: What|Removed |Added Depends on||32930 --- Comment #62 from glepp...@gmx

Re: [Libreoffice] [libreoffice-l10n] Created branch libreoffice-3-3-0

2011-01-13 Thread Petr Mladek
Petr Mladek píše v St 12. 01. 2011 v 17:42 +0100: > Now, if you want to switch your clone to the libreoffice-3-3-0 branch, do: > > git pull -r > bin/g pull -r > git checkout -b libreoffice-3-3-3 origin/libreoffice-3-3-3 ^ ^ > g checkout -b li

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

2011-01-13 Thread Michael Meeks
On Thu, 2011-01-13 at 08:50 +0100, Jonathan Aquilina wrote: > Not trying to hijack, but i'm still a novice developer still learning > the ways of development, but is there such a thing as over optimization? Certainly :-) eg. writing in-line assembly for the "button clicked" method (or an

Re: [Libreoffice] flat xml odf

2011-01-13 Thread Michael Meeks
On Thu, 2011-01-13 at 10:08 +0100, Jos van den Oever wrote: > I trust you validated the flat XML with the RNG from the specification. > Do you have a set of test documents in flat or zip format that you use > for testing the import and export of flat xml files? Nope; but really the contai

Re: [Libreoffice] flat xml odf

2011-01-13 Thread Jos van den Oever
On Thursday, January 13, 2011 09:33:49 am Peter Jentsch wrote: > I really only replaced the implementation of the flat format filter with a > lightweight version the requires neither Java nor Xslt. I didn't look at > what the Odf specification says about flat XML, so I can't tell you > inhowfar th

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 tbehr...@novell.com changed: What|Removed |Added Depends on|32991 |33049 -- Configure bugmail: https:

Re: [Libreoffice] flat xml odf

2011-01-13 Thread Peter Jentsch
Hi Jos, I really only replaced the implementation of the flat format filter with a lightweight version the requires neither Java nor Xslt. I didn't look at what the Odf specification says about flat XML, so I can't tell you inhowfar the exported XML conforms to the spec. But in principle, the