Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Thomas Schmitt
Hi, to revive the processing of branch "joliet_multi_extent" i made some experiments: The branch merges without problems with a branch that was freshly created from "master". So i assume that it is good for "master", too. I hacked GNU xorriso to create extents of only 16 KiB each. Macros MAX_ISO

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Rocky Bernstein
Here is a suggestion - in that branch the new ISO image that you created. And then add a new test for this feature. After that passes, then merge the whole thing back into master. My suggestion is to merge to master and let's move forward given that you've tested this. If there are further probl

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Rocky Bernstein
in that branch -> in that branch *add* On Mon, Mar 27, 2023 at 3:56 AM Rocky Bernstein wrote: > Here is a suggestion - in that branch the new ISO image that you created. > And then add a new test for this feature. > > After that passes, then merge the whole thing back into master. > > My suggest

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Rocky Bernstein
Actually, let me change this slightly. After adding the test, then push the *branch *back and let everyone know. I (and possibly others) can check out the branch first. The most common kind of mistake is not adding the files into git and not ensuring this gets into the tarball. There is a "make di

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Thomas Schmitt
Hi, Rocky Bernstein wrote: > Here is a suggestion - in that branch add the new ISO image that you created. > And then add a new test for this feature. It seems easiest to extend test "check_multiextent.sh". (The main obstacle which gave me riddles was missing TZ=CUT when i created multiextent_jol

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Rocky Bernstein
On Mon, Mar 27, 2023 at 7:23 AM Thomas Schmitt wrote: > Hi, > > Rocky Bernstein wrote: > > Here is a suggestion - in that branch add the new ISO image that you > created. > > And then add a new test for this feature. > > It seems easiest to extend test "check_multiextent.sh". > (The main obstacle

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Rocky Bernstein
On Mon, Mar 27, 2023 at 8:49 AM Rocky Bernstein wrote: > > > On Mon, Mar 27, 2023 at 7:23 AM Thomas Schmitt wrote: > >> Hi, >> >> Rocky Bernstein wrote: >> > Here is a suggestion - in that branch add the new ISO image that you >> created. >> > And then add a new test for this feature. >> >> It s

Re: [Libcdio-devel] CD-Text support for macOS and Windows

2023-03-27 Thread Robert Kausch via Libcdio-devel
Am 26.03.2023 um 22:58 schrieb Rocky Bernstein: On Fri, Mar 24, 2023 at 3:58 AM Rocky Bernstein wrote: For what it is worth, I was able to build the current master on Windows 10 pro and Msys2. I suspect though that master doesn't have Robert's latest patches. No, the Windows CD-Text patches are

Re: [Libcdio-devel] Can we merge branch "joliet_multi_extent" ?

2023-03-27 Thread Thomas Schmitt
Hi, i pushed branch "joliet_multi_extent" with a new commit cb03533aaba6113465b19157577e631e26406c7e "Add test for proper handling of multi-extent files in the Joliet tree" Please review and/or test. Especially (cd test && ./check_multiextent.sh ) should report: -- ./check_multiextent.sh: