in that branch -> in that branch *add* On Mon, Mar 27, 2023 at 3:56 AM Rocky Bernstein <ro...@gnu.org> wrote:
> Here is a suggestion - in that branch the new ISO image that you created. > And then add a new test for this feature. > > After that passes, then merge the whole thing back into master. > > My suggestion is to merge to master and let's move forward given that > you've tested this. > > If there are further problems we can address them down the line. > > Thanks - and have a good (and NOT stressful) day. > > On Mon, Mar 27, 2023 at 3:23 AM Thomas Schmitt <scdbac...@gmx.net> wrote: > >> Hi, >> >> to revive the processing of branch "joliet_multi_extent" i made some >> experiments: >> >> The branch merges without problems with a branch that was freshly >> created from "master". So i assume that it is good for "master", too. >> >> I hacked GNU xorriso to create extents of only 16 KiB each. >> Macros MAX_ISO_FILE_SECTION_SIZE and ISO_EXTENT_SIZE in libisofs/ecma119.h >> were set to 16384. Then i created an ISO image with Joliet and without >> Rock Ridge of a file with ~360 KiB (actually /bin/tar): >> >> xorriso -compliance no_emul_toc -padding 0 -joliet on -rockridge off \ >> -outdev joliet_multi_extent.iso \ >> -map /bin/tar /FileWithManyExtents >> >> Inspection by >> xorriso -indev joliet_multi_extent.iso -toc -find / -exec report_lba -- >> shows that Joliet was loaded and the file is represented by 22 extents: >> >> Media blocks : 208 readable , 188491924 writable , 188492148 overall >> ISO offers : Joliet >> ISO loaded : Joliet >> ... >> Report layout: xt , Startlba , Blocks , Filesize , ISO image path >> File data lba: 0 , 33 , 8 , 358072 , >> '/FileWithManyExtents' >> ... >> File data lba: 21 , 201 , 7 , 358072 , >> '/FileWithManyExtents' >> >> I get from the programs of branch "joliet_multi_extent": >> >> $ iso-info -i joliet_multi_extent.iso -l >> ... >> Joliet Level: 3 >> ... >> - [LSN 33] 358072 Nov 08 2014 19:48:38 FileWithManyExtents >> >> $ iso-read --image=joliet_multi_extent.iso \ >> --extract=FileWithManyExtents --output-file=../tar_from_iso >> $ diff tar_from_iso /bin/tar >> $ >> >> So for me it looks ready for merging. >> Other, more realistic experiments would be welcome. >> >> >> Have a nice day :) >> >> Thomas >> >> >>