Re: [lfs-dev] procps-ng tests

2013-04-09 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 07/04/2013 18:54, Bruce Dubbs a écrit : >> Pierre Labastie wrote: >>> Le 06/04/2013 18:42, Bruce Dubbs a écrit : Pierre Labastie wrote: > sed -i -r 's|(a-z\\])\+|\1\\{3\\}|' testsuite/vmstat.test/vmstat.exp > should be OK, even if it happens that a loop

Re: [lfs-dev] procps-ng tests

2013-04-09 Thread Pierre Labastie
Le 07/04/2013 18:54, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 06/04/2013 18:42, Bruce Dubbs a écrit : >>> Pierre Labastie wrote: >>> sed -i -r 's|(a-z\\])\+|\1\\{3\\}|' testsuite/vmstat.test/vmstat.exp should be OK, even if it happens that a loop? is mounted and has more

Re: [lfs-dev] procps-ng tests

2013-04-07 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 06/04/2013 18:42, Bruce Dubbs a écrit : >> Pierre Labastie wrote: >> > >>> sed -i -r 's|(a-z\\])\+|\1\\{3\\}|' testsuite/vmstat.test/vmstat.exp >>> should be OK, even if it happens that a loop? is mounted and has more >>> than ten reads. >> >> Since we are looking for *p

Re: [lfs-dev] procps-ng tests

2013-04-07 Thread Pierre Labastie
Le 06/04/2013 18:42, Bruce Dubbs a écrit : > Pierre Labastie wrote: > >> sed -i -r 's|(a-z\\])\+|\1\\{3\\}|' testsuite/vmstat.test/vmstat.exp >> should be OK, even if it happens that a loop? is mounted and has more >> than ten reads. > > Since we are looking for *partitions*, [s|h]d[a-z]\d shoul

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Pierre Labastie
Le 06/04/2013 18:42, Bruce Dubbs a écrit : > Pierre Labastie wrote: > > Since we are looking for *partitions*, [s|h]d[a-z]\d should identify them. > > Right. I am submitting a patch upstream, with all the findings we have made. I do not plan to submit the first pmap patch (suppressing the ending $)

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Bruce Dubbs
Pierre Labastie wrote: > But we could as well disable the tests and wait for upstream to fix them... That seems like a good course of action. Or just put in a note that the test sometimes fails due to timing issues. It has always passed for me. -- Bruce -- http://linuxfromscratch.org/mai

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Bruce Dubbs
Pierre Labastie wrote: >> It still looks like a race condition (what is the order of >> entries in /proc/diskstats) or just a logic error in the test to me. Looks that way to me too. > Usually, I get the same as you (except loop is always at the end). It > happened only twice during the last wee

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Pierre Labastie
Le 03/04/2013 19:22, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 03/04/2013 08:03, Bruce Dubbs a écrit : >>> Bruce Dubbs wrote: >>> To make that pass, we need to do: sed -i -r >>> 's/(pmap_initname)\\\$/\1/' ./testsuite/pmap.test/pmap.exp >> Actually, a similar sed was in the previous vers

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Pierre Labastie
Le 06/04/2013 10:42, Pierre Labastie a écrit : >> Now, I have a new test failure in pmap: >> FAIL: pmap extra extended output (footer) >> :-( >> Needs more testing, but the behavior seems to be different when running >> in jhalfs and by hand... I think I have got the picture. jhalfs is not at fault

Re: [lfs-dev] procps-ng tests

2013-04-06 Thread Pierre Labastie
Le 05/04/2013 23:58, Bruce Dubbs a écrit : > > > I suppose it could be a problem with kvm or vmstat. > > Checking with qemu-1.4: > > ARGS="-enable-kvm -hda lfs73.img" > MEM="-m 2G" > CDROM="-cdrom lfslivecd-x86_64-6.3-r2160-updated-nosrc.iso" > NIC="-net nic -net tap" > sudo qemu $ARGS $CDROM $NIC

Re: [lfs-dev] procps-ng tests

2013-04-05 Thread Bruce Dubbs
Pierre Labastie wrote: > pierre@debian32-virt:~$ cat /proc/diskstats > 2 0 fd0 0 0 0 0 0 0 0 0 0 0 0 > 11 0 sr0 19 0 152 136 0 0 0 0 0 136 136 > 8 0 sda 32783 8723 2567928 84792 336771 8561249 71767606 > 11478240 0 1477316 11607988 >>

Re: [lfs-dev] procps-ng tests

2013-04-05 Thread Pierre Labastie
Le 04/04/2013 23:37, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 04/04/2013 18:08, Bruce Dubbs a écrit : >>> Pierre Labastie wrote: Le 03/04/2013 00:26, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 02/04/2013 19:39, Bruce Dubbs a écrit : >>> I was meaning to bring

Re: [lfs-dev] procps-ng tests

2013-04-04 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 04/04/2013 18:08, Bruce Dubbs a écrit : >> Pierre Labastie wrote: >>> Le 03/04/2013 00:26, Bruce Dubbs a écrit : Pierre Labastie wrote: > Le 02/04/2013 19:39, Bruce Dubbs a écrit : >> I was meaning to bring this up again. I get >> >> Running ./pmap.t

Re: [lfs-dev] procps-ng tests

2013-04-04 Thread Pierre Labastie
Le 04/04/2013 18:08, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 03/04/2013 00:26, Bruce Dubbs a écrit : >>> Pierre Labastie wrote: Le 02/04/2013 19:39, Bruce Dubbs a écrit : > I was meaning to bring this up again. I get > > Running ./pmap.test/pmap.exp ... > FAIL: pma

Re: [lfs-dev] procps-ng tests

2013-04-04 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 03/04/2013 00:26, Bruce Dubbs a écrit : >> Pierre Labastie wrote: >>> Le 02/04/2013 19:39, Bruce Dubbs a écrit : I was meaning to bring this up again. I get Running ./pmap.test/pmap.exp ... FAIL: pmap X with unreachable process FAIL: pmap XX with

Re: [lfs-dev] procps-ng tests

2013-04-04 Thread Pierre Labastie
Le 03/04/2013 00:26, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 02/04/2013 19:39, Bruce Dubbs a écrit : >>> I was meaning to bring this up again. I get >>> >>> Running ./pmap.test/pmap.exp ... >>> FAIL: pmap X with unreachable process >>> FAIL: pmap XX with unreachable process > That mean

Re: [lfs-dev] procps-ng tests

2013-04-03 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 03/04/2013 08:03, Bruce Dubbs a écrit : >> Bruce Dubbs wrote: >> To make that pass, we need to do: sed -i -r >> 's/(pmap_initname)\\\$/\1/' ./testsuite/pmap.test/pmap.exp > Actually, a similar sed was in the previous version of the page. It got > suppressed when updatin

Re: [lfs-dev] procps-ng tests

2013-04-03 Thread Pierre Labastie
Le 03/04/2013 08:03, Bruce Dubbs a écrit : > Bruce Dubbs wrote: > To make that pass, we need to do: sed -i -r > 's/(pmap_initname)\\\$/\1/' ./testsuite/pmap.test/pmap.exp Actually, a similar sed was in the previous version of the page. It got suppressed when updating to the new version of procps

Re: [lfs-dev] procps-ng tests

2013-04-03 Thread Pierre Labastie
Le 03/04/2013 08:03, Bruce Dubbs a écrit : > I'm pretty sure I tracked down this problem. In pmap.exp there is: > > spawn $pmap -X 1 > expect_pass $test "$pmap_initname\$" > > and spawn is doing some things with stty and the pmap program's newline > characters are being converted to \r\n. The exp

Re: [lfs-dev] procps-ng tests

2013-04-03 Thread Pierre Labastie
Le 03/04/2013 00:26, Bruce Dubbs a écrit : > Pierre Labastie wrote: >> Le 02/04/2013 19:39, Bruce Dubbs a écrit : >> >>> I think the pmap tests issues have something to do with jhalfs as I >>> can't get it to fail outside of the full jhalfs build. >> Problem is: the tests passed three times on 64 b

Re: [lfs-dev] procps-ng tests

2013-04-02 Thread Bruce Dubbs
Bruce Dubbs wrote: > Bruce Dubbs wrote: > >> pmap: Unknown format in smaps file! > >> This indicates a kernel issue to me. Indeed, looking at /proc/1/smaps, >> it looks quite different from /proc/1/maps. The pmap.c code does: >> >> fields = sscanf(mapbuf,... >> if (nfields < 6) >> xerrx(EXI

Re: [lfs-dev] procps-ng tests

2013-04-02 Thread Bruce Dubbs
Bruce Dubbs wrote: > pmap: Unknown format in smaps file! > This indicates a kernel issue to me. Indeed, looking at /proc/1/smaps, > it looks quite different from /proc/1/maps. The pmap.c code does: > > fields = sscanf(mapbuf,... > if (nfields < 6) > xerrx(EXIT_FAILURE, _("Unknown format i

Re: [lfs-dev] procps-ng tests

2013-04-02 Thread Bruce Dubbs
Pierre Labastie wrote: > Le 02/04/2013 19:39, Bruce Dubbs a écrit : >> >> I was meaning to bring this up again. I get >> >> Running ./pmap.test/pmap.exp ... >> FAIL: pmap X with unreachable process >> FAIL: pmap XX with unreachable process That means that it can't find /proc/1. If /proc is mounte

Re: [lfs-dev] procps-ng tests

2013-04-02 Thread Pierre Labastie
Le 02/04/2013 19:39, Bruce Dubbs a écrit : > > I was meaning to bring this up again. I get > > Running ./pmap.test/pmap.exp ... > FAIL: pmap X with unreachable process > FAIL: pmap XX with unreachable process > > vmstat gives me: > > # of expected passes6 I have not been able to reproduce the /

Re: [lfs-dev] procps-ng tests

2013-04-02 Thread Bruce Dubbs
Pierre Labastie wrote: > Hi, > > I had some problems with a few tests on debian 6.0 32 bits in a VM on 64 > bit hardware. > > First pmap: > > It seems that the test expects 'pmap -X 1' or 'pmap -XX 1' to return > only one line. > This was not the case on the above system : a full map is returned...