Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-05 Thread Karl Palsson
John Crispin wrote: > Hi Karl, > > this comment is completely devoid any usefulness. let me help > by rephrasing it to make it useful. > > "Hi community, > > i have noticed that it is common practice to not annotate the > upstream changes properly in commit bumping the git hash of > packages.

Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-04 Thread John Crispin
Hi Karl, this comment is completely devoid any usefulness. let me help by rephrasing it to make it useful. "Hi community, i have noticed that it is common practice to not annotate the upstream changes properly in commit bumping the git hash of packages. i feel that it would be much better if we

Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-04 Thread Florian Fainelli
On 12/04/2016 03:17 PM, Karl Palsson wrote: > > Florian Fainelli wrote: >> On 12/04/2016 02:53 PM, Karl Palsson wrote: >>> Care to explain what you're updating? This patch is completely >>> devoid of useful information without resorting to external >>> sources. Surely, you have motivation for upd

Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-04 Thread Karl Palsson
Florian Fainelli wrote: > On 12/04/2016 02:53 PM, Karl Palsson wrote: > > Care to explain what you're updating? This patch is completely > > devoid of useful information without resorting to external > > sources. Surely, you have motivation for updating? > > Having this commit below, and the oth

Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-04 Thread Florian Fainelli
On 12/04/2016 02:53 PM, Karl Palsson wrote: > Care to explain what you're updating? This patch is completely > devoid of useful information without resorting to external > sources. Surely, you have motivation for updating? Having this commit below, and the other two make on top which are bugfixes

Re: [LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-04 Thread Karl Palsson
Care to explain what you're updating? This patch is completely devoid of useful information without resorting to external sources. Surely, you have motivation for updating? Sincerely, Karl Palsson Florian Fainelli wrote: > Signed-off-by: Florian Fainelli > --- > package/network/services/odhcp

[LEDE-DEV] [PATCH] odhcpd: Update to 2016-12-01 snapshot

2016-12-03 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- package/network/services/odhcpd/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package/network/services/odhcpd/Makefile b/package/network/services/odhcpd/Makefile index f6ce26c150ef..f8a74b93c911 100644 --- a/package/network