On 12/04/2016 03:17 PM, Karl Palsson wrote: > > Florian Fainelli <f.faine...@gmail.com> wrote: >> On 12/04/2016 02:53 PM, Karl Palsson wrote: >>> Care to explain what you're updating? This patch is completely >>> devoid of useful information without resorting to external >>> sources. Surely, you have motivation for updating? >> >> Having this commit below, and the other two make on top which >> are bugfixes as well: >> >> https://git.lede-project.org/?p=project/odhcpd.git;a=commitdiff;h=374dc3f13623df58275d9da51637976c34be125d > > Great, still need to leave to see what you're actually doing. A > summary is useful for being a summary.
Fair enough, is the git log --oneline output between the two commits good enough, or do we need to go into further details? > >> Mind complaining to whoever does similar updates in the future: > > Absolutely, I'll complain on these commits whenever I see them, > but I can't be everywhere at once. Also, the bad behaviour of > others is no excuse for bad behaviour of your own, and it's lame > to try and use it as an excuse. That was not quite the point, anything that's already accepted in tree serves as baseline/model for future submissions as well, that's all, and in that case, there are tons of updates like these with little to no details, kind of makes you wonder if it is not intentional. -- Florian _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev