Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-20 Thread Gareth Parker
rd in diag.sh and 02_leds? Gareth -Original Message- From: John Crispin [mailto:j...@phrozen.org] Sent: Tuesday, 18 October 2016 7:13 p.m. To: Rafał Miłecki; Gareth Parker Cc: LEDE Development List; gar...@zappie.net.nz Subject: Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 a

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-19 Thread Piotr Dymacz
-Original Message- > From: Lede-dev [mailto:lede-dev-boun...@lists.infradead.org] On Behalf Of > Piotr Dymacz > Sent: Wednesday, 19 October 2016 4:32 p.m. > To: Gareth Parker > Cc: LEDE Development List; gar...@zappie.net.nz > Subject: Re: [LEDE-DEV] [PATCH] Add support for Comfast E3

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-19 Thread Gareth Parker
e-dev-boun...@lists.infradead.org] On Behalf Of Piotr Dymacz Sent: Wednesday, 19 October 2016 4:32 p.m. To: Gareth Parker Cc: LEDE Development List; gar...@zappie.net.nz Subject: Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2 Hello Gareth, Please, take a look how I made support for oth

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-18 Thread Piotr Dymacz
Hello Gareth, Please, take a look how I made support for other Comfast devices (QCA953x based) [1]. I will rebase, update and send PR when I'm back from my holidays. Maybe we could keep everything in one mach-*.c file as there are some common parts, ex. timer for external watchdog. [1] https://

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-18 Thread Gareth Parker
d.org; gar...@zappie.net.nz Subject: Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2 Hi, 2 ordering comments inline. please prefix the patch subject with "ar71xx: " John On 17/10/2016 12:14, Gareth Parker wrote: > The Comfast E380AC is a single port PoE Dual B

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-17 Thread John Crispin
Hi, 2 ordering comments inline. please prefix the patch subject with "ar71xx: " John On 17/10/2016 12:14, Gareth Parker wrote: > The Comfast E380AC is a single port PoE Dual Band AP. > > There are two versions which are only identifiable through the web > administration interface, v1 h

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-17 Thread John Crispin
On 18/10/2016 07:54, Rafał Miłecki wrote: > On 17 October 2016 at 12:14, Gareth Parker wrote: >> The Comfast E380AC is a single port PoE Dual Band AP. >> >> There are two versions which are only identifiable through the web >> administration interface, v1 has 128mb ram and a uboot size of 128k,

Re: [LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-17 Thread Rafał Miłecki
On 17 October 2016 at 12:14, Gareth Parker wrote: > The Comfast E380AC is a single port PoE Dual Band AP. > > There are two versions which are only identifiable through the web > administration interface, v1 has 128mb ram and a uboot size of 128k, v2 has > 256mb ram and a uboot size of 256k, the

[LEDE-DEV] [PATCH] Add support for Comfast E380AC v1 and v2

2016-10-17 Thread Gareth Parker
The Comfast E380AC is a single port PoE Dual Band AP. There are two versions which are only identifiable through the web administration interface, v1 has 128mb ram and a uboot size of 128k, v2 has 256mb ram and a uboot size of 256k, the remaining hardware and PCB markings are the same. The fac