[LEDE-DEV] interests for meeting on 33c3 ?

Hi there, does anybody has interests to have a LEDE meat on 33c3 :) ? nbd, NeoRaider and I had meet together yesterday. cheers Tarek signature.asc Description: OpenPGP digital signature ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://l

[LEDE-DEV] [PATCH] busybox: prevent globbing, word splitting

Double quote to prevent globbing and word splitting. Signed-off-by: Jan-Tarek Butt --- package/utils/busybox/files/cron | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/utils/busybox/files/cron b/package/utils/busybox/files/cron index 19ecc43..a201374 100755 --- a

[LEDE-DEV] [PATCH] busybox: prevent globbing, splitting

Double quote to prevent globbing and word splitting. Signed-off-by: Jan-Tarek Butt --- package/utils/busybox/files/sysntpd | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/package/utils/busybox/files/sysntpd b/package/utils/busybox/files/sysntpd

[LEDE-DEV] [PATCH] ct-bugcheck: fix globbing, word splitting and change formatting

Double quote to prevent globbing and word splitting. Use short syntax to enhance reading quallity. Signed-off-by: Jan-Tarek Butt --- package/utils/ct-bugcheck/src/bugchecker.sh | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/package/utils/ct-bugcheck/src

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

> > On 06/10/2016 16:44, Bastian Bittorf wrote: >> * Jo-Philipp Wich [06.10.2016 16:35]: >>> removing the dollar signs lets expressions succeed which would otherwise >>> fail - which means it introduces a behavior change. >> >> thanks for showing this. i must repeat myself: >> >> before we merge

[LEDE-DEV] [PATCH v3 05/13] scripts: Use cd ... || exit in case cd fails

Signed-off-by: Jan-Tarek Butt --- scripts/clean-package.sh | 1 + scripts/deptest.sh | 4 ++-- scripts/ext-toolchain.sh | 12 ++-- scripts/get_source_date_epoch.sh | 4 +++- scripts/getver.sh| 4 +++- scripts/patch-specs.sh | 2

[LEDE-DEV] [PATCH v3 11/13] scripts: using { cmd1; cmd2; } >> file instead of individual redirects

Signed-off-by: Jan-Tarek Butt --- scripts/config/lxdialog/check-lxdialog.sh | 16 ++-- scripts/diffconfig.sh | 18 +++-- scripts/ext-toolchain.sh | 118 +- 3 files changed, 86 insertions(+), 66 deletions(-) diff --git a/scripts

[LEDE-DEV] [PATCH v3 12/13] scripts: use * instead of @ to concatenate

Signed-off-by: Jan-Tarek Butt --- scripts/config/lxdialog/check-lxdialog.sh | 4 ++-- scripts/ubinize-image.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/config/lxdialog/check-lxdialog.sh b/scripts/config/lxdialog/check-lxdialog.sh index

[LEDE-DEV] [PATCH v3 13/13] scripts: read without -r will mangle backslashes

Signed-off-by: Jan-Tarek Butt --- scripts/clean-package.sh | 4 ++-- scripts/rstrip.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 2de3c51..0940732 100755 --- a/scripts/clean-package.sh +++ b/scripts

[LEDE-DEV] [PATCH v3 08/13] scripts: Use $(..) instead of legacy `..`

Signed-off-by: Jan-Tarek Butt --- scripts/deptest.sh | 4 ++-- scripts/gen-dependencies.sh | 4 ++-- scripts/ipkg-make-index.sh | 4 ++-- scripts/mkits.sh| 4 ++-- scripts/patch-kernel.sh | 2 +- scripts/strip-kmod.sh | 2 +- 6 files changed, 10 insertions(+), 10

[LEDE-DEV] [PATCH v3 09/13] scripts: Argument mixes string and array. Use $*

Signed-off-by: Jan-Tarek Butt --- scripts/mkits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index 99b86a8..24d5367 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -41,7 +41,7 @@ do k ) KERNEL=$OPTARG

[LEDE-DEV] [PATCH v3 10/13] scripts: quote literal {

Signed-off-by: Jan-Tarek Butt --- scripts/getver.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index 67ddc20..14a9e77 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -27,8 +27,8 @@ try_git

[LEDE-DEV] [PATCH v3 06/13] scripts: redirect matters, the 2>&1 has to be last

Signed-off-by: Jan-Tarek Butt --- scripts/make-ipkg-dir.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/make-ipkg-dir.sh b/scripts/make-ipkg-dir.sh index 529e430..ba1a8df 100755 --- a/scripts/make-ipkg-dir.sh +++ b/scripts/make-ipkg-dir.sh @@ -8,10 +8,10

[LEDE-DEV] [PATCH v3 01/13] scripts: Double quote to prevent globbing and word splitting

Signed-off-by: Jan-Tarek Butt --- scripts/arm-magic.sh | 11 ++- scripts/clean-package.sh | 2 +- scripts/combined-ext-image.sh| 10 +- scripts/combined-image.sh| 2 +- scripts/deptest.sh | 12 ++-- scripts/ext-toolchain.sh

[LEDE-DEV] [PATCH v3 07/13] scripts: Quote to prevent word splitting

Signed-off-by: Jan-Tarek Butt --- scripts/combined-ext-image.sh | 2 +- scripts/combined-image.sh | 2 +- scripts/ext-toolchain.sh | 8 scripts/strip-kmod.sh | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/combined-ext-image.sh b/scripts

[LEDE-DEV] [PATCH v3 02/13] scripts: fix formatting

remove whitespaces on end of lines Signed-off-by: Jan-Tarek Butt --- scripts/combined-ext-image.sh | 4 ++-- scripts/flashing/flash.sh | 6 +++--- scripts/patch-kernel.sh | 20 ++-- scripts/rstrip.sh | 2 +- 4 files changed, 16 insertions(+), 16

[LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

Hi, hopefully now all is clear. SoB should now set by all patches. Also I change the commit messages a bit. If something unclear please tell me. For me that is a good praxis to learn it properly :) cheers Tarek Jan-Tarek Butt (13): scripts: Double quote to prevent globbing and word splitting

[LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

Signed-off-by: Jan-Tarek Butt --- scripts/om-fwupgradecfg-gen.sh | 10 +- scripts/ubinize-image.sh | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/om-fwupgradecfg-gen.sh b/scripts/om-fwupgradecfg-gen.sh index 93f6794..5cbb8d1 100644 --- a

[LEDE-DEV] [PATCH v3 03/13] scripts: add and fix shebang

Signed-off-by: Jan-Tarek Butt --- scripts/freebsd.sh | 1 + scripts/om-fwupgradecfg-gen.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/freebsd.sh b/scripts/freebsd.sh index 3107861..a6cca0e 100644 --- a/scripts/freebsd.sh +++ b/scripts/freebsd.sh

[LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

Signed-off-by: Jan-Tarek Butt --- package/boot/uboot-envtools/files/uboot-envtools.sh | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/package/boot/uboot-envtools/files/uboot-envtools.sh b/package/boot/uboot-envtools/files/uboot-envtools.sh index

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

On 10/04/16 14:35, John Crispin wrote: > > > On 04/10/2016 14:31, Jan-Tarek Butt wrote: >> >> >> On 10/04/16 07:35, Mathias Kresin wrote: >>> 04.10.2016 01:49, Jan-Tarek Butt: >>>> Hi, >>>> >>>> Does anyone und

[LEDE-DEV] [PATCH v2] include: add luaSrcDiet call define to package.mk

Signed-off-by: Jan-Tarek Butt --- include/package.mk | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index fa5c4e7..fb76057 100644 --- a/include/package.mk +++ b/include/package.mk @@ -5,6 +5,8 @@ # See /LICENSE for

Re: [LEDE-DEV] [PATCH v2] ct-bugcheck: fix globbing, word splitting and formatting

Hi John, > On 05/10/2016 15:37, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> { cmd1; cmd2; } >> file instead of individual redirects. >> simplifying syntax >> >> Signed-off-by: Jan-Tarek Butt > thanks for the fixe

[LEDE-DEV] [PATCH v2] ct-bugcheck: fix globbing, word splitting and formatting

Double quote to prevent globbing and word splitting. { cmd1; cmd2; } >> file instead of individual redirects. simplifying syntax Signed-off-by: Jan-Tarek Butt --- package/utils/ct-bugcheck/src/bugcheck.sh | 177 ++ 1 file changed, 83 insertions(+), 94 del

[LEDE-DEV] [PATCH v2] nvram: fix globbing, word splitting and arithmetic variables

Double quote to prevent globbing and word splitting. $/${} is unnecessary on arithmetic variables. Remove unused variables Signed-off-by: Jan-Tarek Butt --- package/utils/nvram/files/nvram.init | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a

Re: [LEDE-DEV] Automated shell code debugging

On 10/02/16 18:10, Bastian Bittorf wrote: > * Jan-Tarek Butt [02.10.2016 17:48]: >> As a part of code quallity enhancemend and prevenition. We can do an >> ondemand daemon as engine to >> check all shell scrips. We can use the opensource Project shellcheck [0]. >

Re: [LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

On 10/04/16 14:51, John Crispin wrote: > > > On 04/10/2016 14:47, Jan-Tarek Butt wrote: >> Double quote to prevent globbing and word splitting. >> $/${} is unnecessary on arithmetic variables. >> Remove unused variables > > SoB missing here aswell > Ok,

[LEDE-DEV] [PATCH 2/3] ct-bugcheck: fix globbing, word splitting and formatting

Double quote to prevent globbing and word splitting. { cmd1; cmd2; } >> file instead of individual redirects. --- package/utils/ct-bugcheck/src/bugcheck.sh | 154 +++--- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/package/utils/ct-bugcheck/src/bugcheck.s

[LEDE-DEV] [PATCH 1/3] nvram: fix globbing, word splitting and arithmetic variables

Double quote to prevent globbing and word splitting. $/${} is unnecessary on arithmetic variables. Remove unused variables --- package/utils/nvram/files/nvram.init | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/package/utils/nvram/files/nvram.init

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

On 10/04/16 07:35, Mathias Kresin wrote: > 04.10.2016 01:49, Jan-Tarek Butt: >> Hi, >> >> Does anyone understand what this "variables" in line 24 to 28 are use [0]? >> >> [0] >> https://git.lede-project.org/?p=source.git;a=blob;f=pack

[LEDE-DEV] [PATCH] package/utils/ct-bugcheck/src/bugcheck.sh * Double quote to prevent globbing and word splitting. * { cmd1; cmd2; } >> file instead of individual redirects. * fix formating

Signed-off-by: Jan-Tarek Butt --- package/utils/ct-bugcheck/src/bugcheck.sh | 154 +++--- 1 file changed, 77 insertions(+), 77 deletions(-) diff --git a/package/utils/ct-bugcheck/src/bugcheck.sh b/package/utils/ct-bugcheck/src/bugcheck.sh index 85f70c5..a930440 100755

[LEDE-DEV] [PATCH] package/utils/nvram/files/nvram.init * Double quote to prevent globbing and word splitting. * $/${} is unnecessary on arithmetic variables. * remove unused variables

Signed-off-by: Jan-Tarek Butt --- package/utils/nvram/files/nvram.init | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/package/utils/nvram/files/nvram.init b/package/utils/nvram/files/nvram.init index 467ab28..ec06e7a 100755 --- a/package/utils

[LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

Hi, Does anyone understand what this "variables" in line 24 to 28 are use [0]? [0] https://git.lede-project.org/?p=source.git;a=blob;f=package/boot/uboot-envtools/files/uboot-envtools.sh;h=e21b28367751fdd86897f3a47911f3a3ffbdbdfb;hb=HEAD cheers Tarek signature.asc Description: OpenPGP digita

Re: [LEDE-DEV] Call defines for minifying scripting languages

On 10/03/16 17:00, Bastian Bittorf wrote: > * Jan-Tarek Butt [03.10.2016 16:55]: >> currently I am working on a Shellscript minifyer >> there are not realy exsist one so I write a new one. > > hopefully in haskell 8-) > you made my day 8-) ROFL! > > I think this

Re: [LEDE-DEV] Call defines for minifying scripting languages

On 10/03/16 14:18, Piotr Dymacz wrote: > Hello, > > 2016-10-03 13:14 GMT+02:00 Karl Palsson : >> >> Jan-Tarek Butt wrote: > [snip] >>> 1. Reducing memory size on firmware images. >> >> But will it? They're in the squashfs image, it's alre

Re: [LEDE-DEV] Call defines for minifying scripting languages

On 10/03/16 13:14, Karl Palsson wrote: > > Jan-Tarek Butt wrote: >> Hi, >> >> My Idea ist to create calldefs to minify all scriptes there are >> interpreted by run time. >> >> As example see the mail "[PATCH] LuaSrcDiet call define for lua

[LEDE-DEV] Call defines for minifying scripting languages

Hi, My Idea ist to create calldefs to minify all scriptes there are interpreted by run time. As example see the mail "[PATCH] LuaSrcDiet call define for lua code Minifying". I plan to write also calldefs for shellscripts, python and perl. They brings vareous of features. 1. Reducing memory s

[LEDE-DEV] [PATCH] LuaSrcDiet call define for lua code Minifying

://git.nordwest.freifunk.net/ffnw-firmware/packages/raw/master/hoodselector/luasrc/hoodselector Jan-Tarek Butt (1): add luaSrcDiet call define to package.mk include/package.mk | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) -- 2.10.0 ___ Lede

[LEDE-DEV] [PATCH] add luaSrcDiet call define to package.mk

--- include/package.mk | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index fa5c4e7..fb76057 100644 --- a/include/package.mk +++ b/include/package.mk @@ -5,6 +5,8 @@ # See /LICENSE for more information. # +# Depende

[LEDE-DEV] [PATCH] package/uboot-envtools.sh remove function vals and fix indentation

--- package/boot/uboot-envtools/files/uboot-envtools.sh | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/package/boot/uboot-envtools/files/uboot-envtools.sh b/package/boot/uboot-envtools/files/uboot-envtools.sh index e21b283..ad41e07 100644 --- a/package/

[LEDE-DEV] [PATCH v2] read without -r will mangle backslashes

--- scripts/clean-package.sh | 4 ++-- scripts/rstrip.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 2de3c51..0940732 100755 --- a/scripts/clean-package.sh +++ b/scripts/clean-package.sh @@ -10,14 +10,14 @@

Re: [LEDE-DEV] [patch master 14/15] Expressions don't expand in single quotes, use double quotes for that

Hi Lars, > > I think, this is just a change based on style preferences, or? > Using single quotes specifically for situation where expansion is not intended > feels quite explicite and clear to me - thus personally I would prefer to > stick > with single quotes instead of double quotes combined

Re: [LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

Hi, On 10/01/16 11:09, Oswald Buddenhagen wrote: > On Sat, Oct 01, 2016 at 12:44:36AM +0200, Lars Kruse wrote: >> Am Fri, 30 Sep 2016 22:02:27 +0200 schrieb Jan-Tarek Butt : >> >>> --- >>> scripts/deptest.sh | 8 >>> 1 file changed, 4 insertio

[LEDE-DEV] [PATCH v2] Consider using { cmd1; cmd2; } >> file instead of individual redirects

--- scripts/config/lxdialog/check-lxdialog.sh | 16 ++-- scripts/diffconfig.sh | 18 +++-- scripts/ext-toolchain.sh | 118 +- 3 files changed, 86 insertions(+), 66 deletions(-) diff --git a/scripts/config/lxdialog/check-lxdialog.s

Re: [LEDE-DEV] [patch master 10/15] quote literal {

Hi On 10/01/16 10:57, Oswald Buddenhagen wrote: > On Sat, Oct 01, 2016 at 12:30:22AM +0200, Lars Kruse wrote: >> Am Fri, 30 Sep 2016 22:02:24 +0200 schrieb Jan-Tarek Butt : >> >>> --- >>> scripts/getver.sh | 4 ++-- >>> 1 file changed, 2 insertions(+), 2

[LEDE-DEV] [PATCH v2] Use $(..) instead of legacy `..`

--- scripts/deptest.sh | 4 ++-- scripts/gen-dependencies.sh | 4 ++-- scripts/ipkg-make-index.sh | 4 ++-- scripts/mkits.sh| 4 ++-- scripts/patch-kernel.sh | 2 +- scripts/strip-kmod.sh | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scrip

[LEDE-DEV] [PATCH v2] Quote to prevent word splitting

--- scripts/combined-ext-image.sh | 2 +- scripts/combined-image.sh | 2 +- scripts/ext-toolchain.sh | 8 scripts/strip-kmod.sh | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/combined-ext-image.sh b/scripts/combined-ext-image.sh index 0d7fde

[LEDE-DEV] [PATCH v2] redirect matters, the 2>&1 has to be last.

--- scripts/make-ipkg-dir.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/make-ipkg-dir.sh b/scripts/make-ipkg-dir.sh index 529e430..ba1a8df 100755 --- a/scripts/make-ipkg-dir.sh +++ b/scripts/make-ipkg-dir.sh @@ -8,10 +8,10 @@ ARCH=$4 WD=$(pwd) mkdir -p "$

[LEDE-DEV] [PATCH v2] Use cd ... || exit in case cd fails

--- scripts/clean-package.sh | 1 + scripts/deptest.sh | 4 ++-- scripts/ext-toolchain.sh | 12 ++-- scripts/get_source_date_epoch.sh | 4 +++- scripts/getver.sh| 4 +++- scripts/patch-specs.sh | 2 +- scripts/sysupgrade-tar.sh

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

Hi, On 10/01/16 10:54, Felix Fietkau wrote: > On 2016-10-01 09:44, Oswald Buddenhagen wrote: >> On Fri, Sep 30, 2016 at 10:02:19PM +0200, Jan-Tarek Butt wrote: >>> diff --git a/scripts/get_source_date_epoch.sh >>> b/scripts/get_source_date_epoch.sh >>> -[ -n &

Re: [LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

On 10/01/16 00:05, Lars Kruse wrote: > Hi, > > > Am Fri, 30 Sep 2016 22:02:19 +0200 > schrieb Jan-Tarek Butt : > > >> diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh >> index 5cae341..9efcac5 100755 >> --- a/scripts/clean-packa

[LEDE-DEV] mailman force using ssl

Hi, I reconize that mailman does not redirect automaticaly to ssl Maybe we can change it? Also the default settings sends a password remembering every month. cheers Tarek signature.asc Description: OpenPGP digital signature ___ Lede-dev mailing list

[LEDE-DEV] [patch master 01/15 v2] Double quote to prevent globbing and word splitting

--- scripts/arm-magic.sh | 11 ++- scripts/clean-package.sh | 2 +- scripts/combined-ext-image.sh| 10 +- scripts/combined-image.sh| 2 +- scripts/deptest.sh | 12 ++-- scripts/ext-toolchain.sh | 15 --- sc

Re: [LEDE-DEV] Automated shell code debugging

Hi, On 10/01/16 01:00, Lars Kruse wrote: > Am Sat, 1 Oct 2016 00:11:23 +0200 > schrieb Martin Tippmann : > >> [..] >> I'm not a shell pro but I found it very difficult to impossible to >> write something that passes without any hints/errors. >> >> There is a way to avoid this by using special com

Re: [LEDE-DEV] [patch master 00/15] shell code improvement for /scripts

Hi Alberto, On 09/30/16 23:02, Alberto Bursi wrote: > I'm suspecting he did use shellcheck.net (or its local version, > shellcheck) to find the errors. > > That's a great tool to find all dumb mistakes and bad practices in scripts. > > It's also opensource: > > https://github.com/koalaman/shel

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

On 10/01/16 01:49, Lars Kruse wrote: > Hi Jan-Tarek, > > > Am Sat, 1 Oct 2016 01:27:24 +0200 > schrieb Jan-Tarek Butt : > > >>> Is there a reason for not adding quotes for CE_VERSION and FILE_NUM? >> >> bacause there just nummeric. > > perso

Re: [LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

l now I was always > stopped by the sheer amount of changes necessary. Thank you! I just do some small stuff :) Butt I plan to continiure work on it. > Am Fri, 30 Sep 2016 22:02:15 +0200 > schrieb Jan-Tarek Butt : > >> [..] >> diff --git a/scripts/arm-magic.sh b/scripts/arm

[LEDE-DEV] Automated shell code debugging

Hi thogeter, I have a realy nice idea :) As a part of code quallity enhancemend and prevenition. We can do an ondemand daemon as engine to check all shell scrips. We can use the opensource Project shellcheck [0]. My idea is to do an insatnce on a server: This insatnce can pull the lede repo dai

Re: [LEDE-DEV] [patch master 00/15] shell code improvement for /scripts

On 09/30/16 22:19, John Crispin wrote: > On 30/09/2016 22:02, Jan-Tarek Butt wrote: >> Hi, >> >> I did some bugfixing and code quality improvement for >> all shell scrips inside the dir ./scripts. >> >> cheers >> Tarek > > > Hi Tarek, &g

[LEDE-DEV] [patch master 13/15] To read lines rather than words, pipe/redirect to a 'while read' loop

--- scripts/deptest.sh | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/deptest.sh b/scripts/deptest.sh index 8c859ef..0b0e7a9 100755 --- a/scripts/deptest.sh +++ b/scripts/deptest.sh @@ -86,9 +86,9 @@ test_package() # $1=pkgname [ -n "$pkg" -a -z "$(echo

[LEDE-DEV] [patch master 05/15] Use cd ... || exit in case cd fails

--- scripts/clean-package.sh | 4 ++-- scripts/deptest.sh | 4 ++-- scripts/ext-toolchain.sh | 12 ++-- scripts/get_source_date_epoch.sh | 2 +- scripts/getver.sh| 2 +- scripts/patch-specs.sh | 2 +- scripts/sysupgrade-tar.sh

[LEDE-DEV] [patch master 15/15] read without -r will mangle backslashes

--- scripts/clean-package.sh | 4 ++-- scripts/rstrip.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 9efcac5..061a3c3 100755 --- a/scripts/clean-package.sh +++ b/scripts/clean-package.sh @@ -9,14 +9,14 @@

[LEDE-DEV] [patch master 07/15] Quote to prevent word splitting

--- scripts/combined-ext-image.sh | 2 +- scripts/combined-image.sh | 2 +- scripts/ext-toolchain.sh | 8 scripts/strip-kmod.sh | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/combined-ext-image.sh b/scripts/combined-ext-image.sh index 0d7fd

[LEDE-DEV] [patch master 08/15] Use $(..) instead of legacy `..`

--- scripts/deptest.sh | 4 ++-- scripts/gen-dependencies.sh | 4 ++-- scripts/ipkg-make-index.sh | 4 ++-- scripts/mkits.sh| 4 ++-- scripts/patch-kernel.sh | 2 +- scripts/strip-kmod.sh | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scrip

[LEDE-DEV] [patch master 11/15] Consider using { cmd1; cmd2; } >> file instead of individual redirects

--- scripts/config/lxdialog/check-lxdialog.sh | 16 +++- scripts/diffconfig.sh | 16 +++- scripts/ext-toolchain.sh | 43 +-- 3 files changed, 42 insertions(+), 33 deletions(-) diff --git a/scripts/config/lxdialog/che

[LEDE-DEV] [patch master 00/15] shell code improvement for /scripts

Hi, I did some bugfixing and code quality improvement for all shell scrips inside the dir ./scripts. cheers Tarek Jan-Tarek Butt (15): Double quote to prevent globbing and word splitting code style: remove whitespaces on end of lines Add and fix a shebang $/${} is unnecessary on

[LEDE-DEV] [patch master 10/15] quote literal {

--- scripts/getver.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index f8b4ed3..27f246e 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -25,8 +25,8 @@ try_git() { ;; *) BRANCH="$(gi

[LEDE-DEV] [patch master 14/15] Expressions don't expand in single quotes, use double quotes for that

--- scripts/deptest.sh | 2 +- scripts/ext-toolchain.sh | 24 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/scripts/deptest.sh b/scripts/deptest.sh index 0b0e7a9..2b156b3 100755 --- a/scripts/deptest.sh +++ b/scripts/deptest.sh @@ -88,7 +88,7 @@ t

[LEDE-DEV] [patch master 01/15] Double quote to prevent globbing and word splitting

--- scripts/arm-magic.sh | 12 ++-- scripts/clean-package.sh | 2 +- scripts/combined-ext-image.sh| 10 +- scripts/combined-image.sh| 2 +- scripts/deptest.sh | 12 ++-- scripts/ext-toolchain.sh | 16

[LEDE-DEV] [patch master 02/15] code style: remove whitespaces on end of lines

--- scripts/combined-ext-image.sh | 4 ++-- scripts/flashing/flash.sh | 6 +++--- scripts/patch-kernel.sh | 20 ++-- scripts/rstrip.sh | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) diff --git a/scripts/combined-ext-image.sh b/scripts/combined-

[LEDE-DEV] [patch master 09/15] Argument mixes string and array. Use $*

--- scripts/mkits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index cf176af..937f712 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -41,7 +41,7 @@ do k ) KERNEL=$OPTARG;; o ) OUTPUT=$OPTARG;;

[LEDE-DEV] [patch master 06/15] redirect matters, the 2>&1 has to be last.

--- scripts/make-ipkg-dir.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/make-ipkg-dir.sh b/scripts/make-ipkg-dir.sh index 529e430..9e38df5 100755 --- a/scripts/make-ipkg-dir.sh +++ b/scripts/make-ipkg-dir.sh @@ -9,9 +9,9 @@ WD=$(pwd) mkdir -p "$TARGET/CONTRO

[LEDE-DEV] [patch master 03/15] Add and fix a shebang

--- scripts/freebsd.sh | 1 + scripts/om-fwupgradecfg-gen.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/freebsd.sh b/scripts/freebsd.sh index 3107861..a6cca0e 100644 --- a/scripts/freebsd.sh +++ b/scripts/freebsd.sh @@ -1 +1,2 @@ +#!/bin/sh env PACK

[LEDE-DEV] [patch master 04/15] $/${} is unnecessary on arithmetic variables

--- scripts/om-fwupgradecfg-gen.sh | 10 +- scripts/ubinize-image.sh | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/om-fwupgradecfg-gen.sh b/scripts/om-fwupgradecfg-gen.sh index 93f6794..5cbb8d1 100644 --- a/scripts/om-fwupgradecfg-gen.sh ++

[LEDE-DEV] [patch master 12/15] use * instead of @ to concatenate

--- scripts/config/lxdialog/check-lxdialog.sh | 4 ++-- scripts/ubinize-image.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/config/lxdialog/check-lxdialog.sh b/scripts/config/lxdialog/check-lxdialog.sh index 02f05ad..0791372 100644 --- a/script

Re: [LEDE-DEV] LEDE Wiki Teambuilding

NameFunction == Martin Tippmann (m...@i3o.de), Jan-Tarek Butt t...@ring0.deInfrastructure / I could take care of nginx, caching, let's encrypt, mysql, php, memcache whatever. Thomas Endt, wiki admin / enabler / mainte

Re: [LEDE-DEV] A Wiki for LEDE Documentation

Hi, On 09/15/16 20:02, Thomas Endt wrote: >> I think we should avoid forums for now and should lay out the wiki's >> plans in a wiki page and activate a plugin (there are at least a couple >> for docuwiki) to make a "talk" page or "discussion" page like >> Wikipedia's for wiki volunteer interactio

Re: [LEDE-DEV] A Wiki for LEDE Documentation

Hi, > I would definetely wait for Jow to answer on this subject. AFAIK he is quite > busy these days. > A LEDE wiki should be part of the LEDE infrastructure, with proper control > and multiple admins, in order to avoid situations like at the beginning of > this year. > > Give Jow a little time t

Re: [LEDE-DEV] A Wiki for LEDE Documentation

Hi, > Yeah, I'm also willing to dedicate some hours per week to wiki gardening, > whatever wiki technology is chosen. Shall I do set up a dokuwiki on our open wireless community infrastructure? cheers Tarek signature.asc Description: OpenPGP digital signature

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

On 09/08/16 19:38, Thomas Endt wrote: > [Sorry if this message is out-of-thread. I joined the mailinglist only > today] No problem :) > Russel> If you want something that's pretty, hire someone to watch > Russel> RecentChanges and clean stuff up. > > I did this quite intensively in the past, b

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

On 09/08/16 14:19, Russell Senior wrote: >>>>>> "Jan-Tarek" == Jan-Tarek Butt writes: > > Jan-Tarek> Also I wish we can establish a reviewing and applying > Jan-Tarek> process. But I dont know how we can resolv this inside a > Jan-Tarek>

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

On 09/08/16 12:59, Karl Palsson wrote: > > Jan-Tarek Butt wrote: >>> Since I was referenced in that thread on the OpenWrt forum, I'll give my >>> two cents. The documentation initiative I tried to start seemed to >>> fizzle out from the difficulty

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

>> On 09/08/16 11:08, Russell Senior wrote: "Eric" == Eric Schultz writes: >>> >>> Eric> I think the idea of having the hardware support documentation >>> Eric> managed by experts is a good idea. Non-experts can, and should, >>> Eric> have plenty of areas to contribute but I don't see thi

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

On 09/08/16 11:08, Russell Senior wrote: >> "Eric" == Eric Schultz writes: > > Eric> I think the idea of having the hardware support documentation > Eric> managed by experts is a good idea. Non-experts can, and should, > Eric> have plenty of areas to contribute but I don't see this area as

Re: [LEDE-DEV] Documentation for router support means the famous Table of Hardware

> Since I was referenced in that thread on the OpenWrt forum, I'll give my > two cents. The documentation initiative I tried to start seemed to > fizzle out from the difficulty in getting the front page of the wiki > changed to be more useful. When changes didn't seem possible (and it > wasn't clea

[LEDE-DEV] Documentation for router support means the famous Table of Hardware

Hi, I am Tarek. ndb and I had discuss about the hardware support documentation for LEDE. So I send these proposal to create a asciidoc documentation nearly similar to the OpenWRT table of hardware. The idea is to create a Main table were users can fast and easily search for devices. Each device sh

[LEDE-DEV] Release in view?

Hi, I think this question is not new .. and many people are looking curious to the LEDE project. I search on this list for discussions about a first release, but maybe I didn't find it or it does not exist. So I have decided to ask here for a schedule of a first LEDE Release. If there any data