> > On 06/10/2016 16:44, Bastian Bittorf wrote: >> * Jo-Philipp Wich <j...@mein.io> [06.10.2016 16:35]: >>> removing the dollar signs lets expressions succeed which would otherwise >>> fail - which means it introduces a behavior change. >> >> thanks for showing this. i must repeat myself: >> >> before we merge such cleanups, we should write tests >> and checkers for proving that nothing break. >> >> bye, bastian > > @Jan-Tarek: 3rd time i am asking this now and i really would like a > reply. do you runtime test these script changes. > Yes I did a runtime check.
for interisting .. I compare the output 1 tata@runner02 ~/lede (git)-[master] % diff ../fwupgrade.cfg-MR900 ./build_dir/target-mips_24kc_musl-1.1.15/fwupgrade.cfg-MR900 3,5c3,5 < md5sum=bffeed9e24c25e12259591510fa0e8c9 < filemd5sum=bffeed9e24c25e12259591510fa0e8c9 < filesha256sum=00118e0cd59cd6471831442c0a748366432114179629e634d29c762debb612c3 --- > md5sum=2408dcda9924d3d42ea742372fc52ee4 > filemd5sum=2408dcda9924d3d42ea742372fc52ee4 > filesha256sum=ec37a88ed639230cbd912e7590c6aeadbf9864ae9f47b3c7019508d312c63b84 13,15c13,15 < md5sum=3ee7a2e278a8c519861750987eda0046 < filemd5sum=c0aed0e99e16f37ce013194a2745b302 < filesha256sum=f13e1184d593661540de5d50fdacaebee496fcbf883bf43d24ab91a08c30b9f5 --- > md5sum=6261467410954bfa43b886c62e3bf354 > filemd5sum=711e7155b17550a6037407a6eec552d6 > filesha256sum=36333f26759c8750f234ef53c649747b9cc074e48c1f56ec77d655460087a5b6 Everythig is fine cheers Tarek
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
