Re: [LEDE-DEV] [wiki]Wiki structure

2016-10-06 Thread Thomas Endt
> the wiki's "full version" (the desktop version) lacks the navigation > panel on the left side. > To get anywhere I need to switch to "mobile version". > > -Alberto Fixed. Thomas ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.in

Re: [LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

2016-10-06 Thread Oswald Buddenhagen
this commit message is cryptic; i had to read the patch to understand what you mean. there seems to be a pattern. ;) also, technically speaking, you're not _fixing_ the indentation, as it was canonical. you're using a less known shell feature to _improve_ it. (fwiw, i dislike that the syntax _requ

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Jan-Tarek Butt
> > On 06/10/2016 16:44, Bastian Bittorf wrote: >> * Jo-Philipp Wich [06.10.2016 16:35]: >>> removing the dollar signs lets expressions succeed which would otherwise >>> fail - which means it introduces a behavior change. >> >> thanks for showing this. i must repeat myself: >> >> before we merge

Re: [LEDE-DEV] [wiki]Wiki structure

2016-10-06 Thread Alberto Bursi
On 10/06/2016 02:14 PM, Rich Brown wrote: > The "experimental" section of the Wiki now substantially clones the entire > web presence of www.lede-project.org. See the update info at: > https://wiki.lede-project.org/talk:to_do_list > > Rich > ___ the

[LEDE-DEV] meetup for beer on Tuesday 11 Oct, Berlin

2016-10-06 Thread Alexander Couzens
Hi all, thanks to the ELCE, a lot of us (OpenWrt LEDE) will be in Berlin next week. I would like to invite you to the c-base on Tuesday, 11 Oct, starting at 20:00 to drink something and talk. The c-base is a broken space station in Berlin, near the train station Jannowitzbrücke [1] [2]. If you h

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread John Crispin
On 06/10/2016 16:44, Bastian Bittorf wrote: > * Jo-Philipp Wich [06.10.2016 16:35]: >> removing the dollar signs lets expressions succeed which would otherwise >> fail - which means it introduces a behavior change. > > thanks for showing this. i must repeat myself: > > before we merge such cle

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Bastian Bittorf
* Jo-Philipp Wich [06.10.2016 16:35]: > removing the dollar signs lets expressions succeed which would otherwise > fail - which means it introduces a behavior change. thanks for showing this. i must repeat myself: before we merge such cleanups, we should write tests and checkers for proving that

[LEDE-DEV] [PATCH] Correct kernel sign-off docs reference

2016-10-06 Thread Marvin Arnold
Fix typo in patching instructions for web. Should reference Section 1.11 not 1.1 of Linux Kernel patches guide. Signed-off-by: Marvin Arnold --- development.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development.txt b/development.txt index 66c80c1..7b3256e 100644 -

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Jo-Philipp Wich
Hi, removing the dollar signs lets expressions succeed which would otherwise fail - which means it introduces a behavior change. root@jj:~# ash -c 'echo $((undef1 + undef2))' 0 root@jj:~# ash -c 'echo $(($undef1 + $undef2))' ash: arithmetic syntax error root@jj:~# ~ Jo _

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Sebastian Moeller
Hi Bastian, On October 6, 2016 2:09:01 PM GMT+02:00, Bastian Bittorf wrote: >* Sebastian Moeller [06.10.2016 13:48]: >> It might be not be necessary, but does it hurt? Are you concerned >that the current practice will hide variables changing their "type" >from arithmetic and that removing the $

[LEDE-DEV] netifd question(s) about moving a device from one bridge to another

2016-10-06 Thread Alexandru Ardelean
Hello, So, this question is addressed mostly to Felix. But if anyone else has some input, feel free to add. http://git.openwrt.org/?p=project/netifd.git;a=blob;f=bridge.c;h=8e6c9a61e6300837ff2f39f8f379f176c4f14aa7;hb=HEAD#l275 That bit of code seem to have been added ~2012. Via commit: http://g

Re: [LEDE-DEV] [wiki]Wiki structure proposals and some questions

2016-10-06 Thread Rich Brown
The "experimental" section of the Wiki now substantially clones the entire web presence of www.lede-project.org. See the update info at: https://wiki.lede-project.org/talk:to_do_list Rich ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://li

[LEDE-DEV] [PATCH] ar71xx: move dragino2 from legacy to generic

2016-10-06 Thread Karl Palsson
Tested on real hardware with r1804. Signed-off-by: Karl Palsson --- target/linux/ar71xx/image/generic.mk| 10 ++ target/linux/ar71xx/image/legacy-devices.mk | 6 -- target/linux/ar71xx/image/legacy.mk | 2 -- 3 files changed, 10 insertions(+), 8 deletions(-) diff -

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Bastian Bittorf
* Sebastian Moeller [06.10.2016 13:48]: > It might be not be necessary, but does it hurt? Are you concerned that the > current practice will hide variables changing their "type" from arithmetic > and that removing the $ prefix will silence this instead of giving an error > message? Or does this

Re: [LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Sebastian Moeller
Hi Jan-Tarek, It might be not be necessary, but does it hurt? Are you concerned that the current practice will hide variables changing their "type" from arithmetic and that removing the $ prefix will silence this instead of giving an error message? Or does this change improve run time of the sc

Re: [LEDE-DEV] [PATCH] LuaSrcDiet call define for lua code Minifying

2016-10-06 Thread Sebastian Moeller
Hallo Jan-Tarek, Is it true that the mini fixation will make the scripts much harder for a human to parse/understand? If so I humbly believe this makes a great option for people trying to build firmwares for say 4MB flash devices, but seems way more dubious for devices with less extreme storage

[LEDE-DEV] [PATCH v3 05/13] scripts: Use cd ... || exit in case cd fails

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/clean-package.sh | 1 + scripts/deptest.sh | 4 ++-- scripts/ext-toolchain.sh | 12 ++-- scripts/get_source_date_epoch.sh | 4 +++- scripts/getver.sh| 4 +++- scripts/patch-specs.sh | 2

[LEDE-DEV] [PATCH v3 11/13] scripts: using { cmd1; cmd2; } >> file instead of individual redirects

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/config/lxdialog/check-lxdialog.sh | 16 ++-- scripts/diffconfig.sh | 18 +++-- scripts/ext-toolchain.sh | 118 +- 3 files changed, 86 insertions(+), 66 deletions(-) diff --git a/scripts/c

[LEDE-DEV] [PATCH] netifd: Set source address for static address routes

2016-10-06 Thread Kristian Evensen
When using UCI to configure static addresses, netifd does not set the source address of the gateway route. In order to be consistent, also set the source address for subnet routes (this applies to all protocols). Signed-off-by: Kristian Evensen --- interface-ip.c | 4 proto.c| 32 +

[LEDE-DEV] [PATCH v3 12/13] scripts: use * instead of @ to concatenate

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/config/lxdialog/check-lxdialog.sh | 4 ++-- scripts/ubinize-image.sh | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/config/lxdialog/check-lxdialog.sh b/scripts/config/lxdialog/check-lxdialog.sh index d224a

[LEDE-DEV] [PATCH v3 13/13] scripts: read without -r will mangle backslashes

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/clean-package.sh | 4 ++-- scripts/rstrip.sh| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/clean-package.sh b/scripts/clean-package.sh index 2de3c51..0940732 100755 --- a/scripts/clean-package.sh +++ b/scripts/clean

[LEDE-DEV] [PATCH v3 08/13] scripts: Use $(..) instead of legacy `..`

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/deptest.sh | 4 ++-- scripts/gen-dependencies.sh | 4 ++-- scripts/ipkg-make-index.sh | 4 ++-- scripts/mkits.sh| 4 ++-- scripts/patch-kernel.sh | 2 +- scripts/strip-kmod.sh | 2 +- 6 files changed, 10 insertions(+), 10 d

[LEDE-DEV] [PATCH v3 09/13] scripts: Argument mixes string and array. Use $*

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/mkits.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkits.sh b/scripts/mkits.sh index 99b86a8..24d5367 100755 --- a/scripts/mkits.sh +++ b/scripts/mkits.sh @@ -41,7 +41,7 @@ do k ) KERNEL=$OPTARG;;

[LEDE-DEV] [PATCH v3 10/13] scripts: quote literal {

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/getver.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/getver.sh b/scripts/getver.sh index 67ddc20..14a9e77 100755 --- a/scripts/getver.sh +++ b/scripts/getver.sh @@ -27,8 +27,8 @@ try_git() { ;;

[LEDE-DEV] [PATCH v3 06/13] scripts: redirect matters, the 2>&1 has to be last

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/make-ipkg-dir.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/make-ipkg-dir.sh b/scripts/make-ipkg-dir.sh index 529e430..ba1a8df 100755 --- a/scripts/make-ipkg-dir.sh +++ b/scripts/make-ipkg-dir.sh @@ -8,10 +8,10 @@ AR

[LEDE-DEV] [PATCH v3 01/13] scripts: Double quote to prevent globbing and word splitting

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/arm-magic.sh | 11 ++- scripts/clean-package.sh | 2 +- scripts/combined-ext-image.sh| 10 +- scripts/combined-image.sh| 2 +- scripts/deptest.sh | 12 ++-- scripts/ext-toolchain.sh

[LEDE-DEV] [PATCH v3 07/13] scripts: Quote to prevent word splitting

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/combined-ext-image.sh | 2 +- scripts/combined-image.sh | 2 +- scripts/ext-toolchain.sh | 8 scripts/strip-kmod.sh | 1 + 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/scripts/combined-ext-image.sh b/scripts/com

[LEDE-DEV] [PATCH v3 02/13] scripts: fix formatting

2016-10-06 Thread Jan-Tarek Butt
remove whitespaces on end of lines Signed-off-by: Jan-Tarek Butt --- scripts/combined-ext-image.sh | 4 ++-- scripts/flashing/flash.sh | 6 +++--- scripts/patch-kernel.sh | 20 ++-- scripts/rstrip.sh | 2 +- 4 files changed, 16 insertions(+), 16 deletions

[LEDE-DEV] [PATCH v3 00/13] shell code improvement for /scripts

2016-10-06 Thread Jan-Tarek Butt
Hi, hopefully now all is clear. SoB should now set by all patches. Also I change the commit messages a bit. If something unclear please tell me. For me that is a good praxis to learn it properly :) cheers Tarek Jan-Tarek Butt (13): scripts: Double quote to prevent globbing and word splitting

[LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/om-fwupgradecfg-gen.sh | 10 +- scripts/ubinize-image.sh | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/om-fwupgradecfg-gen.sh b/scripts/om-fwupgradecfg-gen.sh index 93f6794..5cbb8d1 100644 --- a/sc

[LEDE-DEV] [PATCH v3 03/13] scripts: add and fix shebang

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- scripts/freebsd.sh | 1 + scripts/om-fwupgradecfg-gen.sh | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/freebsd.sh b/scripts/freebsd.sh index 3107861..a6cca0e 100644 --- a/scripts/freebsd.sh +++ b/scripts/freebsd.sh @@ -

[LEDE-DEV] [PATCH v2] uboot-envtools: remove function vals and fix indentation

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- package/boot/uboot-envtools/files/uboot-envtools.sh | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/package/boot/uboot-envtools/files/uboot-envtools.sh b/package/boot/uboot-envtools/files/uboot-envtools.sh index e21b283

Re: [LEDE-DEV] package/boot/uboot-envtools/files/uboot-envtools.sh

2016-10-06 Thread Jan-Tarek Butt
On 10/04/16 14:35, John Crispin wrote: > > > On 04/10/2016 14:31, Jan-Tarek Butt wrote: >> >> >> On 10/04/16 07:35, Mathias Kresin wrote: >>> 04.10.2016 01:49, Jan-Tarek Butt: Hi, Does anyone understand what this "variables" in line 24 to 28 are use [0]? [0] https

[LEDE-DEV] [PATCH v2] include: add luaSrcDiet call define to package.mk

2016-10-06 Thread Jan-Tarek Butt
Signed-off-by: Jan-Tarek Butt --- include/package.mk | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/include/package.mk b/include/package.mk index fa5c4e7..fb76057 100644 --- a/include/package.mk +++ b/include/package.mk @@ -5,6 +5,8 @@ # See /LICENSE for mo