---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/
---
Review request for Kopete.
Summary
---
I saw that for yahoo - webcam im
tory and code changes done so that it copes w/ the missing lib?
- Cristi
-------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/#review9586
--
images is still trying to send something ("last
picture").
- Cristi
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/#review9589
------
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/
---
(Updated Jan. 9, 2011, 10:35 p.m.)
Review request for Kopete.
Changes
/#review9607
-------
On Jan. 9, 2011, 10:35 p.m., Cristi P wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6312/
&g
sper gets mandatory only if the video part
> > is enabled.
>
> Cristi P wrote:
> hmm.
> I see that that flag disables only reading from user's webcam (I guess
> mostly for Windows, where there's no V4L?). it still doesn't disable
> webcamInvite or re
e code still needs some work IMO. The files you have added look
> > "un-Qt-ish": you could turn that code into a class for a start, and the
> > coding style there does not match the rest of Kopete.
> >
> > Can you work on these issues and submit a new patch?
&
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/
---
(Updated Jan. 15, 2011, 11:13 a.m.)
Review request for Kopete.
Changes
---
macro_log_feature(...)
> > endif
> >
> > in CMakeLists.txt and skip (do not include) webcamimgformat.*
> >
> >
>
> Cristi P wrote:
> Yes, the CMakeLists.txt file could be changed like that, at that moment.
> As for including webcamimgformat
e code still needs some work IMO. The files you have added look
> > "un-Qt-ish": you could turn that code into a class for a start, and the
> > coding style there does not match the rest of Kopete.
> >
> > Can you work on these issues and submit a new patch?
automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/#review9618
---
On Jan. 15, 2011, 11:13 a.m., Cristi P wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6333/
---
Review request for Kopete.
Summary
---
a) seems like yahoo protocol doe
> > (mabye rename the switch ?) and just link to libjasper always as originally
> > suggested.
> > Sorry for the noise ;).
>
> Cristi P wrote:
> Making it or not JasPer libs mandatory is purely a matter of editing a
> bit in the kopete/CMakeLists.txt file, only. Re
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6339/
---
Review request for Kopete.
Summary
---
Receive part:
a) protocol (as re
n Sun, Jan 16, 2011 at 12:33 PM, Cristi P wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6339/
> Review request for Kopete.
> By Cristi P.
> Description
>
> Receive part:
> a) protocol (as reading from various place
wrote:
>This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6333/
>
> Ship it!
>
> Do you have commit access or do you need someone to commit this for you?
>
>
> - Raphael
>
> On January 15th, 2011, 11:58 a.m., Cristi P wrot
l
implementation being hidden?
b) to keep what in memory? I have never used jasper myself either, btw. The
only thing that comes into my mind that we might want to try to keep in memory,
is (and if jasper knows that) the buffer for his internal intermediate
conversion. Of course, adding some cod
her text in there, like "sorry, on this
platform there is no video device support so you can not send webcam image".
- Cristi
-------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/#
now what to ask.
b) I think it crossed my mind to have them in separate patches. don't know what
happened :-)
- Cristi
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6339/#review9677
-
> > line 37
> > <http://svn.reviewboard.kde.org/r/6339/diff/1/?file=44272#file44272line37>
> >
> > Can you change these #define's to const int's?
will do (*static* const int)
I'll have a new patch these days, after testing.
- Cristi
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6339/
---
(Updated Jan. 24, 2011, 10:48 p.m.)
Review request for Kopete.
Changes
---
aphael
>
> On January 24th, 2011, 10:48 p.m., Cristi P wrote:
> Review request for Kopete.
> By Cristi P.
>
> *Updated Jan. 24, 2011, 10:48 p.m.*
> Description
>
> Receive part:
> a) protocol (as reading from various places) suggests that first a HEAD and
> the
> > #include "webcamimgformat.h"
> > #endif
>
> Cristi P wrote:
> I thought I already said my opinion about leaving the webcamimgformat.h +
> .cpp in there but change only the function implementation. Please see my
> comment from Jan 10.
&
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6312/
---
(Updated Jan. 26, 2011, 10:42 p.m.)
Review request for Kopete.
Changes
---
change so I can commit
> it?
>
> One last thing: please use tabs when coding (it's the only entry in Kopete's
> HACKING document ;) -- I've changed your patch locally to use tabs where you
> used spaces, but remember that when working on your next patches.
>
>
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6421/
---
Review request for Kopete.
Summary
---
see linked bug report. Basically
---
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6422/
---
Review request for Kopete.
Summary
---
while looking for cause of dupli
Thanks for the review and for the changes. I'll try to remember them for the
next patches.
Review request closed.
You might want to check the other 2 review requests I just added :-)
On Sat, Jan 29, 2011 at 3:15 PM, Raphael Kubo da Costa wrote:
> Cristi P writes:
>
> > Go
--
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6421/#review9754
---
On Jan. 29, 2011, 3:39 p.m., Cristi P wrote:
>
> ---
g/r/6422/#review9756
---
On Jan. 29, 2011, 3:46 p.m., Cristi P wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://svn.review
on me. you can remove that.
- Cristi
-------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6422/#review9761
---
O
, and so will
> > d->root's, hence the "leak" should not happen.
> >
> > I also did not understand why some objects are being deleted with 'delete
> > foo;' and others with 'foo->deleteLater()'.
> >
> > One last thing: do you kn
a) Heh... I remember I also wanted to keep the logic of deciding if you want
libjasper in a single place and play only from there (you can check the
patches).
b) you still seem to link unconditionally w/ jasper libs
c) you put back the message in there - but, if there's some user that *does*
have
33 matches
Mail list logo
