-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6339/
-----------------------------------------------------------
(Updated Jan. 24, 2011, 10:48 p.m.)
Review request for Kopete.
Changes
-------
changed based on comments received.
Summary
-------
Receive part:
a) protocol (as reading from various places) suggests that first a HEAD and
then GET should be done. Current code was asking them in parallel.
b) fixed the way sending the header was done.
Sending:
a) changed to an async method of doing the send
b) send buffer size is dynamic to try to send as much as possible
c) ... various - made it work.
Maybe fixes also #194833 although I'm not very sure what is that one about.
This addresses bugs and 242557.
https://bugs.kde.org/show_bug.cgi?id=
https://bugs.kde.org/show_bug.cgi?id=242557
Diffs (updated)
-----
trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.h
1216546
trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/receivefiletask.cpp
1216546
trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.h 1216546
trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/sendfiletask.cpp
1216546
Diff: http://svn.reviewboard.kde.org/r/6339/diff
Testing
-------
sending from kopete to pidgin and Yahoo messenger, and the other way around.
Sending was always failing for me.
(and posted a patch to pidgin/libpurple as well :-) )
Thanks,
Cristi
_______________________________________________
kopete-devel mailing list
kopete-devel@kde.org
https://mail.kde.org/mailman/listinfo/kopete-devel
