Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/ --- (Updated May 31, 2012, 4:15 p.m.) Review request for Kopete. Changes -

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/ --- (Updated May 31, 2012, 4:22 p.m.) Review request for Kopete. Changes -

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6960/#review10809 --- /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp <

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread cyberbeat
> On May 31, 2012, 4:29 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nlmpris2.cpp, line 94 > > > > > > Hmmm we have a problem. The nowplaying plugin assume the ::update() > > metho

Re: Review Request: Add support for mpris2 in nowlistening-plugin

2012-05-31 Thread Lamarque Souza
> On May 31, 2012, 4:29 p.m., Lamarque Souza wrote: > > /trunk/KDE/kdenetwork/kopete/plugins/nowlistening/nowlisteningpreferences.cpp, > > line 27 > > > > > > Send the change to klistwidget in a different review pleas