Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated March 13, 2016, 4:24 p.m.) Status -- This change has been m

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated March 11, 2016, 3:24 p.m.) Status -- This change has been m

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated Sept. 2, 2015, 11:50 a.m.) Review request for Kopete, Laurent Mo

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review84195 --- reopening as it is not in kopete master yet protocols/groupw

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Friday 03 July 2015 16:56:46 R.Harish Navnit wrote: > On Fri, Jul 3, 2015 at 4:13 PM, Pali Rohár wrote: > > > > > And closed review on reviewboard means that change is either in master > > branch or change was discarded. > > > Okay, luckily, the reviews that were closed on Review Board so far,

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Fri, Jul 3, 2015 at 4:13 PM, Pali Rohár wrote: > > And closed review on reviewboard means that change is either in master > branch or change was discarded. > Okay, luckily, the reviews that were closed on Review Board so far, can be merged into master, I believe. I'll wait for Laurent to confi

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Friday 03 July 2015 15:25:50 R.Harish Navnit wrote: > On Fri, Jul 3, 2015 at 12:51 PM, Pali Rohár wrote: > > > > > Submitted? But I do not see it in master branch: > > http://quickgit.kde.org/?p=kopete.git&a=shortlog&h=master > > > > So why? Where is problem? > > > I've prepared a separate bra

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Fri, Jul 3, 2015 at 12:51 PM, Pali Rohár wrote: > > Submitted? But I do not see it in master branch: > http://quickgit.kde.org/?p=kopete.git&a=shortlog&h=master > > So why? Where is problem? > I've prepared a separate branch - frameworks[1]. I'm bringing in changes from my scratch repo[2] to t

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Friday 03 July 2015 06:28:53 R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124173/ > --- > > (Upda

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated July 3, 2015, 6:28 a.m.) Status -- This change has been mar

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81975 --- Ship it! Seems good now. Ship it - Laurent Montel On juin

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated June 30, 2015, 2:34 a.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81842 --- protocols/gadu/ui/gadusearch.ui (line 441)

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81837 --- Not quite sure how the whitespaces came in right at the end. S

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated June 29, 2015, 1:34 a.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81782 --- protocols/groupwise/ui/gwcustomstatus.ui (line 77)

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- (Updated June 26, 2015, 7:29 p.m.) Review request for Kopete, Laurent Mon

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/#review81764 --- protocols/gadu/ui/gadusearch.ui (line 441)

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 16:13:18 R.Harish Navnit wrote: > On Thu, Jun 25, 2015 at 7:25 PM, Pali Rohár wrote: > > Sounds good. Do not remember that some defines enable additional > > KDE3/Qt3 member methods. So once you remove defines some other code > > does not have to compile... You need to por

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thu, Jun 25, 2015 at 7:25 PM, Pali Rohár wrote: > > Sounds good. Do not remember that some defines enable additional > KDE3/Qt3 member methods. So once you remove defines some other code does > not have to compile... You need to port those methods too! > Yes. Noted :) Thanks, R.Harish Navnit

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 19:19:18 R.Harish Navnit wrote: > On Thu, Jun 25, 2015 at 7:06 PM, Pali Rohár wrote: > > > > > If there are errors it means that there are more calls to KDE3/Qt3 > > functions... Not all KDE3/Qt3 methods are in headers prefixed with > > K3/Q3. This is reason why I wrote y

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thu, Jun 25, 2015 at 7:06 PM, Pali Rohár wrote: > > If there are errors it means that there are more calls to KDE3/Qt3 > functions... Not all KDE3/Qt3 methods are in headers prefixed with > K3/Q3. This is reason why I wrote you to look at compiler defines and > linker flags > Okay. There is ho

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 18:56:05 R.Harish Navnit wrote: > > > > On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: > >> > >> > >> Just a quick note about your patches which removing KDE3/Qt3 code: > >> > >> Look also at CMakeLists.txt files and remove coresponding KDE3/Qt3 > >> defines ideally wi

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

> > On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: >> >> >> Just a quick note about your patches which removing KDE3/Qt3 code: >> >> Look also at CMakeLists.txt files and remove coresponding KDE3/Qt3 >> defines ideally with linking with KDE3/Qt3 libraries... >> > I'm not really sure how this i

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

Hi Pali, Yes you'd raised this issue earlier too. Forgive my absent mindedness. I'll take a look and update the diff :) Warm Regards. Thanking You, R.Harish Navnit The Enigma On Thu, Jun 25, 2015 at 6:33 PM, Pali Rohár wrote: > On Thursday 25 June 2015 12:4

Re: Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

On Thursday 25 June 2015 12:47:20 R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124173/ > --- > > Rev

Review Request 124173: Replace listViews with TreeWidgets in groupwise protocol

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124173/ --- Review request for Kopete, Laurent Montel and Pali Rohár. Repository: kop