On Friday 03 July 2015 16:56:46 R.Harish Navnit wrote: > On Fri, Jul 3, 2015 at 4:13 PM, Pali Rohár <pali.ro...@gmail.com> wrote: > > > > > And closed review on reviewboard means that change is either in master > > branch or change was discarded. > > > Okay, luckily, the reviews that were closed on Review Board so far, can be > merged into master, I believe. I'll wait for Laurent to confirm this though > :) > > > > So please do not do that! You just complicate it... > > > Okay. Sorry for all the confusion. > > I repeat what I already told: > > > > * qt3 --> qt4 rewrite code can be merged/pushed into master immediately, > > we do not need to wait until all code is ported completely into qt4 > > > > * qt4/kde4 --> qt5/kf5 will be merged into kopete master after full > > kopete codebase will be ported > > > > * if you want to push something into kopete master, prepare new branch > > in your own personal repository (rebased on top of main kopete master) > > and write me what you want to include... I will look at it and if > > everything will be OK I push your changes (from your branch). > > > Just asking out of curiosity, is it okay if I push these changes(qt3->qt4) > once they're approved on Review Board ? I believe I have permission to push > into the Kopete repo. >
Rather I would like to see your commits before pushing them into kopete master, to make sure that you are not going to break something :-) > > Warm Regards. > > Thanking You, > R.Harish Navnit > The Enigma <http://harishnavnit.wordpress.com/> -- Pali Rohár pali.ro...@gmail.com _______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
