Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-02-13 Thread Raphael Kubo da Costa
"Cristi P" writes: > 2nd one - I'm not sure I got it - you'd want to call deleteLater() > even on a possibly NULL object? Ain't that a dangerous territory, with > possible crash depending on platform and compiler? Sorry, this advice is likely to cause crashes and depends on undefined behaviour.

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-02-04 Thread Cristi P
> On Jan. 29, 2011, 9:28 p.m., Raphael Kubo da Costa wrote: > > So you're saying is that on each login a new YahooAccount (which creates a > > Client) is created? Do you know what part of the code creates this object? > > My doubt is this: if the code which does this does not immediately delete

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Raphael Kubo da Costa
> On Jan. 29, 2011, 9:28 p.m., Raphael Kubo da Costa wrote: > > So you're saying is that on each login a new YahooAccount (which creates a > > Client) is created? Do you know what part of the code creates this object? > > My doubt is this: if the code which does this does not immediately delete

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Cristi P
> On Jan. 29, 2011, 9:28 p.m., Raphael Kubo da Costa wrote: > > So you're saying is that on each login a new YahooAccount (which creates a > > Client) is created? Do you know what part of the code creates this object? > > My doubt is this: if the code which does this does not immediately delete

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6422/#review9761 --- So you're saying is that on each login a new YahooAccount (which c

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Cristi P
> On Jan. 29, 2011, 4:51 p.m., Raphael Kubo da Costa wrote: > > Did you happen to run Valgrind to check if these objects were leaking (the > > suppressions file in kdesdk/scripts help hide some useless warnings)? I can > > see that the Task class has some auto-deletion code (it doesn't seem to

Re: Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6422/#review9756 --- Did you happen to run Valgrind to check if these objects were leak

Review Request: yahoo - fix some memory leaks on reconnects

2011-01-29 Thread Cristi P
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6422/ --- Review request for Kopete. Summary --- while looking for cause of dupli