----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6422/#review9761 -----------------------------------------------------------
So you're saying is that on each login a new YahooAccount (which creates a Client) is created? Do you know what part of the code creates this object? My doubt is this: if the code which does this does not immediately delete the previous YahooAccount, then Client's destructor will not be immediately called and the "leak" will continue; if, OTOH, the code does delete the previous YahooAccount, then Client's destructor will be called, and so will d->root's, hence the "leak" should not happen. I also did not understand why some objects are being deleted with 'delete foo;' and others with 'foo->deleteLater()'. One last thing: do you know if the task objects created in methods such as receiveFile() are also being "leaked" this way? trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/client.cpp <http://svn.reviewboard.kde.org/r/6422/#comment10908> No need for this check -- delete on a NULL-pointer does not do anything. - Raphael On Jan. 29, 2011, 3:46 p.m., Cristi P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6422/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 3:46 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > while looking for cause of duplicate incoming messages problems, I found some > missing code that made program recreate some objects. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/client.cpp 1217129 > > Diff: http://svn.reviewboard.kde.org/r/6422/diff > > > Testing > ------- > > sending messages, sending files still work. > put some dump in constructor and destructor of a webcamtask to confirm it was > not deleting the task but just creating new ones - when reconnecting. > > > Thanks, > > Cristi > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
