----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6422/#review9756 -----------------------------------------------------------
Did you happen to run Valgrind to check if these objects were leaking (the suppressions file in kdesdk/scripts help hide some useless warnings)? I can see that the Task class has some auto-deletion code (it doesn't seem to be used in client.cpp, though)? - Raphael On Jan. 29, 2011, 3:46 p.m., Cristi P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6422/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2011, 3:46 p.m.) > > > Review request for Kopete. > > > Summary > ------- > > while looking for cause of duplicate incoming messages problems, I found some > missing code that made program recreate some objects. > > > Diffs > ----- > > trunk/KDE/kdenetwork/kopete/protocols/yahoo/libkyahoo/client.cpp 1217129 > > Diff: http://svn.reviewboard.kde.org/r/6422/diff > > > Testing > ------- > > sending messages, sending files still work. > put some dump in constructor and destructor of a webcamtask to confirm it was > not deleting the task but just creating new ones - when reconnecting. > > > Thanks, > > Cristi > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
