kopete/protocols/jabber/libiris/src/xmpp/xmpp-im/s5b.cpp

2013-06-18 Thread David Faure
Hi, gcc found a nice bug in S5BServer::ss_incomingUDP... · if(port != 0 || port != 1) · · return; Whatever follows, will never be called :-) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 7066: Enable kopete to build with giflib5

2013-03-18 Thread David Faure
message regression), but this is good to get in anyway, fixing compilation is more important. I wonder why this code doesn't just use Qt's builtin GIF support, in any case. - David Faure On March 17, 2013, 11:37 a.m., Raymond Woon

Re: Fix kopete/kdenetwork build against Qt 4.8

2011-08-11 Thread David Faure
g rid of 'virtual' there. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org). ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

[kopete-devel] Fwd: Kopete shows user name in chat

2009-10-01 Thread David Faure
nowing that someone knowingly and affirmatively coded this calls into question the judgment of the entire KDE team. --- -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel

Re: [kopete-devel] Patch for http://techbase.kde.org/Projects/Kopete/JuniorJobs#Page_Up_.22Just_Works.22

2008-12-22 Thread David Faure
can be atBlockStart even if you have entered some text. toPlainText().isEmpty() is slow though. Why not just document()->isEmpty on the QTextEdit, if there is indeed a QTextEdit involved? -- David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE, Ko

Re: [kopete-devel] Wiki error

2008-11-25 Thread David Faure
kde/branches/KDE/4.1/kdenetwork Not applied, this will go out of date too quickly, and nobody will remember to update it :-) -- David Faure, [EMAIL PROTECTED], sponsored by Qt Software @ Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www

Re: [kopete-devel] Patch to be reviewed for a crash fixed in Kopete ( jabber issue )

2008-11-03 Thread David Faure
pabilitiesManager()->capabilitiesEnabled(jid); > +    } > You mean d->capsEnabled = cm && cm->capabilitiesEnabled(jid); no? Your patch is calling the same twice just to set a bool... -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konque

Re: [kopete-devel] Fwd: kopete walletmanager static destruction order

2008-10-29 Thread David Faure
> Now the main problem is that Kopete's connection to the wallet is never > terminated leaving the wallet open unless the user has configured a timer to > close it after a specified interval. So, exactly the same problem happens if kopete crashes, right? -- David Faure, [EMAIL PROTEC

Re: [kopete-devel] [PATCH] Suppress Sending Notification

2008-10-27 Thread David Faure
me that this was something I needed to disable because the other person's client didn't do the right thing :/ I thought it was just some bug in kopete. What do other jabber clients (like e.g. psi) do? Do they have sending notification enabled by default? If not, what about not having it en

Re: [kopete-devel] Code to delete unwanted temporary contacts

2008-10-13 Thread David Faure
from()->deleteContact(). (arrow instead of dot) but I have no idea about the contact api, I'll let someone else answer whether this is the right approach overall. -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffic

Re: [kopete-devel] "Use message stack" setting

2008-10-03 Thread David Faure
ting "open messages instantly". But if someone pings me in private, I don't want that window to open instantly. So I think there's a bug there: when the user joins a group chat, the window _should_ open instantly, no matter what that option says. It's an active action by

Re: [kopete-devel] jabber group chats and history

2008-10-03 Thread David Faure
On Friday 03 October 2008, Olivier Goffart wrote: > Le vendredi 3 octobre 2008, David Faure a écrit : > > On Thursday 02 October 2008, David Faure wrote: > > > when joining a groupchat and getting past discussion, all the lines from > > > people who are not in t

[kopete-devel] jabber group chats and history

2008-10-03 Thread David Faure
On Thursday 02 October 2008, David Faure wrote: > when joining a groupchat and getting past discussion, all the lines from > people > who are not in the chat anymore are missing! > This is due to the "return;" in jabbergroupcontact.cpp line 193, but svn > annotate >

Re: [kopete-devel] Latest trunk crashed with MSN chat open

2008-10-02 Thread David Faure
would be autodetected if you simply did export PKG_CONFIG_PATH=/usr/local/Trolltech/qt/lib/pkgconfig:$PKG_CONFIG_PATH -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffi

Re: [kopete-devel] showDates()

2008-10-02 Thread David Faure
On Thursday 02 October 2008, Olivier Goffart wrote: > Le mercredi 1 octobre 2008, David Faure a écrit : > > So, there is this "Show message dates" checkbox in Behavior / Chat, but it > > appeared to be buggy/ineffective... until I found out that it only effects > &

[kopete-devel] "Use message stack" setting

2008-10-02 Thread David Faure
/ dir itself) Permission to clean that up? I assume the "use message stack" option would be the one to remove, i.e. the last if should be considered always false and the systray would call apply on the oldest event. -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to wo

Re: [kopete-devel] jabber group chats and notifications

2008-10-02 Thread David Faure
On Thursday 02 October 2008, Peter Saint-Andre wrote: > David Faure wrote: > > > it was nice to find that libiris/iris/include/xmpp_message.h defines > > spooled(), set to true when jabber:x:delay was seen, although with a > > strange comment about the method: &quo

Re: [kopete-devel] jabber group chats and notifications

2008-10-02 Thread David Faure
On Thursday 02 October 2008, Matt Rogers wrote: > > On Oct 1, 2008, at 6:10 PM, David Faure wrote: > > > On Wednesday 01 October 2008, David Faure wrote: > >> But as expected there is still a notification for replayed > >> highlighted messages. > >&

Re: [kopete-devel] jabber group chats and notifications

2008-10-01 Thread David Faure
On Wednesday 01 October 2008, David Faure wrote: > But as expected there is still a notification for replayed highlighted > messages. > I need to flag them as "delay delivery". Should I make that a new Importance > level > (VeryLow? Delayed?), or just a separate bool

Re: [kopete-devel] jabber group chats and notifications

2008-10-01 Thread David Faure
quot;. Should I make that a new Importance level (VeryLow? Delayed?), or just a separate bool in Kopete::Message? -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). _

Re: [kopete-devel] jabber group chats and notifications

2008-10-01 Thread David Faure
On Wednesday 01 October 2008, Peter Saint-Andre wrote: > David Faure wrote: > > On Tuesday 30 September 2008, Matt Rogers wrote: > >> On Sep 29, 2008, at 4:20 AM, David Faure wrote: > >> > >>> Hello, > >>> > >>> I'm starting to

[kopete-devel] showDates()

2008-10-01 Thread David Faure
;m not sure about the current use case for showing or not showing the date but I'm quite sure that 3 options -- never, always, when not today -- would be overkill. The question is, which two options do we want to pick among those 3. -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech t

Re: [kopete-devel] jabber group chats and notifications

2008-10-01 Thread David Faure
On Tuesday 30 September 2008, Matt Rogers wrote: > > On Sep 29, 2008, at 4:20 AM, David Faure wrote: > > > Hello, > > > > I'm starting to use kopete, for jabber group chats. > > When joining a channel, I get a week of messages as passive popups, > &

[kopete-devel] jabber group chats and notifications

2008-09-29 Thread David Faure
way to fix this. Would it be ok to add a "Incoming Message in Group Chat" notification type? -- David Faure, [EMAIL PROTECTED], sponsored by Trolltech to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

Re: [kopete-devel] Missing copyright informations / gpl'd code in kdelibs

2007-03-26 Thread David Faure
On Friday 23 March 2007, Michaël Larouche wrote: > Le March 23, 2007 07:47, David Faure a écrit : > > On Friday 23 March 2007, Christian Ehrlicher wrote: > > > - kdeui > > > > I think this is an oversight from the class authors: > > util/kaccelgen.h: GPL (v2+)