----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7066/#review11043 -----------------------------------------------------------
Ship it! Looks ok to me. Could be improved (e.g. the error message regression), but this is good to get in anyway, fixing compilation is more important. I wonder why this code doesn't just use Qt's builtin GIF support, in any case. - David Faure On March 17, 2013, 11:37 a.m., Raymond Wooninck wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/7066/ > ----------------------------------------------------------- > > (Updated March 17, 2013, 11:37 a.m.) > > > Review request for Kopete and David Faure. > > > Description > ------- > > This is a patch to enable Kopete to be compiled with giflib v5, while > keeping backwards compatibility. A similar patch was submitted to kdelibs > earlier > > > Diffs > ----- > > /trunk/KDE/kdenetwork/kopete/protocols/wlm/wlmchatsession.cpp 1344072 > > Diff: http://svn.reviewboard.kde.org/r/7066/diff/ > > > Testing > ------- > > kdenetwork module builds fine with giflib v5 and giflib v4 > > > Thanks, > > Raymond Wooninck > >
_______________________________________________ kopete-devel mailing list kopete-devel@kde.org https://mail.kde.org/mailman/listinfo/kopete-devel
