Cool. Thanks for running down the right number.
Cheers,
Jeff.
> On 11 Oct 2018, at 18:39, John Beard wrote:
>
> Hi Jeff,
>
> I'm not a committer, so you might as well go ahead, rather than
> messing with a one-line patch from me!
>
> Cheers,
>
> John
> On Thu, Oct 11, 2018 at 6:34 PM Jeff
Hi Jeff,
I'm not a committer, so you might as well go ahead, rather than
messing with a one-line patch from me!
Cheers,
John
On Thu, Oct 11, 2018 at 6:34 PM Jeff Young wrote:
>
> Hi John,
>
> That’s the right place to adjust it. There’s also LIST_PADDING which gets
> put in once (rather than
Hi John,
That’s the right place to adjust it. There’s also LIST_PADDING which gets put
in once (rather than per-item), but it looks like LIST_ITEM_PADDING of 6 is
doing the trick.
Are you going to commit that, or do you want me to?
Cheers,
Jeff.
> On 11 Oct 2018, at 18:33, John Beard wrote
Hi Jeff,
It's better now for <= 3 items. For more, it still cuts a little bit
off, but less than before.
I adjusted LIST_ITEM_PADDING to 6, and it seems to hove done the
trick. However, I haven't checked very carefully if I have adjusted
the right thing. Attached are two screenshots, so if you kn
Am Do., 11. Okt. 2018 um 08:58 Uhr schrieb Jeff Young :
> I’ve been finding that saving the filter is unexpected, even when useful.
> And unexpected is always bad, because it erodes one’s confidence in their
> user model. So I think I’ll just remove it.
>
> Anyone else (with current code) able to
Hi John,
I removed the filter retention.
I also adjusted the spacing on GTK. I’ve changed it from what Windows uses to
what OSX uses. It may need yet a 3rd value, so let me know if it’s still too
short with only a few list items (or too tall with a bunch of list items).
Cheers,
Jeff.
> On 1
Hi Jeff,
It doesn't seem to accept spaces for me on GTK (bea75753d).
I don't think retaining the last filter is extremely useful, though
perhaps if you were going around changing a lot of things to the same
net? But that will be a better job for the Object Inspector in future
anyway.
Cheers,
Jo
I’ve been finding that saving the filter is unexpected, even when useful. And
unexpected is always bad, because it erodes one’s confidence in their user
model. So I think I’ll just remove it.
Anyone else (with current code) able to type a space into the filter? The
commits Eeli mentions use
Was the purpose of a0b8755f478f7829ca5 and the one before that to let the
filter field to ignore spacebar? If so, it doesn't seem to work. Editing
the net label in eeshcema's Label Properties dialog apparently has some
excluding code, maybe there's something useful?
Keeping the filter text between
ke 10. lokak. 2018 klo 17.45 Jeff Young (j...@rokeby.ie) kirjoitti:
> I think I managed to fix both return and other printable characters.
>
> Return opens the popup.
> Other printable characters open the popup and start the filtering.
> Shift-return OK’s the dialog.
>
> At least in theory (and in
It's possible to trigger an assert by typing text which isn't found in the
list and then pressing up arrow key.
ASSERT INFO:
../src/gtk/listbox.cpp(719): assert "IsValid(n)" failed in
DoSetSelection(): invalid index in wxListBox::SetSelection
#11 NET_SELECTOR_COMBOPOPUP::onKeyDown() at
/work/ohjel
I think I managed to fix both return and other printable characters.
Return opens the popup.
Other printable characters open the popup and start the filtering.
Shift-return OK’s the dialog.
At least in theory (and in practice on OSX).
Cheers,
Jeff.
> On 10 Oct 2018, at 11:38, Jeff Young wrote:
Hi John,
Thanks for the report. More comments below:
> On 10 Oct 2018, at 11:10, John Beard wrote:
>
> Hi Jeff,
>
> In general it looks very nice.
>
> On GTK+ (Arch), freshly rebased and built today on the new GAL stuff.
>
> * The net field is reachable by tab-traversal. For example, in the
Hi Jeff,
In general it looks very nice.
On GTK+ (Arch), freshly rebased and built today on the new GAL stuff.
* The net field is reachable by tab-traversal. For example, in the
trace properties, it can be reached with "Shift-Tab, Shift-Tab" from
the default focus when the dialog opens.
* It cann
I strongly agree.
On 10/10/2018 10:16 PM, John Beard wrote:
Correct handling of focus, tab-traversal and so on is also important
for accessibility reasons, as well as being indicative of a coherent
UI in general. It's pretty annoying to be able to fill in almost all
of a dialog, but have control
Hi John,
If you’re on Windows or GTK, I’d appreciate it if you could try out the Net
Selector (in Track & Via Properties or Pad Properties) from the keyboard and
tell me how it goes. It’s all good on OSX, but that’s the only machine I have.
Cheers,
Jeff.
> On 10 Oct 2018, at 10:16, John Bear
Hi,
I do (try to) use most dialogs with the keyboard (limited sensation in
my fingers make mice and especially touchpads less useful to me).
Correct handling of focus, tab-traversal and so on is also important
for accessibility reasons, as well as being indicative of a coherent
UI in general. It'
Cool. Thanks for the reports!
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help : https://help.launchpad.net/ListHelp
ti 9. lokak. 2018 klo 17.05 Jeff Young (j...@rokeby.ie) kirjoitti:
> I think you had the latest; the GAL branch should have been up-to-date as
> well.
>
> I’ve found a likely cause of the single-character-filter issue and pushed
> a “fix”.
>
It works with the latest master (808a7d94833f1a). The r
I think you had the latest; the GAL branch should have been up-to-date as well.
I’ve found a likely cause of the single-character-filter issue and pushed a
“fix”.
Cheers,
Jeff.
> On 9 Oct 2018, at 07:49, Eeli Kaikkonen wrote:
>
> Oops, did I have the gal branch installed? I takes a while to
Oops, did I have the gal branch installed? I takes a while to compile and
install the master.
Eeli Kaikkonen
ti 9. lokak. 2018 klo 9.47 Eeli Kaikkonen (eeli.kaikko...@gmail.com)
kirjoitti:
>
>
> ma 8. lokak. 2018 klo 15.29 Jeff Young (j...@rokeby.ie) kirjoitti:
>
>> How’s that Net Selector work
ma 8. lokak. 2018 klo 15.29 Jeff Young (j...@rokeby.ie) kirjoitti:
> How’s that Net Selector working these days? Is all good, or are people
> just tired of reporting issues with it? ;)
>
>
Filter doesn't work as expected, it replaces the previous typed character
with the next one, there's always
Hi Jeff-
Haven't had a chance to look recently. Just checked and it works well
enough to be useful. Still doesn't drop with space/enter on gtk but that's
pretty minor. Feels generally good.
-S
Am Mo., 8. Okt. 2018 um 05:30 Uhr schrieb Jeff Young :
> How’s that Net Selector working these days
23 matches
Mail list logo
