I’ve been finding that saving the filter is unexpected, even when useful. And unexpected is always bad, because it erodes one’s confidence in their user model. So I think I’ll just remove it.
Anyone else (with current code) able to type a space into the filter? The commits Eeli mentions use the same technique as the Label Properties dialog (although they don’t exclude ‘\’ as you may want to search on that). > On 10 Oct 2018, at 21:20, Eeli Kaikkonen <eeli.kaikko...@gmail.com> wrote: > > Was the purpose of a0b8755f478f7829ca5 and the one before that to let the > filter field to ignore spacebar? If so, it doesn't seem to work. Editing the > net label in eeshcema's Label Properties dialog apparently has some excluding > code, maybe there's something useful? > > Keeping the filter text between combobox "sessions" isn't necessarily good, > at least in some cases. If there's nothing to match the filter and it's then > canceled by closing the box the user hardly wants to keep the same > non-working filter text. Or if (s)he doesn't actually select a net matching > the filter. On the other hand it may be wanted after the net has been found > and selected. A good compromise could be to always set the text as selected > (in the filter text field) when the box is opened. Then the first key press > would delete the old text, but the old filtering result would still be > available if there's no need to change it. This requires text selecting and > cursor to work, but now they don't, as John told. Or maybe he didn't mention > text selecting, but it doesn't work anyways. > > -Eeli Kaikkonen > _______________________________________________ > Mailing list: https://launchpad.net/~kicad-developers > Post to : kicad-developers@lists.launchpad.net > Unsubscribe : https://launchpad.net/~kicad-developers > More help : https://help.launchpad.net/ListHelp _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
