Hi John, Thanks for the report. More comments below:
> On 10 Oct 2018, at 11:10, John Beard <john.j.be...@gmail.com> wrote: > > Hi Jeff, > > In general it looks very nice. > > On GTK+ (Arch), freshly rebased and built today on the new GAL stuff. > > * The net field is reachable by tab-traversal. For example, in the > trace properties, it can be reached with "Shift-Tab, Shift-Tab" from > the default focus when the dialog opens. > * It cannot be activated with any key, as far as I can tell: > ** Any letter key does nothing > ** Enter accepts the whole dialog > ** Arrow keys move the focus away from the control <alt>-<down-arrow> will probably work, but that doesn’t seem to be a very commonly used shortcut. If wxWidgets doesn’t handle <enter>, then it will likely be difficult to fix. But <space-bar> (and even other letter keys) might be possible. > > Once the dialog is activated: > > * When the input field has focus, you can't tell, there's no cursor Focus works on OSX, but not GTK. I’m not sure about Windows. But even on OSX I forward all keys to the filter whether it has focus or not (so that it works like type-ahead in a combo-box). > * When you type, the first result is not highlighted, and of you press > enter, nothing is changed. If you press down arrow, it goes right to > the second entry, and you have to go back to the first entry with up > arrow. I’ve fixed the first result not being highlighted. After the first <down-arrow> do subsequent <down-arrow>s also advance by 2, or do they work properly? Don’t worry about response time; it works well enough now that we’re not keeping anyone from testing the master branch. Cheers, Jeff. > > Ctrl-Backspace works nicely. > > I can provide videos of anything now it's built, but might be a bit > slow to respond for the next couple of days. > > Cheers, > > John > > On Wed, Oct 10, 2018 at 10:47 AM Jeff Young <j...@rokeby.ie> wrote: >> >> Hi John, >> >> If you’re on Windows or GTK, I’d appreciate it if you could try out the Net >> Selector (in Track & Via Properties or Pad Properties) from the keyboard and >> tell me how it goes. It’s all good on OSX, but that’s the only machine I >> have. >> >> Cheers, >> Jeff. >> >> >>> On 10 Oct 2018, at 10:16, John Beard <john.j.be...@gmail.com> wrote: >>> >>> Hi, >>> >>> I do (try to) use most dialogs with the keyboard (limited sensation in >>> my fingers make mice and especially touchpads less useful to me). >>> >>> Correct handling of focus, tab-traversal and so on is also important >>> for accessibility reasons, as well as being indicative of a coherent >>> UI in general. It's pretty annoying to be able to fill in almost all >>> of a dialog, but have controls fail to work at random. >>> >>> Especially a dialog with multiple fields, you don't want to force >>> users to a "hover+key to invoke, type, move mouse, click, type, enter" >>> workflow, when you could have a "hover+key, type, tab, type, enter" >>> workflow - you forced a hand to the mouse AND back which should be >>> entirely avoidable. >>> >>> Cheers, >>> >>> John >>> On Tue, Oct 9, 2018 at 7:59 PM Eeli Kaikkonen <eeli.kaikko...@gmail.com> >>> wrote: >>>> >>>> >>>> >>>> ti 9. lokak. 2018 klo 17.05 Jeff Young (j...@rokeby.ie) kirjoitti: >>>>> >>>>> I think you had the latest; the GAL branch should have been up-to-date as >>>>> well. >>>>> >>>>> I’ve found a likely cause of the single-character-filter issue and pushed >>>>> a “fix”. >>>> >>>> >>>> It works with the latest master (808a7d94833f1a). The remaining issues are >>>> focus and selection related. I think accepting the selected net from the >>>> list is more important because when the user uses filtering (s)he already >>>> uses the keyboard. Selecting and opening the combobox with keyboard is >>>> probably rare, I don't know if anyone wants to use KiCad's dialogs (other >>>> than text and numbers) with keyboard. After all ECAD must be used with a >>>> pointer device anyways. >>>> >>>> Eeli Kaikkonen >>>> _______________________________________________ >>>> Mailing list: https://launchpad.net/~kicad-developers >>>> Post to : kicad-developers@lists.launchpad.net >>>> Unsubscribe : https://launchpad.net/~kicad-developers >>>> More help : https://help.launchpad.net/ListHelp >>> >>> _______________________________________________ >>> Mailing list: https://launchpad.net/~kicad-developers >>> Post to : kicad-developers@lists.launchpad.net >>> Unsubscribe : https://launchpad.net/~kicad-developers >>> More help : https://help.launchpad.net/ListHelp >> _______________________________________________ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net/ListHelp
