Re: [Kicad-developers] New pcbnew features and versioning

2016-04-09 Thread Chris Pavlina
Possible to implement, of course, but that could get rather messy as the parser has to be taught to ignore things it doesn't recognize, which is not exactly easy given the context-sensitive nature of our kinda-sorta-pseudo-parser implementation... I don't see the problem with refusing. It ensures

[Kicad-developers] PATCH: fix race condition related to 3D cache and resolver

2016-04-09 Thread Cirilo Bernardo
The attached patch fixes a segfault due to a race condition. If a user starts eeschema with an empty sheet and clicks the 'cvpcb' button, memory is corrupted and the program segfaults. The issue appears to arise from multiple threads accessing the 3D cache and resolver. This patch makes relevant co

Re: [Kicad-developers] New pcbnew features and versioning

2016-04-09 Thread Wayne Stambaugh
Chris, I looked at this patch and I thought you were going to add a check to warn the user that the board file may not load. Your patch will refuse to load any previous versions even if the file does not contain any new features. I'm not sure flat out rejecting newer board versions is a good ide

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Wayne Stambaugh
Great! Thanks for fixing this. It's been a long time coming. On 4/9/2016 4:20 PM, Chris Pavlina wrote: > wxFloatingPointValidator was pretty straightforward for this. 6679 switches > the > new arbitrary module text angle to FP units, refactors the dialog to use > TransferDataToWindow, and clean

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Chris Pavlina
wxFloatingPointValidator was pretty straightforward for this. 6679 switches the new arbitrary module text angle to FP units, refactors the dialog to use TransferDataToWindow, and cleans up the arbitrary angle patch a bit. I'll continue doing this with the other 0.1deg fields. On Sat, Apr 09, 2016

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Chris Pavlina
Awesome, I'm starting on that now. On Sat, Apr 09, 2016 at 02:36:49PM -0400, Wayne Stambaugh wrote: > We've being talking about this for a long time so I would like to see > this implemented. Entering 900 for 90.0 degrees really doesn't make > much sense. You may have to write your own validator

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Wayne Stambaugh
We've being talking about this for a long time so I would like to see this implemented. Entering 900 for 90.0 degrees really doesn't make much sense. You may have to write your own validator if wxFloatingPointValidator does not meet your needs. I haven't used wxFloatingPointValidator so I don't

Re: [Kicad-developers] New pcbnew features and versioning

2016-04-09 Thread Nick Østergaard
I have not read the patch, but my apparent comments about this inline. 2016-04-09 17:42 GMT+02:00 Chris Pavlina : > Here's a patch that checks the PCB file format version against the currently > supported one, and displays a message explaining the situation if the PCB file > is too recent. I assum

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Chris Pavlina
The others also have a minimum resolution too, unless you think you can align things to femtometers ;) On Sun, Apr 10, 2016 at 03:38:08AM +1200, Simon Wells wrote: > do they not have the difference of being limited to only 1 decimal > place unlike the others though? > > On Sun, Apr 10, 2016 at 3:

Re: [Kicad-developers] New pcbnew features and versioning

2016-04-09 Thread Chris Pavlina
Here's a patch that checks the PCB file format version against the currently supported one, and displays a message explaining the situation if the PCB file is too recent. I assumed MMDD format for the version. Message looks like this: KiCad was unable to open this file, as it was created w

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Simon Wells
do they not have the difference of being limited to only 1 decimal place unlike the others though? On Sun, Apr 10, 2016 at 3:27 AM, Chris Pavlina wrote: > Values already have to be validated. The only issue I can think of is related > to the decimal point / comma issue, but we're *already* accept

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Chris Pavlina
Values already have to be validated. The only issue I can think of is related to the decimal point / comma issue, but we're *already* accepting decimal points in values in other fields in the same dialogs (for positional offsets, for instance). I figure it should be fine as long as they're handled

Re: [Kicad-developers] 0.1 degrees

2016-04-09 Thread Simon Wells
This was seen in a previous thread iirc and wayne mentioned that someone would need to write it so that it verified values were entered correctly etc On Sun, Apr 10, 2016 at 2:37 AM, Chris Pavlina wrote: > Anyone mind if I go through and fix the "in 0.1 degrees" units that are all > over pcbnew?

[Kicad-developers] 0.1 degrees

2016-04-09 Thread Chris Pavlina
Anyone mind if I go through and fix the "in 0.1 degrees" units that are all over pcbnew? I don't see any reason why we can't let the user enter unit degrees with a decimal point. -- Chris ___ Mailing list: https://launchpad.net/~kicad-developers Post t

Re: [Kicad-developers] Reading eagle's lbrs directly

2016-04-09 Thread Daniel Wilches
With .lbr file I meant what Benjamin Nauck explained above. A file that has 4 things: the layout of physical pads of components' pads for the PCB, the schematic of the component, the mapping of physical pads to schematic pins and some metadata. For example, a device looks like this (pin mapping n