D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

brute4s99 added subscribers: nicolasfella, brute4s99. brute4s99 added a comment. +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella for linking me to this diff). I have hit the same problem with the KDE Connect Windows port. Thank you for working on it! REPOSITO

Re: Unusual behaviour in KDE Connect CMake

On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal wrote: > I'll get right on it > > On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley, wrote: > >> Hi all, >> >> Recently changes were made to kdeconnect-kde that introduced new >> dependencies that broke the build

Re: Unusual behaviour in KDE Connect CMake

I'll get right on it On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley, wrote: > Hi all, > > Recently changes were made to kdeconnect-kde that introduced new > dependencies that broke the build on Windows. > > While this in itself is an issue, it has exposed a much more significant > issue which require

D26888: work around to fully support the windows backend

brute4s99 updated this revision to Diff 80333. brute4s99 added a comment. work around to fully support the windows backend REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26888?vs=74291&id=80333 BRANCH arcpatch-D26888 REVISION DETAIL https://pha

D26888: work around to fully support the windows backend

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Information regarding upcoming Gitlab Migration

ear Sysadmin team's thoughts on this: Probably there can be a redirect system that lets us do git clone kde:knotifications and manages to redirect it to kde/frameworks/tier3/knotifications.git So we can clone and tinker with stuff as we normally do while the sysadmin team goes with the recommended system of setting up the repos. I think this should be possible because Invent already redirects my URLs which don't end with .git to .git ones. I might be wrong about my assumption that both things can work similarly. Best Piyush Aggarwal >

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. I'm sorry, missing what exactly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik, brute

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. closing this diff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29461: Fix kio-extras build on Windows

brute4s99 created this revision. brute4s99 added a reviewer: vonreth. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabric

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 82039. brute4s99 added a comment. needs testing on windows, will update in a while REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82036&id=82039 BRANCH arcpatch-D29461 REVISION DETAIL https://phabric

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 82069. brute4s99 added a comment. updated the diff REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82039&id=82069 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FI

D29461: Fix kio-extras build on Windows

brute4s99 added a subscriber: sitter. brute4s99 added a comment. @sitter could you please review this change as well? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx, niko

D29461: Fix kio-extras build on Windows

brute4s99 added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:26 > Hm, I am a bit hazy on the details but I think this changes makes no sense. > libssh (upstream) introduced an imported target `ssh`. For backwards > compatibility we also inject this target when building with

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 83159. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82069&id=83159 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FILES sftp/CMakeLists.txt sftp/kio_sftp.cpp T

D29461: Fix kio-extras build on Windows

brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasen

D29461: Fix kio-extras build on Windows

brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:26 > yes pls update libssh Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a lo

D29461: Fix kio-extras build on Windows

brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29461: Fix kio-extras build on Windows

brute4s99 added a comment. updated libssh to use version 0.9.4 by default in Craft. We can merge this and get 🟢 for kio-extras builds. \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel,

D29461: Fix kio-extras build on Windows

brute4s99 closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. I still do not understand the utility of this patch. What do you hope to fix by this patch exactly? > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. which compiler are you referring to here?

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added inline comments. INLINE COMMENTS > CMakeLists.txt:75 > if (WIN32) > -find_package(LibSnoreToast REQUIRED) > -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED please maintain the REQUIRED call for normal Windows builds. You can use the OS specific build vari

D21659: add .vscode to .gitignore

brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH vscode (branched from master) REVISION DETAIL https:

D21660: simplify conditions

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH simplify (branched from master) REVISION DETAIL https://phabricator.kde.org/D21660 AFFEC

D21660: simplify conditions and remove audio dependency for win32

brute4s99 retitled this revision from "simplify conditions" to "simplify conditions and remove audio dependency for win32". brute4s99 edited the summary of this revision. brute4s99 added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 T

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED

D21660: simplify conditions and remove audio dependency for win32

brute4s99 added a dependency: D21657: remove phonon from deps if building for win32. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a dependency: D21602: Add NSIS Script for KDE Connect. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99 Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 edited the summary of this revision. brute4s99 added reviewers: broulik, sredman, vonreth, albertvaka. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: kde-frameworks-devel, LeGast00n, michael

D21659: add .vscode to .gitignore

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e4461e0ba978: add .vscode to .gitignore (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21659?vs=59375&id=59378 REVISION DETAIL ht

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 5 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > sredman wrote in CMakeLists.txt:43 > Do you know whether this requires MSVC, or can SnoreToast.exe be built with > MSVC and KNotifications be built with an unspecified compiler? AFAIU it *should work

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59379. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated wrt review. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59377&id=59379 BRANCH win32 (branched from master) R

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 22 inline comments as done and an inline comment as not done. brute4s99 added a comment. update incoming INLINE COMMENTS > pino wrote in CMakeLists.txt:48-49 > why are these two needed? if snoretoast require them, then its cmake config > file must require them, so that the a

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59401. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated wrt review by toscanos REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59379&id=59401 BRANCH win32 (branched from

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. updating acc to review by pino REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59425. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated acc to review by Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59401&id=59425 BRANCH win32 (branched fro

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 4 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: simplify conditions and remove audio dependency for win32

brute4s99 updated this revision to Diff 59551. brute4s99 added a comment. fixed indentation REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59376&id=59551 BRANCH simplify (branched from master) REVISION DETAIL https://phabricator.kde.or

D21660: change audio dep logic wrt win32

brute4s99 retitled this revision from "simplify conditions and remove audio dependency for win32" to "change audio dep logic wrt win32". REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: apol, nicolasfella, kde-frameworks-devel, LeG

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59572. brute4s99 added a comment. updated acc to new reviews by Pino and Hannah REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59425&id=59572 BRANCH win32 (branched from master) REVISION DETAIL h

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. Oh! Apologies, Pino. Actually I accidentally referred to you as toscanos from IRC, so I deleted that comment. I'll avoid deleting them from now on. INLINE COMMENTS > pino wrote in notifybysnore.cpp:38 > `QCoreApplication` is enough (see below) Actually, I also use

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59573. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59572&id=59573 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt src/

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59574. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59573&id=59574 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt src/

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 67 inline comments as done. brute4s99 added a comment. updated code incoming. I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead? I'

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59765. brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59574&id=59765 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59766. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59765&id=59766 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt src/

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59774. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59766&id=59774 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES src/CMakeLists.txt src/

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59826. brute4s99 added a comment. rebased on upstream/master REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59774&id=59826 BRANCH win32 (branched from master) REVISION DETAIL https://phabricator.

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 59835. brute4s99 added a comment. updated acc to workaround for MSVC2019 suggested by Hannah added inline comment for it at L92 -- notifybysnore.cpp REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=598

D21660: change audio dep logic wrt win32

brute4s99 marked an inline comment as done. brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:42 > We don't need DBus on Windows, do we? we don't, I guess, but dbus-daemon.exe still runs in the background so I can't say. The functionality doesn't seem to h

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in notifybysnore.cpp:84 > if the notification is not found, this will be an uninitialized pointer; TBH > if the search for the notification with the specified id fails, then it > should be better to return earlier, as it means the no

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 60035. brute4s99 marked 9 inline comments as done. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=59835&id=60035 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FI

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:84 > well, I just found out the patch had broken functionality that I fixed just > after putting here an `else return`! 😆 I have fixed the issue now. REPOSITORY R289 KNotifications REVISION DETAIL http

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 10 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 created this revision. brute4s99 added reviewers: albertvaka, vonreth, sredman. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY CAUTION : Still WIP. The main functionali

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarrom

D22221: updated

brute4s99 created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R320 KIO Extras BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D1 AFFECTE

D22221: updated

brute4s99 abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D1 To: brute4s99 Cc: kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, brun

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61035. brute4s99 marked 6 inline comments as done. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=60701&id=61035 BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 AFFECTED FILES

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:12 > What requires this bump? ah, I thought QFileDevice needs it. Reverting this. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, s

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked an inline comment as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:402 > What about the QFileInfo? For my use case, I could not find any possibility of symlinks, (traversing Android filesystem) so I left it blank in here for any future d

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. In D22105#489954 , @vonreth wrote: > Any reason why you skip the symlinks? > I mean displaying thm should be fine, dolphin probably can also follow them. > Creating them on windows is a bit more problematic.

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 61084. brute4s99 added a comment. renamed variables (start with `m_` now) REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=60035&id=61084 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. I believe I have covered all the issues with the patch now. (: REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michae

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. ah, gotcha! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonre

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > albertvaka wrote in kio_sftp.cpp:2257 > I think what they mean is that if you remove the ifdef it should just work. `S_IFLNK` is not defined on WIndows REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brut

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61225. brute4s99 added a comment. added handling for WIndows. I'll try it on linux and revert on this patch! REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61035&id=61225 BRANCH arcpatch-D22105 REVISIO

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 9 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, mich

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in kio_sftp.cpp:2257 > Does > https://code.woboq.org/qt5/qtbase/mkspecs/common/posix/qplatformdefs.h.html#111 > work? yes! thanks Hannah! 🎉 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To:

D21660: change audio dep logic wrt win32

brute4s99 added a comment. In D21660#481421 , @bcooksley wrote: > Where possible D-Bus should be avoided on Windows. Thanks for taking a look, @bcooksley! We already use dbus-daemon.exe for a lot of talking with the notifications and (I

D21660: change audio dep logic wrt win32

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61419. brute4s99 added a comment. Updated with `QT_` pre-procs for S_IFDIR, S_IFLNK and others. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61225&id=61419 BRANCH arcpatch-D22105 REVISION DETAIL ht

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > kio_sftp.cpp:29 > #include > -#include > this builds without `utime.h` on my system (Arch Linux with latest Plasma, Qt and other packages), . Please inform if someone else has issues without this header. REPOSITORY R320 KIO Extras REV

D21660: change audio dep logic wrt win32

brute4s99 added a comment. may I land this? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61421. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=59551&id=61421 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > This seems to be entirely urelated to audio? I was trying to simplify code there by removing `NOT`. Should I remove this change? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61422. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61421&id=61422 BRANCH arcpatch-D21660 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > Yes. It is neither related to Windows nor audio. What you can to is to add > Windows to the condition to not look for DBus on Windows, but please do that > in a separate patch. Or move the find call for

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:38 > I'm looking into the DBus problem, we currently use DBus for the system tray > icon on Windows. Once that is resolved, I should be able to completely remove > DBus from the Windows build Update: nope. I t

D21660: change audio dep logic wrt win32

brute4s99 added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:38 > But this is KNotifications, not KDE Connect. So we need DBus for > KNotifications on Windows? ah, yeah we could bypass DBus on Windows in KNotifications REPOSITORY R289 KNotifications BRANCH arcpa

D21660: change audio dep logic wrt win32

brute4s99 updated this revision to Diff 61639. brute4s99 added a comment. no more dbus on Windows build of KNotifications REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61422&id=61639 BRANCH arcpatch-D21660_1 REVISION DETAIL https://ph

D21660: remove dbus and change audio dep logic

brute4s99 retitled this revision from "change audio dep logic wrt win32" to "remove dbus and change audio dep logic". brute4s99 edited the summary of this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, b

D21660: remove dbus for windows build and change audio dep logic

brute4s99 retitled this revision from "remove dbus and change audio dep logic" to "remove dbus for windows build and change audio dep logic". REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc

D21660: remove dbus for windows build and change audio dep logic

brute4s99 updated this revision to Diff 61716. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61639&id=61716 BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 AFFECTED FILES

D21660: remove dbus for windows build and change audio dep logic

brute4s99 marked 8 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. landing it REPOSITORY R289 KNotifications BRANCH arcpatch-D21660_1 REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, brun

D21660: remove dbus for windows build and change audio dep logic

This revision was automatically updated to reflect the committed changes. Closed by commit R289:be466180db21: remove dbus for windows build and change audio dep logic (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21660?vs=61716

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 61972. brute4s99 marked 7 inline comments as done. brute4s99 added a comment. updated wrt new comments. @dfaure please take another look! 👀 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61419&id=61972 BR

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > dfaure wrote in kio_sftp.cpp:2037 > Why ReadWrite, if we know it doesn't exist? > > Does setFileTime() even need open() first? I wouldn't have thought so. `setFileTime()` needs the file to be open. Source : https://doc.qt.io/qt-5/qfiledevice.h

D22554: Finer No-Dbus on Windows

brute4s99 created this revision. brute4s99 added reviewers: nicolasfella, broulik. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY remove another dependency related to DBus from Windows builds

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62051. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62048&id=62051 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. In D22554#497984 , @nicolasfella wrote: > Now HAVE_DBUSMENUQT won't be set. Previously it was set to 0 in this case Which line number are you referring to? REPOSITORY R289 KNotifications REVISION DETAIL ht

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62069. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62051&id=62069 BRANCH arcpatch-D22554 REVISION DETAIL https://phabricator.kde.org/D22554 AFFECTED FILES

D22554: Finer No-Dbus on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 updated this revision to Diff 62159. brute4s99 marked 4 inline comments as done. brute4s99 added a comment. udpated REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=61972&id=62159 BRANCH arcpatch-D22105 REVISION DETAIL https://phab

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in kio_sftp.cpp:2050-2051 > what is this commented code for? it uses buff.st_atime . Since I'm removing use of buff, I'm not sure how to handle this. For now I've commented out setting the file access time instruction for now. REPO

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 6 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, ale

  1   2   >