brute4s99 added a comment.
Oh! Apologies, Pino. Actually I accidentally referred to you as toscanos from IRC, so I deleted that comment. I'll avoid deleting them from now on. INLINE COMMENTS > pino wrote in notifybysnore.cpp:38 > `QCoreApplication` is enough (see below) Actually, I also use `applicationDisplayName()` as a fallback in case the notification does not have a `title()` set. One of the use cases was in KDE Connect itself (the pairing notification) > vonreth wrote in notifybysnore.cpp:47 > I think the server should be a bit more unique, what if two process of that > name exist? > How about the full application path as a qHash? Ooh! Sounds fun! I can do that :D > vonreth wrote in notifybysnore.h:44 > The amount of notifications should be small in which case a map has a better > performance. I referred to this: https://woboq.com/blog/qmap_qhash_benchmark.html REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
