brute4s99 marked 67 inline comments as done. brute4s99 added a comment.
updated code incoming. I think I should make a new diff for further discussions, as this one is quite riddled with suggestions now. Are there any more issues with this patch or should I continue with a new one instead? I'm willing to fix it further if you have some suggestions! ✊ INLINE COMMENTS > nicolasfella wrote in notifybysnore.cpp:44 > This should be documented somewhere else, too. Either the API dox or the KDE > wiki I've added more inline docs for now. @pino if you could guide me on how to update the docs on the website, that'd be great! 😃 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
