Review Request 126742: Add removeAllActions() to remove every applet interface action.

/appletinterface.cpp 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

an equivalent way to do this in the plasmoid? Diffs (updated) - src/scriptengines/qml/plasmoid/appletinterface.h ad68499 src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, Ja

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

view91122 --- On Jan. 15, 2016, 1:52 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30173. smithjd added a comment. Fix and optimize. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30048&id=30173 BRANCH master-filedeindexer REVISION DETAIL https://phabricator.kde.org/D11529 AFFECTED FILES

D11452: sanitizer: Improve device listing

smithjd added a comment. In D11452#230590 , @michaelh wrote: > In D11452#230387 , @smithjd wrote: > > > Could you please make your tab spacing conform to the style of the > > codebase? This should

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30466. smithjd added a comment. - Change check command description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30173&id=30466 BRANCH master-filedeindexer REVISION DETAIL https://phabricator.kde.org/D115

D11529: Balooctl: Deindex unfound files with check command.

smithjd added reviewers: vhanda, michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11038: balooctl: Add clean option to remove stale file index entries

smithjd added a comment. D11529 hooks up the index cleaner class. I've modified it so that it skips unmounted directories. This patch could probably be dropped, though some form of integrity checker that ignores mount points might still be useful for balo

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a comment. In D11529#233550 , @michaelh wrote: > Under the premise that I still have to learn about baloo's inner workings, here are some concerns: > > - I'm not convinced, that index cleaning should be part of the dbus interfa

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30573. smithjd marked 9 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30466&id=30573 BRANCH master-filedeindexer REVISION DETAIL https://

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > michaelh wrote in fileindexscheduler.h:83 > Nitpick: We're removing db entries not files. Also every file is deindexable. > Maybe 'purgeStaleEntries', 'removeLostEntries' or so would be a better name > to describe what's going on. This is doing

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30575. smithjd added a comment. - Fix a threading issue. - Fix check operation order. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30573&id=30575 BRANCH master-filedeindexer REVISION DETAIL https://phab

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30589. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. REPOSITORY R293 Baloo

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > michaelh wrote in fileindexerconfig.cpp:63 > Looks like you're reverting > https://cgit.kde.org/baloo.git/commit/?id=76c207a141423102ab0c5fba43fdafe3e205cca5 > with this No, making the StorageDevices object static so it can be exported. REPOSIT

D11038: balooctl: Add clean option to remove stale file index entries

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc: michaelh, ashaposhnikov, astippich, spoorun, nicolasfella, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 30804. smithjd added a comment. - Optimize and make the loop actually work. - Change check command description. - Review changes. - Fix a threading issue. - Fix check operation order. - Use a single StorageDevices object. - Partially revert the

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > broulik wrote in fileindexerconfig.cpp:63 > Please create the `StorageDevices` object on demand, otherwise this penalizes > all users of that class that just want to know whether Baloo itself is > enabled, which was the main reason for doing D112

D11529: Balooctl: Deindex unfound files with check command.

smithjd marked an inline comment as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 31136. smithjd added a comment. - Ignore the symlink target, only remove the index entry if the link is removed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=30804&id=31136 BRANCH master-filedeindexer (bran

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 34892. smithjd added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - Uniformly use storageDevices. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=31136&i

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

smithjd added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12

D13216: Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now sto

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY BUG: 353559 BUG: 378597 REPOSITORY R293 Baloo BRANCH master-schedule

D13216: Overhaul the file index scheduler.

smithjd retitled this revision from "Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now stops file indexing." to "Overhaul the file index scheduler.". smithjd

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35199. smithjd added a comment. - Minor simplification + fix: call checkUnindexedFiles when folder watches are installed instead of scheduleIndexing which can't check for changes in indexable files. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE ht

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 35204. smithjd added a comment. - New DBus method updateIndex(). - Change for D13216 . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=34892&id=35204 BRANCH master-filedein

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35730. smithjd added a comment. Split-up scheduler overhaul patchset. - The power state signal should only be emitted when the power state changes. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275538 , @bruns wrote: > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... > If you wan't your commits to stay separated, you have to do a `git c

D13216: Overhaul the file index scheduler.

smithjd added a comment. According to the arc documentation, a --merge commit should land the commits separately. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, s

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275582 , @bruns wrote: > In D13216#275581 , @smithjd wrote: > > > According to the arc documentation, a --merge commit should land the commits separately. > >

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35810. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35730&id=35810 BRAN

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH mastger-scheduler-updateConfig (branched from master) REVISI

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #balo

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added reviewers: mgallien, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change, halt the file indexer and run a file changed check when the file watches are updated." to "On config change halt the file indexer and run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL h

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 35812. smithjd added a comment. Separate out the content indexer halt on quit. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35811&id=35812 BRANCH master-scheduler-updateConfig (branched from master) REVISIO

D13425: Quit the file indexer when closing.

smithjd created this revision. smithjd added reviewers: bruns, mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-scheduler-ha

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13424: Run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change halt the file indexer and run a file changed check when the file watches are updated." to "Run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithj

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36415. smithjd added a comment. Run a full check for unindexed files when the watches are installed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35812&id=36415 BRANCH master-scheduler-watchesInstalled (bran

D13425: file indexer closing inprovements.

smithjd retitled this revision from "Quit the file indexer when closing." to "file indexer closing inprovements.". smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36416. smithjd added a comment. Consolidate file indexer close changes into a single review. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=35813&id=36416 BRANCH master-scheduler-haltonquit (branched from mast

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36417. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35810&id=36417 BRAN

D13424: Run a file changed check when the file watches are updated.

smithjd removed a dependent revision: D13425: file indexer closing inprovements.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, a

D13425: file indexer closing inprovements.

smithjd removed a dependency: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, sp

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, sp

D13424: Run a file changed check when the file watches are updated.

smithjd edited dependencies, added: D13425: file indexer closing inprovements.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashap

D13425: file indexer closing inprovements.

smithjd added a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippi

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36418. smithjd added a comment. - Remove a fixme. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36415&id=36418 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL https://phabri

D13424: Run a file changed check when the file watches are updated.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoo

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, b

D11529: Balooctl: Deindex unfound files with check command.

smithjd edited dependencies, added: D13424: Run a file changed check when the file watches are updated.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frame

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 36419. smithjd added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=35204&id=36419 BRANCH master-filedeindexer (branched from master) REVISION DETAIL https://phabricator.kde.org/D11529 AF

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36701. smithjd added a comment. re-word commits. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=36417&id=36701 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D132

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36702. smithjd added a comment. Change git commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36416&id=36702 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL https:/

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36703. smithjd added a comment. Change commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36418&id=36703 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL https

D13425: File indexer closing improvements.

smithjd retitled this revision from "file indexer closing inprovements." to "File indexer closing improvements.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh,

D16579: Fix APE tag extraction

smithjd updated this revision to Diff 52185. smithjd added a comment. - Use the de-facto Album Artist field name for APE tags. Re-base. REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16579?vs=44708&id=52185 BRANCH master-musepackFixes (branche

D16579: Fix APE tag extraction

smithjd added a comment. I realise that with all the fields referenced here having at least one standard fieldname parsed now that complaining may seem to be flogging a dead horse, but I'd like to re-iterate that identically-purposed fields should not be encouraged. This is at best a special

D16579: Remove support for non-standard APE tag field names

smithjd retitled this revision from "Fix APE tag extraction" to "Remove support for non-standard APE tag field names". smithjd edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16579 To: smithjd, astippich, bruns, mgallien Cc: br

D16579: Remove support for non-standard APE tag field names

smithjd added a comment. > Anyway, most of this special handling of mimetypes goes away with D18826 , where TagLib will do the conversion automatically. The test files should reflect the most common tag fieldnames; 'albumartist' is used in the APEv2 t

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added inline comments. INLINE COMMENTS > taglibextractor.cpp:109 > +{ > +if (savedProperties.contains("TITLE")) { > +result->add(Property::Title, > TStringToQString(savedProperties["TITLE"].toString()).trimmed()); This could return early if the property map is empty. > tagl

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:195 > I wanted to do so first, but that will require to also put the PropertyMap > into the extractAsfTags method, which I think is not worth it. lstASF = asfTags->attribute("WM/Writer"); ... The existing c

D18826: Rewrite the taglib extractor to use the generic PropertyMap interface

smithjd added a comment. This test fails: FAIL! : TagLibExtractorTest::testMp4(mp4) Compared values are not the same Actual (resultMp4.properties().value(Property::Rating).toInt()): 0 Expected (8) : 8 Loc: [/home/enderw

D16579: Remove support for non-standard APE tag field names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R286:4c5c4f5b91ab: Use 'ALBUM ARTIST' field name for APEv2 test files. (authored by smithjd). CHANGED PRIOR TO COMMIT htt

D16579: Remove support for non-standard APE tag field names from the test files

smithjd retitled this revision from "Remove support for non-standard APE tag field names" to "Remove support for non-standard APE tag field names from the test files". smithjd edited the summary of this revision. smithjd edited the test plan for this revision. REPOSITORY R286 KFileMetaData RE

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. In D16579#428790 , @ngraham wrote: > Two reviewers had open "Changes Requested" statuses on this patch when you committed it, and from the latest comments, it's not clear that their concerns were addressed first. Can you

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. The change was ack'ed in this review, and this review closed by the commit. There was no code that required further review, only binary changes. The posted concerns were addressed by D18826 . If you really are that concerne

D16579: Remove support for non-standard APE tag field names from the test files

smithjd added a comment. In D16579#428993 , @bruns wrote: > The change, as you pushed it, was never open for review, so there was not even the chance to review. Diff 44708 included these changes for review. No one requested changes then,

D8098: Strip down and re-write the tags KIO slave.

smithjd created this revision. smithjd added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Allow for more operations on tag trees (e.g. rename, copy, delete) and fix some existing issues. BUG: 314373 BUG: 340098 BUG: 376229 BUG: 332214

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Maybe update your local repo? It is against the most recent commit in master. It was diff'ed from a non-master branch... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks Cc: ngraham

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Copying/cutting file tags works both from local files and also tagged files. Breaking tags works, e.g. nested tag foo in bar can be copied or cut to foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag on the folder, copying applies the dest

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20320. smithjd added a comment. - Fix generating previews copies the file to tmp. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20222&id=20320 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20362. smithjd added a comment. - Fix tag navigation display labels in Dolphin. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20320&id=20362 BRANCH master-nestedTags (branched from master) REVISION DETAIL h

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Deep tag copies (to the filesystem and also in the slave) are known to be broken (1 or more folder deep) because of the preview fix in the first revision. REPOSITORY R293 Baloo BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21590. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. 1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the tags KIO slave.

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21599. smithjd added a comment. - Create a full url instead of only a path. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21590&id=21599 BRANCH master-nestedTags (branched from master) REVISION DETAIL https

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21851. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8098: Strip down and re-write the tags KIO slave.

smithjd marked 14 inline comments as done. smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:64 > - merge with previous line > > - can path() really contain '?' ? I thought that wasn't possible (? delimits > the query). Yes, the url is non-hierarchical scheme, so ev

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 22107. smithjd added a comment. - Merge local and tag file handling. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21851&id=22107 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phab

D8098: Strip down and re-write the baloo tags KIO slave

smithjd retitled this revision from "Strip down and re-write the tags KIO slave." to "Strip down and re-write the baloo tags KIO slave". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfel

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22712. smithjd added a comment. Make work with kioclient. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22107&id=22712 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.kde

D8098: Strip down and re-write the baloo tags KIO slave

smithjd marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22792. smithjd marked 6 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22712&id=22792 BRANCH master-nestedTags (branched from master) REVISIO

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:119 > I see an added check for "already exists" and an early return (good), but no > support for KIO::Overwrite. If the user uses dolphin to copy a tag they might > click on "overwrite" and it won't work, if copy() ju

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22857. smithjd marked 3 inline comments as done. smithjd added a comment. - Review suggestions. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22792&id=22857 BRANCH master-nestedTags (branched from master) REV

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kio_tags.h:101 > metaData(QString{}) Doesn't work. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: anthonyfieroni, dfaure, nicol

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22938. smithjd added a comment. - Fix valid tag calculation. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22857&id=22938 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. Currently known issues: Entering a tagged folder works, listing it from within the tags: protocol in the slave results in a folder cannot be entered error. Attempting to copy a tag tree with such a populated folder results in a file not found error for each file

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22940. smithjd added a comment. - Fix for slash-less tag urls. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22938&id=22940 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricato

  1   2   >