smithjd added inline comments.
INLINE COMMENTS
> taglibextractor.cpp:109
> +{
> + if (savedProperties.contains("TITLE")) {
> + result->add(Property::Title,
> TStringToQString(savedProperties["TITLE"].toString()).trimmed());
This could return early if the property map is empty.
> taglibextractor.cpp:195
> }
> -
> - itApe = lstApe.find("PERFORMER");
> - if (itApe != lstApe.end()) {
> - if (!data.performer.isEmpty()) {
> - data.performer += ", ";
> + /* Lyricist is called "WRITER" for wma/asf files */
> + if (savedProperties.contains("WRITER")) {
Can this be moved into the asf-specific extractions?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D18826
To: astippich, ngraham, bruns, mgallien
Cc: smithjd, kde-frameworks-devel, #baloo, domson, ashaposhnikov, michaelh,
astippich, spoorun, ngraham, bruns, abrahams
