On 26 November 2015 at 18:51, Alex Merry wrote:
> On 2015-11-26 09:27, René J.V. Bertin wrote:
>>
>> There's something I don't really understand though: the exact same
>> question you asked above.
>> What's the difference between starting kwrite directly on the
>> commandline (or through execve())
/wmiquery.h 8f3f0a458ad517153a0a76a812175346e84452fa
Diff: https://git.reviewboard.kde.org/r/115343/diff/
Testing
---
compiles now, didn't before
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
src/kjs/CMakeLists.txt c1c8cef2bf1e44c8d762d6894310ce68ca05b2d7
autotests/CMakeLists.txt 1268b8a6555fd36cd73f97beb6989b21056160f0
Diff: https://git.reviewboard.kde.org/r/115457/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde
global.h. I didn't feel like porting it to
generate_export_header, just wanted to get it to compile
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115457/#review48908
--
c09bd385ff2aa1dd48a80aa1032d26787514ce04
src/kjs/CMakeLists.txt c1c8cef2bf1e44c8d762d6894310ce68ca05b2d7
autotests/CMakeLists.txt 1268b8a6555fd36cd73f97beb6989b21056160f0
Diff: https://git.reviewboard.kde.org/r/115457/diff/
Testing
---
Thanks,
Alexander Richardson
c09bd385ff2aa1dd48a80aa1032d26787514ce04
src/kjs/CMakeLists.txt c1c8cef2bf1e44c8d762d6894310ce68ca05b2d7
autotests/CMakeLists.txt 1268b8a6555fd36cd73f97beb6989b21056160f0
Diff: https://git.reviewboard.kde.org/r/115457/diff/
Testing
---
Thanks,
Alexander Richardson
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115458/#review48973
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 4, 2014
://git.reviewboard.kde.org/r/115450/diff/
Testing (updated)
---
Compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
g/r/115459/#comment34577>
Missing #include
src/kwindowsystem.cpp
<https://git.reviewboard.kde.org/r/115459/#comment34579>
args... is GCC specific,
use #define D(name, ...) and then use __VA_ARGS__ instead of args
- Alexander Richardson
On Feb. 4, 2014, 9:13 a.m., Martin G
should work in all cases.
- Alexander Richardson
On Feb. 4, 2014, 9:13 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115378/#review48979
---
Ship it!
Looks good to me
- Alexander Richardson
On Feb
c843c2991a279a136fbccdf4e7c5ae5dd8358c0e
Diff: https://git.reviewboard.kde.org/r/115450/diff/
Testing
---
Compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
g/r/115459/#comment34670>
The non-MSVC macro has a return statement, I think this one needs it as well
- Alexander Richardson
On Feb. 5, 2014, 5:55 p.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115459/#review49113
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 6, 2014
> On Feb. 6, 2014, 2:14 a.m., Alexander Richardson wrote:
> > src/kwindowsystem.cpp, line 342
> > <https://git.reviewboard.kde.org/r/115459/diff/2-3/?file=242085#file242085line342>
> >
> > The non-MSVC macro has a return statement, I think this one needs it a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115617/#review49452
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 10, 2014
> On Feb. 10, 2014, 8:37 p.m., Dawit Alemayehu wrote:
> > Well the platform name was added for compatibility with what Firefox at the
> > time. And Chromium seems to have adapted that as well.
> >
> > The latest stable version of Firefox (version 27) for example sends the
> > following user ag
/r/115635/diff/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115634/ passes
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/115635/ is
applied, then they pass.
Rather ugly code IMO, open for suggestions to improve it...
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
autotests/signaltest.kcfgc PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115702/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
16234f70e45a703859fce42dcdb2ac1c2fdadade
src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e
Diff: https://git.reviewboard.kde.org/r/115209/diff/
Testing
---
Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied
Thanks,
Alexander Richardson
tps://git.reviewboard.kde.org/r/115723/#comment34981>
Maybe move the Q_OS_MAC up as the first check, then there is no need for
!defined(Q_OS_DARWIN)
- Alexander Richardson
On Feb. 13, 2014, 2:03 p.m., Martin Gräßlin wrote:
>
> ---
> This is a
16234f70e45a703859fce42dcdb2ac1c2fdadade
src/xslt.cpp 247b49b63ca16072f45c56308d432ecaba47810e
Diff: https://git.reviewboard.kde.org/r/115209/diff/
Testing
---
Works on windows once https://git.reviewboard.kde.org/r/115210/ is also applied
Thanks,
Alexander Richardson
e.cpp cfcacbdb980846c9ab25b9a857448d29bb674065
Diff: https://git.reviewboard.kde.org/r/115740/diff/
Testing
---
compiles, still works on linux
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinf
r.cpp aa2d273175ea72b600fdfef0ffd6460aa4904668
src/kicontheme.cpp cfcacbdb980846c9ab25b9a857448d29bb674065
Diff: https://git.reviewboard.kde.org/r/115740/diff/
Testing
---
compiles, still works on linux
Thanks,
Alexander Richardson
__
---
compiles, doesn't affect linux build
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
707882f356839fd85265abdcf6d96673102e3f64
Diff: https://git.reviewboard.kde.org/r/115741/diff/
Testing
---
compiles, doesn't affect linux build
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
Description
---
Allow compilation on windows
Diffs
-
src/browserextension.h 3ccafcbf0f6628cf7b07ce0436036bb972f95107
src/readwritepart.cpp 693cb76e05d975066ff93e69da27cc25d9dfe35d
Diff: https://git.reviewboard.kde.org/r/115742/diff/
Testing
---
compiles
Thanks,
Alexander
a3489cc4592f8f4d0f00ae5d5517fbf0d6a0ffd0
src/core/manager.cpp 191858da82363a9099f07f44746e0897de9d0f87
Diff: https://git.reviewboard.kde.org/r/115743/diff/
Testing
---
compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
/manager.cpp 191858da82363a9099f07f44746e0897de9d0f87
Diff: https://git.reviewboard.kde.org/r/115743/diff/
Testing
---
compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
someone else should
also have a look at it
- Alexander Richardson
On Feb. 10, 2014, 12:07 a.m., David Gil Oliva wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
tps://git.reviewboard.kde.org/r/115355/#comment34987>
This file is also needed by kcoreaddons (and I would also need it for
okteta, currently the mimetype subdir is commented out).
I think it would make more sense to have this in extra-cmake-modules.
- Alexander Richardson
On Feb. 12, 2014, 12:
ct
other platforms
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
cpp de50e83b66fb6d9f84696c106c1d3c1d75cde62f
src/plugin/kpluginloader.cpp e4f70fc87d563151ee34e8e69c54a0d47afb60c8
src/services/kservice.cpp d8ea9554474975f131b8bfc400d035d864added6
Diff: https://git.reviewboard.kde.org/r/115745/diff/
Testing
---
Thanks,
Alexander Richard
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115488/#review49763
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 4, 2014
> On Feb. 13, 2014, 11:27 p.m., Alexander Richardson wrote:
> > src/core/kprotocolmanager.cpp, line 690
> > <https://git.reviewboard.kde.org/r/115723/diff/1/?file=243874#file243874line690>
> >
> > Maybe move the Q_OS_MAC up as the first check, then t
OMMAND ${UPDATE_MIME_DATABASE_EXECUTABLE} -v
RETURN_VALUE _null OUTPUT_VARIABLE _smiVersionRaw ERROR_VARIABLE _smiVersionRaw)
- Alexander Richardson
On Feb. 14, 2014, 3:10 p.m., Alex Merry wrote:
>
> ---
> This is an automatically gener
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115748/#review49836
---
Ship it!
Ship It!
- Alexander Richardson
On Feb. 14, 2014
/115210/
Further discussion needed I guess
- Alexander Richardson
On Feb. 14, 2014, 7:49 p.m., Harald Fernengel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115702/#review49863
---
On Feb. 12, 2014, 6:06 p.m., Alexander Richardson wrote:
>
>
erated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115741/#review49874
-------
On Feb. 14, 2014, 12:22 a.m., Alexander Richardson wrote:
>
> ---
> This is
/kinit_win.cpp 707882f356839fd85265abdcf6d96673102e3f64
Diff: https://git.reviewboard.kde.org/r/115741/diff/
Testing
---
compiles, doesn't affect linux build
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kd
/kconfigdialog_unittest.cpp e5322c1782c2a68c15451777066e28a9b7afea23
autotests/signaltest.kcfg PRE-CREATION
autotests/signaltest.kcfgc PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115702/diff/
Testing
---
Thanks,
Alexander Richardson
n
testSetters
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115634/#review50007
---
On Feb. 11, 2014, 1:47 a.m., Alexan
/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115634/ passes
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ed e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115635/#review50006
---
On Feb. 17, 2014, 4:44 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically
somewhere in the build directory.
Diffs
-
autotests/kconfig_compiler/kconfigcompiler_test.cpp
48192f5ea8293a3bab010818511ceda4530dede3
Diff: https://git.reviewboard.kde.org/r/115832/diff/
Testing
---
Thanks,
Alexander Richardson
48192f5ea8293a3bab010818511ceda4530dede3
Diff: https://git.reviewboard.kde.org/r/115832/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks
tps://git.reviewboard.kde.org/r/115853/#comment35228>
It is used on Windows:
src/xslt.cpp:148:
replaceURLList[QLatin1String("http://www.oasis-open.org/docbook/xml/4.2";)] =
QString("file:///%1").arg(DOCBOOK_XML_CURRDTD);
- Alexander Richardson
On Feb. 17, 2014,
> On Feb. 18, 2014, 1:27 a.m., Alexander Richardson wrote:
> > src/ioslaves/help/config-help.h.cmake, line 3
> > <https://git.reviewboard.kde.org/r/115853/diff/1/?file=244683#file244683line3>
> >
> > It is used on Windows:
> > src/xslt.cpp:148:
tps://git.reviewboard.kde.org/r/115745/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
707882f356839fd85265abdcf6d96673102e3f64
Diff: https://git.reviewboard.kde.org/r/115741/diff/
Testing
---
compiles, doesn't affect linux build
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kd
change for Linux
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ca9cf0361dbe1bee3b0b76942c708110b7445ad5
Diff: https://git.reviewboard.kde.org/r/115874/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
1c0dc1cf63539e29236ab57e1e848930b468053a
Diff: https://git.reviewboard.kde.org/r/115875/diff/
Testing
---
Test still passes. No files (except kdeglobals) are created in ~/.qttest
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
48192f5ea8293a3bab010818511ceda4530dede3
Diff: https://git.reviewboard.kde.org/r/115832/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
tomatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115742/#review50246
-------
On Feb. 14, 2014, 12:59 a.m., Alexander Richardson wrote:
>
> -
--
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115872/#review50261
---
On Feb. 18, 2014, 8:52 p.m., Alexander Richardson wrote:
>
> -
7b1afc1b225481dd598002c4203feafbd3d23d34
src/core/interpreter.cpp a3489cc4592f8f4d0f00ae5d5517fbf0d6a0ffd0
src/core/manager.cpp 191858da82363a9099f07f44746e0897de9d0f87
Diff: https://git.reviewboard.kde.org/r/115743/diff/
Testing
---
compiles
Thanks,
Alexander Richardson
/kdirwatch_unittest.cpp ca9cf0361dbe1bee3b0b76942c708110b7445ad5
Diff: https://git.reviewboard.kde.org/r/115874/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
/
Testing
---
KLocalizedStringTest passes on Windows. All changes inside #ifdef Q_OS_WIN, so
no change for Linux
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
hange, now it does (win32), doesn't affect
other platforms
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
eems
less invasive than dropping that if statement.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115744/#review50283
-------
gly code IMO, open for suggestions to improve it...
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
737718d0244b23914678046bc519cf082e4b1a99
autotests/kconfig_compiler/test_signal.cpp.ref
fd2d4bc9941a6ee14f0a221fdd72ef663ee078a4
Diff: https://git.reviewboard.kde.org/r/115635/diff/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115634/ passes
Thanks,
Alexander Richardson
stat backend.
Diffs
-
autotests/kdirwatch_unittest.cpp ca9cf0361dbe1bee3b0b76942c708110b7445ad5
Diff: https://git.reviewboard.kde.org/r/115874/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde
ly, visit:
https://git.reviewboard.kde.org/r/115702/#review50375
---
On Feb. 16, 2014, 6:03 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mai
/readwritepart.cpp 693cb76e05d975066ff93e69da27cc25d9dfe35d
Diff: https://git.reviewboard.kde.org/r/115742/diff/
Testing
---
compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
w_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3
Diff: https://git.reviewboard.kde.org/r/115916/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
tps://git.reviewboard.kde.org/r/115918/diff/
Testing
---
ktexteditor fails to build before this patch (because moc can't find the .json
file), with the patch it compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-fr
/
Testing
---
Unit test from https://git.reviewboard.kde.org/r/115634/ passes
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/115634/diff/
Testing
---
Compiles, tests fail until https://git.reviewboard.kde.org/r/115635/ is
applied, then they pass.
Rather ugly code IMO, open for suggestions to improve it...
Thanks,
Alexander Richardson
___
Kde
--------
On Feb. 18, 2014, 10:52 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115875/
> -
does (win32), doesn't affect
other platforms
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
> >
>
> Alex Merry wrote:
> Arguably, the solution here is to always enable exceptions for code that
> encounters this (as we do for the OpenEXR QImage format plugin, for example).
>
> Alexander Richardson wrote:
> It works with all the STL headers, the question is
://git.reviewboard.kde.org/r/115742/diff/
Testing
---
compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
2014-02-21 1:17 GMT+01:00 Andrius da Costa Ribas :
> Afaik only Alexander Richardson is currently working on KF5 on Windows, but
> I think this kcm module is more related to plasma-workspace destination,
> given the settings it provides (see attached image)
>
> Em 20/02/2014 14
/kconfigdialog_unittest.cpp e5322c1782c2a68c15451777066e28a9b7afea23
autotests/signaltest.kcfg PRE-CREATION
autotests/signaltest.kcfgc PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/115702/diff/
Testing
---
Thanks,
Alexander Richardson
___
Kde-frameworks
/CMakeLists.txt d19b97f98e057d5537cf0eb6a8e1997d2a24cb1e
src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8
Diff: https://git.reviewboard.kde.org/r/116087/diff/
Testing
---
Compiles
Thanks,
Alexander Richardson
___
Kde-frameworks-devel
,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
NetworkManagerQt.pc.cmake 2c3ab07
Diff: https://git.reviewboard.kde.org/r/116098/diff/
Testing
---
Installed into the right directories after applying the patch.
grep -irn LIB_SUFFIX * returns nothing
Thanks,
Alexander Richardson
___
Kde
directories after applying the patch.
grep -irn LIB_SUFFIX * returns nothing
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
r
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116090/#review51010
-------
On Feb. 26, 2014, 6:03 p.m., Alexander Richardson wrote:
>
did I find out why.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review51427
---
On March 1, 2014, 12:14 p.
patch.
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
sh handler stop
all threads?
- Alexander
-------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116087/#review51440
---
On F
ake f70a185f4cd48293cb9f1e2ca4cf13defaf2aec3
Diff: https://git.reviewboard.kde.org/r/115918/diff/
Testing
---
ktexteditor fails to build before this patch (because moc can't find the .json
file), with the patch it compiles
Thanks,
Alexander Ri
/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a
Diff: https://git.reviewboard.kde.org/r/115875/diff/
Testing (updated)
---
Test still passes. No files (except kdeglobals) are created in ~/.qttest/config
Thanks,
Alexander Richardson
---
compiled all of kf5 + kate + kde-workspace without any issues using clang 3.3
Would be good if someone with an older clang version could test it and see
whether it works.
May also be related to the libstdc++ headers (4.8 installed here).
Thanks,
Alexander Richardson
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review51961
-------
On March 4, 2014, 9:58 p.m., Alexander Richardson wrote:
>
> ---
,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
t this still
> > make this test potentially conflict with other tests that use kdeglobals?
>
> Alexander Richardson wrote:
> Yeah it does. But now only tests using kdeglobals are a problem, before
> it deleted the whole ~/.qttest/config directory which means all config f
g/r/116603/#comment36946>
Maybe move this below bool checkPassword() so that it is protected? I don't
think it needs to be a public function, being able to customize it in
subclasses is fine IMO
- Alexander Richardson
On March 5, 2014, 12:05 a.m., Aleix Pol Gon
16098/#review51909
---
On March 4, 2014, 5:13 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://gi
3ab07
include/CMakeLists.txt 2b51ced
include/settings/CMakeLists.txt 1a00bdb
Diff: https://git.reviewboard.kde.org/r/116098/diff/
Testing
---
Installed into the right directories after applying the patch.
Thanks,
Alexander Richardson
__
kconfig in parallel.
Diffs
-
autotests/kconfigtest.cpp 1c0dc1cf63539e29236ab57e1e848930b468053a
Diff: https://git.reviewboard.kde.org/r/115875/diff/
Testing
---
Test still passes. No files (except kdeglobals) are created in ~/.qttest/config
Thanks,
Alexander Richardson
erated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115918/#review51946
---
On March 4, 2014, 9:45 p.m., Alexander Richardson wrote:
>
> ---
> This is an automatica
roken, it needs to be fixed soon (before the final 3.0 release).
>
> Alexander Richardson wrote:
> I'll try to reproduce it with a minimal test case, however I am away
> until Sunday, so it will be a while.
>
> Stephen Kelly wrote:
> I've pushed a fix to the
n.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92
src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c
Diff: https://git.reviewboard.kde.org/r/116699/diff/
Testing
---
tests still pass
Thanks,
Alexander Richardson
___
Kde-frameworks-devel mailing list
Kde-frame
1 - 100 of 451 matches
Mail list logo
