----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115635/ -----------------------------------------------------------
(Updated Feb. 17, 2014, 4:44 p.m.) Review request for KDE Frameworks. Changes ------- Fixed the issues that were raised Repository: kconfig Description ------- Make kconfig_compiler signals actually useful Previously the classes generated by kconfig_compiler would only emit the defined signals when using the setters provided by that class. However, when using e.g. KConfigDialog which uses KConfigSkeletonItem::setProperty() to change the items no signal was generated. This patch fixes this by using a wrapper KConfigSkeletonItem subclass that calls a private itemChanged() method in the generated class which updates the set of changed properties. As soon as the item is saved (usrWriteConfig() in the generated class is called) the signal will be emitted Diffs (updated) ----- autotests/kconfig_compiler/test_signal.h.ref 737718d0244b23914678046bc519cf082e4b1a99 src/core/kcoreconfigskeleton.h c1a158771a785151902cd0a36aa672623618b99e src/core/kcoreconfigskeleton.cpp d9b95b4b0f236f82b1d4831432d3e7637ef19365 src/kconfig_compiler/kconfig_compiler.cpp 0c4254a296348e02e596e9b10b76ff446f26bb65 autotests/kconfig_compiler/test_signal.cpp.ref fd2d4bc9941a6ee14f0a221fdd72ef663ee078a4 Diff: https://git.reviewboard.kde.org/r/115635/diff/ Testing ------- Unit test from https://git.reviewboard.kde.org/r/115634/ passes Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
