cgilles added a comment.
Renee,
I tested your patch against Solid under MacOS Sierra 10.12.6, and now digiKam
can see USB devices. Gre
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D7401
To: rjvbb, #frameworks
Cc: cgilles, kde-mac
rjvbb added a comment.
Perfect, good to know.
So, spoiler alert: I'll be pushing this (rebased and possibly polished where
appropriate) somewhere this week unless anyone objects.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D7401
To: rjvbb, #frameworks
Cc: cgil
mkoller created this revision.
mkoller added reviewers: davidedmundson, graesslin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I have akregator running and an icon is shown in the systray.
When the main window is c
anthonyfieroni added inline comments.
INLINE COMMENTS
> cfhelper.cpp:51-56
> +static QVariant q_toVariant(const CFTypeRef &obj, bool verbose=false)
> {
> const CFTypeID typeId = CFGetTypeID(obj);
> +// if (verbose) {
> +// qWarning() << "CFTypeID for obj" << obj << "=" << typeId
rjvbb added a comment.
Indeed. I'm pretty sure that got there because it was already in code I
cloned (for the simple reason this isn't a construct I'm familiar with =) ).
That said, there's inheritance inside the IOKit backend so this kind of
inheritance could make sense even without ex
graesslin requested changes to this revision.
graesslin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kstatusnotifieritem.cpp:653
> +KWindowSystem::raiseWindow(associatedWidget->winId());
> +KWindowSystem::forceActiveWindow(associa
mkoller added inline comments.
INLINE COMMENTS
> graesslin wrote in kstatusnotifieritem.cpp:653
> Please read the documentation of this API call. It is not meant for
> applications to use this!
>
> Please also note that this won't work on Wayland at all.
>
> The proper way is to ask the systra
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D8401
To: mkoller, mlaurent
Cc: #frameworks
marten added a comment.
Ping anyone?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D7823
To: marten, #frameworks, #build_system
Cc: cgiboudeaux, cfeck, heikobecker
Hi,
My cmake line:
cmake ../../kio -DCMAKE_BUILD_TYPE=RelWithDebInfo
-DCMAKE_INSTALL_PREFIX=~/GitProjects/builds/kio -DBUILD_TESTING=OFF
-DBUILD_QCH=ON -DKDE_INSTALL_LIBDIR=lib -DKDE_INSTALL_LIBEXECDIR=lib
make runs just fine
After that my bin folder looks like this [1], the relevant part (ls -l
On Sun, Oct 22, 2017 at 5:29 PM, Mark Gaiser wrote:
> Hi,
>
> My cmake line:
> cmake ../../kio -DCMAKE_BUILD_TYPE=RelWithDebInfo
> -DCMAKE_INSTALL_PREFIX=~/GitProjects/builds/kio -DBUILD_TESTING=OFF
> -DBUILD_QCH=ON -DKDE_INSTALL_LIBDIR=lib -DKDE_INSTALL_LIBEXECDIR=lib
>
> make runs just fine
>
>
graesslin added inline comments.
INLINE COMMENTS
> mkoller wrote in kstatusnotifieritem.cpp:653
> This code change will work as good as the other part of this file in wayland,
> since just about 30 lines below my change you find exactly the same 2 lines
> of code.
> Check the "else" branch in c
On Sunday, 22 October 2017 17:29:17 CEST Mark Gaiser wrote:
> Hi,
>
> My cmake line:
> cmake ../../kio -DCMAKE_BUILD_TYPE=RelWithDebInfo
> -DCMAKE_INSTALL_PREFIX=~/GitProjects/builds/kio -DBUILD_TESTING=OFF
> -DBUILD_QCH=ON -DKDE_INSTALL_LIBDIR=lib -DKDE_INSTALL_LIBEXECDIR=lib
>
> make runs just
On Sun, Oct 22, 2017 at 8:23 PM, Kevin Funk wrote:
> On Sunday, 22 October 2017 17:29:17 CEST Mark Gaiser wrote:
> > Hi,
> >
> > My cmake line:
> > cmake ../../kio -DCMAKE_BUILD_TYPE=RelWithDebInfo
> > -DCMAKE_INSTALL_PREFIX=~/GitProjects/builds/kio -DBUILD_TESTING=OFF
> > -DBUILD_QCH=ON -DKDE_IN
mkoller added inline comments.
INLINE COMMENTS
> graesslin wrote in kstatusnotifieritem.cpp:653
> The other code is also not correct and should be removed.
Do you mind telling me the correct approach ?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D8416
To: mk
graesslin added inline comments.
INLINE COMMENTS
> mkoller wrote in kstatusnotifieritem.cpp:653
> Do you mind telling me the correct approach ?
The correct approach would be sni telling the host to activate the window. The
host could then communicate with the X11 window manager/Wayland composit
ngraham added a comment.
@renatoo, there are still a few Not Done comments. Any chance you can resolve
them so we can push this forward?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8243
To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervi
ngraham accepted this revision.
ngraham added a comment.
@dvratil, any remaining objections? This looks great to me.
@renatoo, once this is in, can we remove the now-duplicated code from Dolphin?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #fra
mkoller added inline comments.
INLINE COMMENTS
> graesslin wrote in kstatusnotifieritem.cpp:653
> The correct approach would be sni telling the host to activate the window.
> The host could then communicate with the X11 window manager/Wayland
> compositor through a special interface that the wi
vpinon created this revision.
vpinon added reviewers: apol, kfunk.
vpinon added a project: Kdenlive.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
While cross-compiling Kdenlive with MXE, I had to use host's qrcAlias.
ngraham added reviewers: broulik, rkflx.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
elvisangelaccio added inline comments.
INLINE COMMENTS
> kstandardshortcut.cpp:159
> { KeyBindings, "KeyBindings", QT_TRANSLATE_NOOP3("KStandardShortcut",
> "Key Bindings", "@action"), 0, 0, QList(), false },
> -{ Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut",
> "P
vpinon created this revision.
vpinon added reviewers: vonreth, habacker.
vpinon added a project: Kdenlive.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
While cross-compiling Kdenlive with MXE (mingw64), I don't get pi
ngraham marked an inline comment as done.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,
#frameworks
ngraham updated this revision to Diff 21142.
ngraham added a comment.
Use syntax that's consistent with the rest of the file
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8296?vs=20839&id=21142
BRANCH
master
REVISION DETAIL
https://phabricator.kde.or
ngraham added a reviewer: Dolphin.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin
Cc: nicolasfella, ngraham
ngraham added a comment.
Can you add some testing details?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin
Cc: nicolasfella, ngraham
ngraham added a comment.
Any chance we can reach some kind of consensus here?
REVISION DETAIL
https://phabricator.kde.org/D7849
To: pgkos, #plasma
Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson,
plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ngraham added a comment.
@graesslin If this isn't currently merge-worthy, is there anything we can do
to make it so?
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D7829
To: dfaure, graesslin, jriddell, martinkostolny, broulik
Cc: ngraham, #frameworks
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
+1, this works great for me. Any other objections, or can I land this?
REVISION DETAIL
https://phabricator.kde.org/D7828
To: emateli, #frameworks, ngraham
Cc: ngraham, aacid, #framework
ngraham added a comment.
@safaalfulaij, any progress on the latest comments?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann
Cc: ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel
ngraham added a comment.
@carewolf, have you had a chance to work on this? It would be a shame for
such a lovely patch to fall by the wayside. :)
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D7033
To: carewolf, ilic
Cc: ngraham, dhaumann, ltoscano, kfunk, #framework
apol added inline comments.
INLINE COMMENTS
> CMakeLists.txt:33
> if(BINARY_ICONS_RESOURCE)
> -find_package(Qt5 NO_MODULE REQUIRED Core)
> -add_executable(qrcAlias qrcAlias.cpp)
> -target_link_libraries(qrcAlias PUBLIC Qt5::Core)
> +if(CMAKE_CROSSCOMPILING AND QRCALIAS_EXECUTABLE
ngraham edited the summary of this revision.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg, #frameworks
Cc: ngraham, cfeck, #frameworks
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
I ran with this change for a day in stock Neon and couldn't notice any
regressions (or any changes at all, actually).
https://phabricator.kde.org/tag/vdg/ folks, any objections? If I
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.7/51/
Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 23 Oct 2017 02:36:18 +
Build duration:
23 min and counting
JUnit T
ngraham added a comment.
I think we should remove the checkered background entirely or extend it to
the whole folder icon. It's just weird to have it only covering a seemingly
random half of the icon.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D4633
To: iv
ngraham added a comment.
Is this mergeable? @graesslin?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D1231
To: Kanedias, graesslin, davidedmundson
Cc: ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, leezu,
ZrenBot, progwolff, lesliezhai, ali-mohame
ngraham added a comment.
What are the next steps here?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: ngraham, kfunk, luebking, anthonyfieroni, dhaumann, kwrite-devel,
#ktexteditor, #frameworks, head7, cullmann, sars
ngraham edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D5037
To: rjvbb, #ktexteditor
Cc: ngraham, kfunk, luebking, anthonyfieroni, dhaumann, kwrite-devel,
#ktexteditor, #frameworks, head7, cullmann, sars
jgrulich requested changes to this revision.
jgrulich added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> security8021xsetting.h:66
>
> +void setDomain(const QString &domain);
> +QString domain() const;
Usually these methods are named according to pr
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
I'm still afraid that this will cause regressions again when introduced.
There is just too much weird stuff in keyboard handling. I would prefer if we
do such improvements only on Way
Martchus updated this revision to Diff 21149.
Martchus added a comment.
Changed the method names
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8402?vs=21069&id=21149
REVISION DETAIL
https://phabricator.kde.org/D8402
AFFECTED FILES
src/settin
jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.
Now it looks good. Just one thing I forgot is a unit test for this property.
You can add it to autotests/settings/8021xsettingtest.cpp and build the tests
with "-DBUILD_TESTIN
Martchus updated this revision to Diff 21153.
Martchus added a comment.
Add "domainSuffixMatch" to auto tests
REPOSITORY
R282 NetworkManagerQt
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8402?vs=21149&id=21153
REVISION DETAIL
https://phabricator.kde.org/D8402
AFFECTED FILES
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
Good to go. Thank you.
REPOSITORY
R282 NetworkManagerQt
REVISION DETAIL
https://phabricator.kde.org/D8402
To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, Z
graesslin added inline comments.
INLINE COMMENTS
> mkoller wrote in kstatusnotifieritem.cpp:653
> I'm a bit confused now.
> The patch solves my issue for X11 as it does some lines below already, but
> you say that this is wrong for Wayland but a solution for wayland does not
> exist right now.
vonreth accepted this revision.
vonreth added a comment.
This revision is now accepted and ready to land.
looks good to me (and it compiles)
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D8428
To: vpinon, vonreth, habacker
Cc: #frameworks, bartoloni, benjaminnelan, af
48 matches
Mail list logo
