graesslin added inline comments. INLINE COMMENTS
> mkoller wrote in kstatusnotifieritem.cpp:653 > I'm a bit confused now. > The patch solves my issue for X11 as it does some lines below already, but > you say that this is wrong for Wayland but a solution for wayland does not > exist right now. > I don't use Wayland, I'm on X11 and on X11 the solution works. > Why can't we simply add this 2 lines until there will be "the correct way" > for wayland as you suggest ? > Since you say the current code is wrong anyway, it needs some adaption anyway. > So until then, the current code plus my fix improves the situation for all > X11 users, and for Wayland you can change the code when all APIs are in place. It only works on X11 because KWin has a bug. KWin allows the force (which is in X11 Terms a "from tool" request) without checking who sends it. I will look into hardening this in KWin. Then the existing code won't work anymore. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8416 To: mkoller, davidedmundson, graesslin Cc: #frameworks
