elvisangelaccio added inline comments.

INLINE COMMENTS

> kstandardshortcut.cpp:159
>      { KeyBindings, "KeyBindings", QT_TRANSLATE_NOOP3("KStandardShortcut", 
> "Key Bindings", "@action"), 0, 0, QList<QKeySequence>(), false },
> -    { Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut", 
> "Preferences", "@action"), 0, 0, QList<QKeySequence>(), false },
> +    { Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut", 
> "Preferences", "@action"), Qt::ALT + Qt::Key_Comma, 0, QList<QKeySequence>(), 
> false },
>      { ConfigureToolbars, "ConfigureToolbars", 
> QT_TRANSLATE_NOOP3("KStandardShortcut", "Configure Toolbars", "@action"), 0, 
> 0, QList<QKeySequence>(), false },

I'd use `ALT(Comma)` here, for consistency with the other shortcuts.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D8296

To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, 
#frameworks

Reply via email to