Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-05 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 5, 2016, 10:28 a.m.) Status -- This change has been ma

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98132 --- Ship it! Ship It! - David Faure On Aug. 5, 2016, 1:32 a

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 5, 2016, 1:32 a.m.) Review request for KDE Frameworks and D

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98115 --- Fix it, then Ship it! Looks good, just one simplification

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
> On Aug. 3, 2016, 6:19 p.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > "I guess" isn't good enough for me, it's the point I want to clarify :-) > > > > I now did some

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-04 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated Aug. 4, 2016, 2:50 p.m.) Review request for KDE Frameworks and D

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98068 --- src/widgets/fileundomanager.cpp (line 421)

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-08-01 Thread Anthony Fieroni
> On Юли 31, 2016, 12:47 след обяд, David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: > For KIO::SimpleJob opStack is emp

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-31 Thread Chinmoy Ranjan Pradhan
> On July 31, 2016, 9:47 a.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: > For KIO::SimpleJob opStack is empty du

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-31 Thread David Faure
> On July 31, 2016, 9:47 a.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? > > Chinmoy Ranjan Pradhan wrote: > For KIO::SimpleJob opStack is empty du

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-31 Thread Chinmoy Ranjan Pradhan
> On July 31, 2016, 9:47 a.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > > > > > Why the isEmpty() check? For KIO::SimpleJob opStack is empty due to which m_fileCleanupStack is empty.

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review97941 --- src/widgets/fileundomanager.cpp (line 421)

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-31 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- (Updated July 31, 2016, 9:28 a.m.) Review request for KDE Frameworks, Ale

Re: Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review97926 --- Nice! Can you add a testcase in autotests/fileundomanagertest

Review Request 128527: FileUndoManager: Undoing symlink creation

2016-07-26 Thread Chinmoy Ranjan Pradhan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc