> On Aug. 3, 2016, 6:19 p.m., David Faure wrote: > > src/widgets/fileundomanager.cpp, line 421 > > <https://git.reviewboard.kde.org/r/128527/diff/2/?file=472624#file472624line421> > > > > "I guess" isn't good enough for me, it's the point I want to clarify :-) > > > > I now did some research. > > > > Thanks for reminding me of the Copy-Job based KIO::link. > > That one is supported by FileUndoManager (since it emits > > copyingLinkDone)... and in fact it's what we should be using in > > knewfilemenu.cpp, because it also supports popping up the "rename" dialog > > when trying to create a symlink with a name that already exists. > > > > KIO::symlink is the low-level operation, KIO::link is the high-level > > operation, with support for conflict-handling and undo. > > > > I think the real fix here is to change knewfilemenu.cpp - and the > > fileundomanager unittest - to use KIO::link. With a bit of luck, no change > > will be needed in fileundomanager itself ;-) > > > > Can you give it a try?
>"I guess" isn't good enough for me, it's the point I want to clarify :-) I'll take care of this next time :-) >I think the real fix here is to change knewfilemenu.cpp - and the >fileundomanager unittest - to use KIO::link The only issue with using KIO::link is that creating new links in Folder View plasmoid will fail due to the checks in CopyJob::linkNextFile. - Chinmoy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98068 ----------------------------------------------------------- On Aug. 4, 2016, 2:50 p.m., Chinmoy Ranjan Pradhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128527/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 2:50 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > This patch adds the support for undoing creation of new symlinks. > > > Diffs > ----- > > autotests/fileundomanagertest.h c663f92 > autotests/fileundomanagertest.cpp 761cc76 > src/filewidgets/knewfilemenu.cpp bb6fc04 > > Diff: https://git.reviewboard.kde.org/r/128527/diff/ > > > Testing > ------- > > build > > > Thanks, > > Chinmoy Ranjan Pradhan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
