----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128527/#review98115 -----------------------------------------------------------
Fix it, then Ship it! Looks good, just one simplification and it can be pushed. autotests/fileundomanagertest.cpp (line 469) <https://git.reviewboard.kde.org/r/128527/#comment66079> can be written shorter as FileUndoManager::self()->recordCopyJob(job); src/filewidgets/knewfilemenu.cpp (line 598) <https://git.reviewboard.kde.org/r/128527/#comment66080> same here - David Faure On Aug. 4, 2016, 2:50 p.m., Chinmoy Ranjan Pradhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128527/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 2:50 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > This patch adds the support for undoing creation of new symlinks. > > > Diffs > ----- > > autotests/fileundomanagertest.h c663f92 > autotests/fileundomanagertest.cpp 761cc76 > src/filewidgets/knewfilemenu.cpp bb6fc04 > > Diff: https://git.reviewboard.kde.org/r/128527/diff/ > > > Testing > ------- > > build > > > Thanks, > > Chinmoy Ranjan Pradhan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
